stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard
verified publisher icon stdlib-js

[RFC]: update `math/base/special/atanh` according to the FreeBSD implementation

Open gunjjoshi opened this issue 1 year ago • 3 comments

Description

This RFC proposes updating the C implementation for math/base/special/atanh, according to the FreeBSD implementation.

We need to convert the floating-point value to a word and then perform integer calculations, as given in the original FreeBSD implementation.

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • [X] I have read and understood the Code of Conduct.
  • [X] Searched for existing issues and pull requests.
  • [X] The issue name begins with RFC:.

gunjjoshi avatar Mar 29 '24 04:03 gunjjoshi

@gunjjoshi I would like to solve this issue

Deepakchowdavarapu avatar Aug 04 '24 13:08 Deepakchowdavarapu

@Deepakchowdavarapu Thanks for volunteering, go ahead!

gunjjoshi avatar Aug 04 '24 16:08 gunjjoshi

Hi @gunjjoshi , I've updated the atanh implementation as described in issue #2089. Could you please review my work in PR #2746? Also, if possible, I'd appreciate it if you could assign this issue to me. Thanks for your time and consideration!

Deepakchowdavarapu avatar Aug 05 '24 11:08 Deepakchowdavarapu