stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add C implementation for `math/base/special/sin`

Open xaman27x opened this issue 10 months ago • 2 comments

Description

What is the purpose of this pull request?

This pull request: Adds native C implementation for @stdlib/math/base/special/sin double stdlib_base_sin ( const double x );

Related Issues

Issue Tracker: https://github.com/stdlib-js/stdlib/issues/2018

This pull request:

  1. Adds C Implementation of @stdlib/node_moudles/math/base/special/sin

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

xaman27x avatar Mar 25 '24 07:03 xaman27x

NOTE: The sin function contains precision upto 4 floating points. (ie. +-0.00001) Thanks!

xaman27x avatar Mar 25 '24 07:03 xaman27x

@xaman27x As is, we cannot accept the changes introduced in this PR. Please ensure you study how other packages include C implementations.

E.g., don't write your own binding.gyp file, copy it from other packages, comments and all.

You shouldn't be modifying the contents of package.json, except for gypfile and directories. Use project Makefiles, copying them from other packages.

We have project tooling for compilation. Learn that tooling.

Your addon interface does not conform to our conventions.

Your C implementation needs considerable work. sin depends on rempio2: https://svnweb.freebsd.org/base/release/9.3.0/lib/msun/src/s_sin.c?view=markup. Meaning, the prerequisite for adding a C implementation to sin has not been satisfied in order to add this implementation.

Alright! I'll copy all necessary files henceforth! And since the Sin implementation requires C implementation of 'rempio2' as well, I'll work upon that first! Thank you for consideration Best.

xaman27x avatar Mar 25 '24 10:03 xaman27x

This PR has been superseded by #2349. Will go ahead and close. Thank you, @xaman27x, for your interest in stdlib.

kgryte avatar Jun 11 '24 08:06 kgryte