stdlib
stdlib copied to clipboard
bench: update benchmarks to measure affirmative/negative test values
Partially resolves #1148
Description
What is the purpose of this pull request?
This pull request:
- Refactors
assert/is-cube-number
benchmarks to measure affirmative/negative test values in separate benchmark runs to have a better handle on performance depending on the input value type.
Related Issues
Does this pull request have any related issues?
This pull request:
- partially resolves https://github.com/stdlib-js/stdlib/issues/1148
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
Benchmark results after refactor: isCubeNumberBenchmarks.txt
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
Hi @soumajit23 can you please populate the PR description so that we can identify what this PR is trying to do?
Hi @soumajit23 can you please populate the PR description so that we can identify what this PR is trying to do?
Hi @Pranavchiku! thanks for the feedback. Will do.
@Pranavchiku please check the description. Thanks in advance.
@kgryte @Pranavchiku I am getting this error message while trying to push. Please tell me how to fix this error.
this is the part that is showing the error I believe.
@soumajit23 Don't rebase unless you need to. In this case, you don't need to pull in the latest upstream changes for what you are working on.
I don't think the errors are due to your code. This seems to have been caused by a recent merge which contained a bug in its example code (cc @Planeshifter and @Pranavchiku).
@kgryte please check.
isCubeNumberBenchmarks(NEW).txt these are the new benchmark results
@Pranavchiku @kgryte hello, it has been a while, could you please review the changes and let me know if any more changes are required?