stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

test: add missing tests to `utils/circular-buffer`

Open skoriop opened this issue 1 year ago • 3 comments

Toward #474.

Description

What is the purpose of this pull request?

This pull request adds missing tests to utils/circular-buffer.

Related Issues

Does this pull request have any related issues?

This pull request progresses #474.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

skoriop avatar Feb 28 '24 00:02 skoriop

Hi, is there something blocking this?

skoriop avatar Mar 02 '24 07:03 skoriop

@skoriop Your changes look good and can be merged, but the linked issue includes adding tests for the remaining API surface area of the CircularBuffer class. Would you be able to add further tests for its methods? That would be much appreciated!

Planeshifter avatar Mar 02 '24 20:03 Planeshifter

As is, these changes do not satisfy #474.

kgryte avatar Mar 17 '24 10:03 kgryte