stdlib icon indicating copy to clipboard operation
stdlib copied to clipboard

feat: add `iter/cartesian-power`

Open TheNourhan opened this issue 1 year ago • 12 comments

Resolves #1336

Description

What is the purpose of this pull request?

The purpose of this pull request is to implement the iterCartesianPower function, which generates the Cartesian power of an input array-like object.

This pull request:

  • Implementation of the iterCartesianPower function in the lib folder.
  • Documentation updates in the docs folder, including:
    • Writing REPL usage examples in the docs/repl.txt file.
    • Writing TypeScript type definitions in the docs/types folder.
  • Writing a README.md file for the iterCartesianPower function.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #1336

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

TheNourhan avatar Feb 22 '24 18:02 TheNourhan

@TheNourhan Would you mind checking the box in the OP indicating that you've read the project contributing guidelines? Thanks!

kgryte avatar Feb 22 '24 21:02 kgryte

Also, please ensure that you have run make init and have installed EditorConfig. Currently, your contribution includes a number of lint errors and uses spaces rather than tabs in JavaScript files.

kgryte avatar Feb 22 '24 21:02 kgryte

Can you tell me the errors in any file, please?

TheNourhan avatar Feb 23 '24 09:02 TheNourhan

This PR is still missing tests and benchmarks.

kgryte avatar Feb 23 '24 09:02 kgryte

I used npm init, the Editorkonfig format and added Testes & Benchmarks, and updated the files you mentioned. The branch that I pulled doesn't show me errors.

Thanks for your feedback.

TheNourhan avatar Feb 23 '24 14:02 TheNourhan

@TheNourhan In general, I suggest trying to make your contribution look as closely to other packages as possible. We author everything in ES5 and we enforce various lint conventions, which are not currently adhered to.

kgryte avatar Feb 24 '24 08:02 kgryte

I made all the changes you mentioned except for the benchmark file and lint errors I will work on them after I fix the installation errors in my project because the make command does not work well in my env. Thanks for your feedback.

TheNourhan avatar Feb 24 '24 19:02 TheNourhan

I've made all the changes you mentioned

TheNourhan avatar Feb 25 '24 13:02 TheNourhan

@TheNourhan Great! Thanks for the update. We'll try and review within the next day or so.

kgryte avatar Feb 25 '24 19:02 kgryte

I'm going to close this PR and open a new one, I reinstalled the project and fixed all the errors

TheNourhan avatar Mar 15 '24 20:03 TheNourhan

@TheNourhan Sounds good. Feel free to do so.

kgryte avatar Mar 16 '24 08:03 kgryte

@TheNourhan Is this PR obsolete? Based on your prior comments, you were planning on submitting a new PR.

kgryte avatar Jun 11 '24 08:06 kgryte

@kgryte I've done it here https://github.com/stdlib-js/stdlib/pull/2534

TheNourhan avatar Jul 08 '24 09:07 TheNourhan