feat: add `iter/cartesian-power`
Resolves #1336
Description
What is the purpose of this pull request?
The purpose of this pull request is to implement the iterCartesianPower function, which generates the Cartesian power of an input array-like object.
This pull request:
- Implementation of the iterCartesianPower function in the
libfolder. - Documentation updates in the
docsfolder, including:- Writing REPL usage examples in the
docs/repl.txtfile. - Writing TypeScript type definitions in the
docs/typesfolder.
- Writing REPL usage examples in the
- Writing a README.md file for the iterCartesianPower function.
Related Issues
Does this pull request have any related issues?
This pull request:
- resolves #1336
Questions
Any questions for reviewers of this pull request?
No.
Other
Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.
No.
Checklist
Please ensure the following tasks are completed before submitting this pull request.
- [x] Read, understood, and followed the contributing guidelines.
@stdlib-js/reviewers
@TheNourhan Would you mind checking the box in the OP indicating that you've read the project contributing guidelines? Thanks!
Also, please ensure that you have run make init and have installed EditorConfig. Currently, your contribution includes a number of lint errors and uses spaces rather than tabs in JavaScript files.
Can you tell me the errors in any file, please?
This PR is still missing tests and benchmarks.
I used npm init, the Editorkonfig format and added Testes & Benchmarks, and updated the files you mentioned. The branch that I pulled doesn't show me errors.
Thanks for your feedback.
@TheNourhan In general, I suggest trying to make your contribution look as closely to other packages as possible. We author everything in ES5 and we enforce various lint conventions, which are not currently adhered to.
I made all the changes you mentioned except for the benchmark file and lint errors I will work on them after I fix the installation errors in my project because the make command does not work well in my env. Thanks for your feedback.
I've made all the changes you mentioned
@TheNourhan Great! Thanks for the update. We'll try and review within the next day or so.
I'm going to close this PR and open a new one, I reinstalled the project and fixed all the errors
@TheNourhan Sounds good. Feel free to do so.
@TheNourhan Is this PR obsolete? Based on your prior comments, you were planning on submitting a new PR.
@kgryte I've done it here https://github.com/stdlib-js/stdlib/pull/2534