stdlib
stdlib copied to clipboard
Add C implementation for `@stdlib/math/base/special/acsc`
Resolves #859.
Checklist
- [x] update readme.md
- [x] include.gypi
- [x] binding.gyp
- [x] include/stdlib/math/base/special/
- [x] src
- [x] manifest.json
- [x] lib
- [x] examples
- [x] benchmark
- [x] test
Feels good to be back :)
Not sure how can I run benchmarks and tests, I followed previous commands like
% make benchmark-c BENCHMARKS_FILTER=.*/math/base/special/acsc/.*
zsh: no matches found: BENCHMARKS_FILTER=.*/math/base/special/acsc/.*
% make examples-c EXAMPLES_FILTER=.*/math/base/special/acsc.*
zsh: no matches found: EXAMPLES_FILTER=.*/math/base/special/acsc/.*
How may I run javascript tests?
make test TESTS_FILTER=".*/math/base/special/acsc/.*"
should work.
@Pranavchiku I am not sure why those commands are not working for you. Can you trying surrounding the filter in quotes?
make benchmark-c BENCHMARKS_FILTER=".*/math/base/special/acsc/.*"
@Pranavchiku This is looking good. Thanks for working on this. The builtin C benchmark can be removed as acsc
is not a part of C99, TMK. We also need to add a gypfile
field to the package.json
. Once resolved, this PR should be ready for merge.
@Pranavchiku Are you interested in working to get this PR over the finish line?
I am afraid I will not be able to do it atm. I am fine if anyone else pick it up or if it is not a blocker I can look it up later at end of June.
We already merged a PR for the C implementation . Merged latest changes from develop
into the PR branch and will merge the now much smaller PR, which just consists of a few documentation and style improvements, shortly.