graph-v2 icon indicating copy to clipboard operation
graph-v2 copied to clipboard

Redundant and errorous class `dfs_visitor_base`. Why does it exist?

Open vspefs opened this issue 1 year ago • 0 comments

There is a 14-line little class in both "graph/algorithm/breadth_first_search.hpp" and "graph/algorithm/depth_first_search.hpp" that is dfs_visitor_base. When you try to #include both headerfiles, the exact same definition appears in one translation unit twice, which violates the ODR rule and thus making the program ill-formed.

dfs_visitor_base is not included in papers, not used for implementation, provides nearly no functionality. Why are they there (especially when it appears in a headerfile for bfs)? Why don't we remove them?

vspefs avatar Nov 07 '24 16:11 vspefs