staxrip icon indicating copy to clipboard operation
staxrip copied to clipboard

Project file not found when attempting to process batch files

Open jessielw opened this issue 2 years ago • 9 comments

Describe the bug StaxRip is looking for non existing project files. The files don't exist until the batch has started, however, it's causing an error if you try to press Load OR actually when processing the file sometimes you'll get a pop up with the same bug.

Expected behavior Not to look for a project file unless it's actually started processing the file

How to reproduce the issue This one is a little more difficult to reproduce. I queued up all 3 seasons of avatar the last airbender and this happened on the episodes in the screen shot. Initially I thought this was a long path error, but that is enabled in the OS as well as the encoder that I'm using.

Provide information Latest version of StaxRip Here is the error when I press Load when I click the episode and press load. image I however do expect this to happen since in reality it shouldn't have a project file yet, at least to my knowledge.

The real issue is when I'm actually trying to encode image

Some odd things I've noticed is the path like C:\Users\jlwServerWin\Desktop\StaxRip-v2.22.0-x64\Settings\Batch Projects\M--bhdstudio-downloads-Avatar.The.Last.Airbender.S01.BluRay.1080p.FLAC.2.0.AVC.REMUX-FraMeSToR- BHDStudio.3.5.5 (02-05-23) VapourSynth - Batch - avatar - Avatar.The.Last.Airbender.S01E19.The.Siege.of.the.North.Part.1.1080p.FLAC.2.0.AVC.REMUX-FraMeSToR.mkv.srip

This is clearly not a real path. Not really sure what is going on here.

jessielw avatar Jul 24 '23 18:07 jessielw

EDIT: The bug is actually triggered when using an Event Command that automatically runs with After Project Loaded image

Adjusting this to Before Processing seems to allow it to work

jessielw avatar Jul 24 '23 18:07 jessielw

The above did not solve it. It allowed some more to work but some others failed again

jessielw avatar Jul 24 '23 20:07 jessielw

Update: I played around with it for a bit. Shortening the template project name seemed to have fixed it. The ones that couldn't encode are now encoding. I'll update in the morning if they all get through with this change.

image

jessielw avatar Jul 25 '23 02:07 jessielw

Update it allowed more of them to run but didn't solve it.

So tbh I'm not sure as it right now.

jessielw avatar Jul 25 '23 07:07 jessielw

Update: All but 2 of them completed in this last batch.

Shortening the file names to those seemed to have allowed them to finish. However, directly loading them up as a non batch file with their same file length would have allowed them to work.

So this is some sort of bug somewhere in the code I'd imagine when it comes to pathing/batch projects. I don't know much C# or i'd look at it with you sorry :(

Example of the full path.

"M:\groupname\downloads\Avatar.The.Last.Airbender.S03.BluRay.1080p.FLAC.2.0.AVC.REMUX-FraMeSToR\Avatar.The.Last.Airbender.S03E10.The.Day.of.Black.Sun.Part.1.The.Invasion.1080p.FLAC.2.0.AVC.REMUX-FraMeSToR.mkv"

As you can see the pathname is petty long, but it's a bug somewhere.

jessielw avatar Jul 25 '23 17:07 jessielw

I'll have a look at it at some point, but File Batch is something I never use in my workflow, so don't expect a quick fix. 😕 But I think it helps a lot to know, that it is a path length issue and also the mention of your file path, so I can try to reproduce it.

  • So have I understood it correctly, that using Single File does work, but File Batch doesn't?
  • Which OS do you use?

Dendraspis avatar Jul 25 '23 18:07 Dendraspis

Yes, it opens the the file fine in Single File mode via drag and drop but File Batch fails. I tested the above against all files that failed.

Windows 10 64bit latest version for this machine.

jessielw avatar Jul 25 '23 23:07 jessielw

The problem still persists. File Batch with very long path + file name does not work. Same single file is OK. If I truncate the file name then I can use file batch. The problem, I think, is that no temp directory is created.

Same Windows 10 64 bit.

gkalemis avatar May 14 '24 16:05 gkalemis

Maybe I have found something ... the latest comment was very helpful!

Will be implemented with the next release...

Dendraspis avatar May 21 '24 18:05 Dendraspis