arc_ecto icon indicating copy to clipboard operation
arc_ecto copied to clipboard

allow passing binary data structs as attachments

Open azhi opened this issue 8 years ago • 14 comments

arc allows storing %{filename: filename, binary: data}, and now arc_ecto allows these structs to be accepted in cast_attachments

fixes #54

azhi avatar Jan 16 '18 15:01 azhi

I'm curious when this would be merged?

spscream avatar Jan 22 '18 11:01 spscream

@stavro is there any chance of this being merged soon? Or is there another solution that you'd recommend.

wethanet avatar May 31 '18 03:05 wethanet

That would be very usefull ; could you pls merge it ? txs

massetech avatar Jul 15 '18 09:07 massetech

up

Stanislav-Lapata avatar Sep 04 '18 14:09 Stanislav-Lapata

merge plz

gen1321 avatar Sep 19 '18 07:09 gen1321

Is there a reason you're not merging this? Really need this PR

NeverHappened avatar Oct 01 '18 09:10 NeverHappened

merge plz

artempankov avatar Nov 13 '18 15:11 artempankov

I'm also looking forward for this merge!

gabrielpra1 avatar Nov 24 '18 23:11 gabrielpra1

To have this merged would be of great help!

jungrafael avatar Nov 25 '18 00:11 jungrafael

Up, it would be great to have this merged, for now I had to run my own fork to go around the situation.. thanks @azhi for finding a solution 🙇

tiagonbotelho avatar Feb 01 '19 16:02 tiagonbotelho

@tiagonbotelho would you mind sharing that fork? @stavro is this repo being maintained any more? There are a lot of very useful PRs that are over a year old just gathering dust.

jprincipe avatar Feb 02 '19 04:02 jprincipe

@jprincipe sure thing I forked it here: https://github.com/duffelhq/arc_ecto 👍 I just fixed what was blocking my work. I have no current plans of maintaining my own fork. But if that changes in the future I'll be sure to post it here 😊

tiagonbotelho avatar Feb 02 '19 19:02 tiagonbotelho

Thanks @tiagonbotelho, I ended up forking master and manually pulled in the PR from @azhi. I'm going to try and go through some of the existing PRs and see what makes sense to pull in. Unsure if I'll continue to maintain it though.

jprincipe avatar Feb 02 '19 20:02 jprincipe

Hi @stavro ,

Do you have any plans to merge this PR?

bnymn avatar Apr 12 '20 12:04 bnymn