status.im icon indicating copy to clipboard operation
status.im copied to clipboard

status-go bundle with status-react

Open oskarth opened this issue 6 years ago • 9 comments

This used to be old wiki but was removed accidentally.

oskarth avatar Sep 19 '18 16:09 oskarth

If https://docs.status.im/docs/build_status_go.html covers this case, I think we can close this issue.

adambabik avatar Oct 02 '18 17:10 adambabik

Just skimmed, but doesn't mention https://github.com/status-im/status-react/blob/develop/scripts/bundle-status-go.sh so my guess it doesn't (unless the use of this script changed).

oskarth avatar Oct 03 '18 02:10 oskarth

Can we either fix this according to @oskarth's requirement @adambabik or close this issue please?

andytudhope avatar Nov 07 '18 13:11 andytudhope

I don't understand how someone can build status-react with custom status-go without knowing about this, so seems like it should be captured IMO

oskarth avatar Nov 07 '18 13:11 oskarth

Which page on wiki are we exactly taking about?

adambabik avatar Nov 07 '18 13:11 adambabik

https://status.im/build_status/status_go.html here or https://status.im/build_status/index.html

oskarth avatar Nov 07 '18 13:11 oskarth

So I believe we want to add a section explaining how to build a custom status-go on https://status.im/build_status/index.html?

adambabik avatar Nov 07 '18 13:11 adambabik

Is this ever going to happen @adambabik or can I close here?

andytudhope avatar Nov 28 '18 08:11 andytudhope

Please leave it, I will handle that. I need to do "docs day" :)

adambabik avatar Nov 28 '18 08:11 adambabik