status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard
verified publisher icon status-im

Remove unsupported notifications from ac notification data

Open ajayesivan opened this issue 7 months ago • 3 comments

fix #22418

Summary

There are several notification types that are not yet supported on mobile. When unsupported notifications are present in the notification data, this was causing a AC 'all' tab blank state.

This PR filters out unsupported notification types and renders only the supported ones to avoid this issue.

See the issue for the complete discussion.

Risk

Described potential risks and worst case scenarios.

Tick one:

  • [x] Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • [ ] High risk: QA team MUST perform additional testing in the specified affected areas before merging.

ajayesivan avatar May 16 '25 10:05 ajayesivan

@ilmotta @flexsurfer @ulisesmac @Parveshdhull Whenever you have a moment, could you please review this PR? Thanks in advance!

ajayesivan avatar May 16 '25 10:05 ajayesivan

Jenkins Builds

Click to see older builds (8)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 46109200 #1 2025-05-16 10:13:25 ~4 min tests :page_facing_up:log
:heavy_check_mark: 46109200 #1 2025-05-16 10:15:48 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 46109200 #1 2025-05-16 10:18:01 ~9 min android :robot:apk :calling:
:heavy_check_mark: 46109200 #1 2025-05-16 10:20:28 ~11 min ios :iphone:ipa :calling:
:heavy_check_mark: 62783d6b #2 2025-05-19 12:37:36 ~5 min tests :page_facing_up:log
:heavy_check_mark: 62783d6b #2 2025-05-19 12:41:07 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: 62783d6b #2 2025-05-19 12:41:56 ~10 min android :robot:apk :calling:
:heavy_check_mark: 62783d6b #2 2025-05-19 12:44:31 ~12 min ios :iphone:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: a3ed6cbd #3 2025-05-19 12:53:49 ~4 min tests :page_facing_up:log
:heavy_check_mark: a3ed6cbd #3 2025-05-19 12:58:08 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: a3ed6cbd #3 2025-05-19 12:58:50 ~10 min android :robot:apk :calling:
:heavy_check_mark: a3ed6cbd #3 2025-05-19 12:58:57 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: 7fcf83df #4 2025-05-20 03:47:51 ~4 min tests :page_facing_up:log
:heavy_check_mark: 7fcf83df #4 2025-05-20 03:52:21 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: 7fcf83df #4 2025-05-20 03:52:52 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: 7fcf83df #4 2025-05-20 03:52:58 ~10 min android :robot:apk :calling:

status-im-auto avatar May 16 '25 10:05 status-im-auto

88% of end-end tests have passed

Total executed tests: 24
Failed tests: 3
Expected to fail tests: 0
Passed tests: 21

IDs of failed tests: 727230,741841,742016

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestWalletCollectibles:

    1. test_wallet_collectible_send_from_expanded_info_view, id: 741841

    Device 1: Find `CollectibleItemElement` by `xpath`: `//*[@content-desc='collectible-list-item']//*[contains(@text,'Glitch Punks')]/../..`
    Device 1: Find `CollectibleItemElement` by `xpath`: `//*[@content-desc='collectible-list-item']//*[contains(@text,'Glitch Punks')]/../..` 
    wallet/test_collectibles.py:159: in test_wallet_collectible_send_from_expanded_info_view
    self.wallet_view.get_collectible_element('Glitch Punks').scroll_and_click()
../views/base_element.py:209: in scroll_and_click
    self.scroll_to_element(direction=direction)
../views/base_element.py:204: in scroll_to_element
    raise NoSuchElementException(
 Device 1: CollectibleItemElement by xpath: `//*[@content-desc='collectible-list-item']//*[contains(@text,'Glitch Punks')]/../..` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_erc20_from_drawer[Optimism Sepolia-USD Coin-USDC-2-0.01], id: 727230

    Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='USD Coin']/../android.widget.TextView[3]
    Device 1: Text is 47.06 USDC (EVM) 
    wallet_txs/test_wallet_testnet.py:101: in test_wallet_send_erc20_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:207: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: Verification of last transaction failed.The failed check: amount (Expected: 0.01 USDC, Found: 0.01 USDC (EVM))



    Device sessions

    2. test_wallet_send_erc20_from_drawer[Sepolia-USD Coin-USDC-2-0.01], id: 742016

    Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='USD Coin']/../android.widget.TextView[3]
    Device 1: Text is 47.07 USDC (EVM) 
    wallet_txs/test_wallet_testnet.py:101: in test_wallet_send_erc20_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:207: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Device 1: Verification of last transaction failed.The failed check: amount (Expected: 0.01 USDC, Found: 0.01 USDC (EVM))



    Device sessions

    Passed tests (21)

    Click to expand

    Class TestWalletCollectibles:

    1. test_wallet_send_collectible, id: 741840
    Device sessions

    2. test_wallet_collectibles_balance, id: 741839
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    2. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    3. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_send_eth[Status Network Sepolia-0.0002], id: 727229
    Device sessions

    2. test_send_eth[Arbitrum Sepolia-0.0001], id: 742015
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDeviceTwo:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestProfileMultipleDevices:

    1. test_profile_change_profile_photo, id: 741969
    Device sessions

    2. test_profile_change_username, id: 741968
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_delete, id: 702839
    Device sessions

    2. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    3. test_community_one_image_send_reply_set_reaction, id: 702859
    Device sessions

    4. test_community_message_edit, id: 702843
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    Class TestWalletCustomParamOneDevice:

    1. test_send_snt_custom_tx_params, id: 742910
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_swap_flow_mainnet, id: 741555
    Device sessions

    2. test_wallet_balance_mainnet, id: 740490
    Device sessions

    3. test_wallet_bridge_flow_mainnet, id: 741612
    Device sessions

    4. test_wallet_send_flow_mainnet, id: 741554
    Device sessions

    status-im-auto avatar May 19 '25 09:05 status-im-auto