status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

[EPIC] Transaction settings (nonce and limits)

Open vkjr opened this issue 1 year ago • 2 comments

UI

  • [ ] #21019
  • [ ] #21020
  • [ ] #21023
  • [ ] #21024
  • [ ] #21025
  • [ ] #21026
  • [ ] #21027

Backend Intergration

  • [ ] #21028
  • [ ] #21029
  • [ ] #21030
  • [ ] #21031

Tech debt

  • [x] #21017

vkjr avatar Aug 12 '24 11:08 vkjr

@shivekkhurana, @smohamedjavid, fyi. I've created a basic set of issues to implement transaction settings discussed in the meeting. Every issue contains the bare minimum and should be refined later.

vkjr avatar Aug 12 '24 12:08 vkjr

Blocked until designs are finished by @xAlisher Figma drafts (not for development)

vkjr avatar Oct 17 '24 16:10 vkjr

@vkjr @alwx We have this scheduled for 2.32. Although the designs are not final, the UX has been agreed upon.

We can start working on this. If there are UI changes requested, we can add it later.

shivekkhurana avatar Nov 04 '24 11:11 shivekkhurana

@shivekkhurana I've started working on this: https://github.com/status-im/status-mobile/issues/21551

alwx avatar Nov 05 '24 11:11 alwx

I do not think that it is feasible to include this feature to 2.32, postponing due to limited capacity in order to keep release scope clear

cc @shivekkhurana

churik avatar Nov 25 '24 14:11 churik

afaik Nonce and as Price is not feasible to include to 2.33, postponing for now cc @shivekkhurana - re-app if still needs to be included

churik avatar Jan 27 '25 15:01 churik

We can close this @shivekkhurana

mohsen-ghafouri avatar Apr 17 '25 08:04 mohsen-ghafouri

@mohsen-ghafouri, I believe we don't have a way to set custom transaction parameters for approval transactions, don't we? If so, probably this is something worth adding to the epic. @shivekkhurana, wdyt?

vkjr avatar Apr 17 '25 09:04 vkjr

Yes there wasn't any request to add transaction setting button for swap approval. If needed i can add it.

mohsen-ghafouri avatar Apr 17 '25 09:04 mohsen-ghafouri