status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard
verified publisher icon status-im

WC: Last account that established connection is not selected when connecting through global scanner #20801

Open alwx opened this issue 1 year ago • 6 comments

fixes #20801

Platforms

  • Android
  • iOS

status: ready

alwx avatar Jul 29 '24 12:07 alwx

Jenkins Builds

Click to see older builds (15)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 503f5f0e #3 2024-07-29 12:12:33 ~4 min tests :page_facing_up:log
:heavy_check_mark: 503f5f0e #3 2024-07-29 12:14:29 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 503f5f0e #3 2024-07-29 12:15:50 ~7 min android :robot:apk :calling:
:heavy_check_mark: f9f0a5fd #4 2024-08-12 10:24:31 ~4 min tests :page_facing_up:log
:heavy_check_mark: f9f0a5fd #4 2024-08-12 10:27:22 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: f9f0a5fd #4 2024-08-12 10:27:51 ~7 min android :robot:apk :calling:
:heavy_check_mark: f9f0a5fd #4 2024-08-12 10:29:20 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: 5ca67853 #7 2024-08-12 10:51:29 ~4 min tests :page_facing_up:log
:heavy_check_mark: 5ca67853 #7 2024-08-12 10:55:22 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 5ca67853 #7 2024-08-12 10:55:30 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5ca67853 #7 2024-08-12 10:55:52 ~9 min android :robot:apk :calling:
:heavy_check_mark: e6f253f9 #8 2024-09-17 08:20:58 ~6 min tests :page_facing_up:log
:heavy_check_mark: e6f253f9 #8 2024-09-17 08:24:12 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: e6f253f9 #8 2024-09-17 08:25:45 ~11 min android :robot:apk :calling:
:heavy_check_mark: e6f253f9 #8 2024-09-17 08:31:06 ~16 min ios :iphone:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 10b1741c #9 2024-09-17 10:56:18 ~4 min tests :page_facing_up:log
:heavy_check_mark: 10b1741c #9 2024-09-17 10:58:54 ~7 min android :robot:apk :calling:
:heavy_check_mark: 10b1741c #9 2024-09-17 10:59:30 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 10b1741c #9 2024-09-17 11:01:09 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: f31e0e52 #10 2024-09-17 12:49:20 ~4 min tests :page_facing_up:log
:heavy_check_mark: f31e0e52 #10 2024-09-17 12:52:26 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: f31e0e52 #10 2024-09-17 12:52:45 ~7 min android :robot:apk :calling:
:heavy_check_mark: f31e0e52 #10 2024-09-17 12:57:02 ~11 min ios :iphone:ipa :calling:

status-im-auto avatar Jul 29 '24 12:07 status-im-auto

I rebased this one and resolved the conflicts. Should be good to go but requires some re-testing. cc @status-im/mobile-qa

alwx avatar Aug 12 '24 10:08 alwx

71% of end-end tests have passed

Total executed tests: 7
Failed tests: 2
Expected to fail tests: 0
Passed tests: 5

IDs of failed tests: 727230,727229

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 1: Swiping right on element SlideButton
    Device 1: Find `SlideButton` by `xpath`: `//*[@resource-id='slide-button-track']` 
    critical/test_wallet.py:171: in test_wallet_send_asset_from_drawer
    self.wallet_1.send_asset_from_drawer(address='arb1:' + self.receiver['wallet_address'],
../views/wallet_view.py:158: in send_asset_from_drawer
    self.confirm_transaction()
../views/wallet_view.py:131: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:120: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 1: Text is 0.46221 ETH 
    critical/test_wallet.py:159: in test_wallet_send_eth
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4622 but expected to be 0.4623



    Passed tests (5)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    status-im-auto avatar Aug 13 '24 08:08 status-im-auto

    0% of end-end tests have passed

    Total executed tests: 2
Failed tests: 2
Expected to fail tests: 0
Passed tests: 0

    IDs of failed tests: 727230,727229

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find `Button` by `xpath`: `//android.view.ViewGroup[contains(@content-desc,'Account 1')]` 
    critical/test_wallet.py:164: in test_wallet_send_asset_from_drawer
    sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
critical/test_wallet.py:43: in _get_balances_before_tx
    self.wallet_1.get_account_element().click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by xpath: `//android.view.ViewGroup[contains(@content-desc,'Account 1')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track'] 
    critical/test_wallet.py:139: in test_wallet_send_eth
    self.wallet_1.send_asset(address='arb1:' + self.receiver['wallet_address'],
../views/wallet_view.py:148: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:131: in confirm_transaction
    self.slide_and_confirm_with_password()
../views/wallet_view.py:120: in slide_and_confirm_with_password
    self.slide_button_track.slide()
../views/base_view.py:257: in slide
    self.swipe_right_on_element(width_percentage=1.3, start_x=100)
../views/base_element.py:308: in swipe_right_on_element
    location, size = self.get_element_coordinates()
../views/base_element.py:294: in get_element_coordinates
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    status-im-auto avatar Aug 13 '24 09:08 status-im-auto

    Thanks for the PR @alwx !

    ISSUE 1: Account is not displayed in the modal when scanning QR with the global scanner

    Steps:

    1. Create a profile
    2. Open the global scanner
    3. Try to connect to a dapp

    If you press Connect the bottom sheet will be closed, but your wallet won't be connected to the dapp.

    Screenshot 2024-08-13 at 11 22 08

    https://github.com/user-attachments/assets/7c7fdbe1-82e7-45c5-a3ad-506026c59640

    qoqobolo avatar Aug 13 '24 09:08 qoqobolo

    Hey @alwx! Any updates on this?

    pavloburykh avatar Aug 27 '24 12:08 pavloburykh

    Hey @alwx !

    Any updates on this PR?

    mariia-skrypnyk avatar Sep 09 '24 10:09 mariia-skrypnyk

    Sorry, I lost this one. Will update today/tomorrow and let you know.

    alwx avatar Sep 09 '24 14:09 alwx

    Any updates on this PR? @alwx

    mariia-skrypnyk avatar Sep 16 '24 09:09 mariia-skrypnyk

    @mariia-skrypnyk ok, tomorrow morning :) Finally finished the current swaps work so it freed some time.

    alwx avatar Sep 16 '24 22:09 alwx

    @alwx thanks!

    ping me when it will be ready for me to test!

    mariia-skrypnyk avatar Sep 17 '24 08:09 mariia-skrypnyk

    @mariia-skrypnyk ready!

    alwx avatar Sep 17 '24 10:09 alwx

    71% of end-end tests have passed

    Total executed tests: 7
Failed tests: 2
Expected to fail tests: 0
Passed tests: 5

    IDs of failed tests: 727230,702843

    Failed tests (2)

    Click to expand
  • Rerun failed tests

    • Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843

    Device 1: Wait for text element `EmojisNumber` to be equal to `1`
    Device 1: Find `EmojisNumber` by `xpath`: `//*[starts-with(@text,'Message AFTER edit 2 (Edited)')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//*[@content-desc='emoji-reaction-2']/android.widget.TextView[2]` 
    critical/chats/test_public_chat_browsing.py:383: in test_community_message_edit
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message reaction is not shown for the sender



    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find Text by xpath: //android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]
    Device 2: Text is 0.06079 ETH 
    critical/test_wallet.py:190: in test_wallet_send_asset_from_drawer
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Sender balance is not updated on Etherscan, it is 0.4238 but expected to be 0.4239



    Passed tests (5)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    status-im-auto avatar Sep 17 '24 12:09 status-im-auto

    Thanks for the fix @alwx ! Checked on both platforms and looks good 🙌 Failed e2e are not related. PR can be merged.

    mariia-skrypnyk avatar Sep 17 '24 12:09 mariia-skrypnyk