status-mobile
status-mobile copied to clipboard
fix: address input multiline
fixes: https://github.com/status-im/status-mobile/issues/19788
This PR fix addresses input to support multiline.
Demo:
https://github.com/status-im/status-mobile/assets/29354102/7a45a979-e4e8-474f-9130-dd164277d39c
Jenkins Builds
Click to see older builds (25)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 261ae0e7945038ad877bebfc9799745a4abad045 | #1 | 2024-05-10 08:19:33 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 261ae0e7945038ad877bebfc9799745a4abad045 | #1 | 2024-05-10 08:20:15 | ~6 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 261ae0e7945038ad877bebfc9799745a4abad045 | #1 | 2024-05-10 08:23:47 | ~10 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 261ae0e7945038ad877bebfc9799745a4abad045 | #1 | 2024-05-10 08:25:17 | ~11 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 247aba933254da35e9f29027ff091023e8b2cb63 | #2 | 2024-05-10 11:09:56 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 247aba933254da35e9f29027ff091023e8b2cb63 | #2 | 2024-05-10 11:10:50 | ~6 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 247aba933254da35e9f29027ff091023e8b2cb63 | #2 | 2024-05-10 11:13:20 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 247aba933254da35e9f29027ff091023e8b2cb63 | #2 | 2024-05-10 11:13:58 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | d1e3dbe87e2e7414259d6d6c9d1207ddf4c6364f | #3 | 2024-05-14 08:44:37 | ~4 min | tests |
:page_facing_up:log |
| :x: | d1e3dbe87e2e7414259d6d6c9d1207ddf4c6364f | #3 | 2024-05-14 08:49:36 | ~9 min | ios |
:page_facing_up:log |
| :heavy_check_mark: | d1e3dbe87e2e7414259d6d6c9d1207ddf4c6364f | #3 | 2024-05-14 08:51:11 | ~11 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | d1e3dbe87e2e7414259d6d6c9d1207ddf4c6364f | #3 | 2024-05-14 08:51:15 | ~11 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | d1e3dbe87e2e7414259d6d6c9d1207ddf4c6364f | #4 | 2024-05-14 09:10:26 | ~10 min | ios |
:iphone:ipa :calling: |
| :x: | cf42a796db9b0232787cde3580d95663d7764e7c | #4 | 2024-05-15 10:08:40 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | cf42a796db9b0232787cde3580d95663d7764e7c | #4 | 2024-05-15 10:10:10 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | cf42a796db9b0232787cde3580d95663d7764e7c | #5 | 2024-05-15 10:14:06 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | cf42a796db9b0232787cde3580d95663d7764e7c | #4 | 2024-05-15 10:14:12 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 66cb217fb5dfbb6e9faa6e10aac274e2c51daa52 | #5 | 2024-05-15 10:37:10 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 66cb217fb5dfbb6e9faa6e10aac274e2c51daa52 | #5 | 2024-05-15 10:37:11 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 66cb217fb5dfbb6e9faa6e10aac274e2c51daa52 | #5 | 2024-05-15 10:40:50 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 66cb217fb5dfbb6e9faa6e10aac274e2c51daa52 | #6 | 2024-05-15 10:41:12 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | 01e2d32e17ac9d74f8af71967f75e55974ce37de | #6 | 2024-05-16 14:33:48 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 01e2d32e17ac9d74f8af71967f75e55974ce37de | #6 | 2024-05-16 14:38:21 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 01e2d32e17ac9d74f8af71967f75e55974ce37de | #6 | 2024-05-16 14:40:54 | ~11 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 01e2d32e17ac9d74f8af71967f75e55974ce37de | #7 | 2024-05-16 14:41:23 | ~11 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | c3d598c46b9794e856820e8521e0eb4a52198103 | #8 | 2024-05-16 15:00:19 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | c3d598c46b9794e856820e8521e0eb4a52198103 | #8 | 2024-05-16 15:05:57 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | c3d598c46b9794e856820e8521e0eb4a52198103 | #7 | 2024-05-16 15:06:55 | ~10 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | c3d598c46b9794e856820e8521e0eb4a52198103 | #7 | 2024-05-16 15:06:59 | ~10 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 33b8ac78872b18b1cbc3ababa00bf80e3cffa30b | #8 | 2024-05-16 15:22:13 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 33b8ac78872b18b1cbc3ababa00bf80e3cffa30b | #9 | 2024-05-16 15:22:29 | ~6 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 33b8ac78872b18b1cbc3ababa00bf80e3cffa30b | #8 | 2024-05-16 15:25:39 | ~9 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 33b8ac78872b18b1cbc3ababa00bf80e3cffa30b | #9 | 2024-05-16 15:28:04 | ~12 min | ios |
:iphone:ipa :calling: |
88% of end-end tests have passed
Total executed tests: 52
Failed tests: 5
Expected to fail tests: 1
Passed tests: 46
IDs of failed tests: 727230,704613,727229,702807,702775
IDs of expected to fail tests: 703503
Failed tests (5)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Expected to fail tests (1)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (46)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_mute_chat, id: 703495 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 5. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Hi @OmarBasem, thanks for PR!
ISSUE 1: Address is not aligned with the check icon on Android
Design
85% of end-end tests have passed
Total executed tests: 52
Failed tests: 6
Expected to fail tests: 2
Passed tests: 44
IDs of failed tests: 702851,704613,727230,727229,702807,702775
IDs of expected to fail tests: 703503,703495
Failed tests (6)
Click to expand
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Expected to fail tests (2)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (44)
Click to expand
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
| 2. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 4. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 5. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 3. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 4. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 5. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 8. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 9. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 10. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
| 11. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 3. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
| 4. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 5. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
Thanks for your testing @qoqobolo, fixed the issue!
Thanks @OmarBasem , but it's not aligned on iOS now 🥲
Figma
https://www.figma.com/design/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?node-id=689-192841&m=dev
Thanks for your testing @qoqobolo! Please check now and let me know
Thanks @OmarBasem, PR can be merged.