status-mobile
status-mobile copied to clipboard
fix: routes ui for bridge flow
fixes #19970
Summary
This PR fixes broken UI for routes on bridge flow (+ button should not be displayed in To column, also selected network is not showing). Also added new unit tests on relevant utils functions to cover these cases.
Testing notes
Bridge flow seems broken and user can't confirm Bridge operation, this PR only fixes routes ui.
Platforms
- Android
- iOS
Areas that maybe impacted
Functional
- wallet / transactions
Steps to test
- Open Status
- Login
- Go to wallet
- Go to account
- Tap on Bridge
- Select a network to bridge to
- Enter a valid amount
- Check routes UI are displayed correctly
Before and after screenshots comparison
Before
https://github.com/status-im/status-mobile/assets/18485527/9004400b-2faf-4d7b-afe6-4ac7fd277bf8
After
https://github.com/status-im/status-mobile/assets/18485527/2691e363-f1b0-46b4-80dc-b1c361d2a8d6
status: ready
Jenkins Builds
Click to see older builds (25)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f | #1 | 2024-05-09 19:11:12 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f | #1 | 2024-05-09 19:15:35 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f | #1 | 2024-05-09 19:16:49 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f | #1 | 2024-05-09 19:22:48 | ~14 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 | #3 | 2024-05-09 22:41:15 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 | #3 | 2024-05-09 22:41:45 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 | #3 | 2024-05-09 22:42:01 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 | #3 | 2024-05-09 22:45:32 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | e9e06b99b7683e5860425a229e1d63bce3b5f94f | #4 | 2024-05-12 22:19:01 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 533b755ba8766ace595186fadb1274bfc251806c | #5 | 2024-05-12 22:26:22 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 533b755ba8766ace595186fadb1274bfc251806c | #5 | 2024-05-12 22:29:53 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 533b755ba8766ace595186fadb1274bfc251806c | #5 | 2024-05-12 22:30:08 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 533b755ba8766ace595186fadb1274bfc251806c | #5 | 2024-05-12 22:31:07 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | d95def4ef7ab40f218b5672251d8b496fde49bd2 | #6 | 2024-05-15 08:23:50 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | d95def4ef7ab40f218b5672251d8b496fde49bd2 | #6 | 2024-05-15 08:26:45 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | d95def4ef7ab40f218b5672251d8b496fde49bd2 | #6 | 2024-05-15 08:26:52 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | d95def4ef7ab40f218b5672251d8b496fde49bd2 | #6 | 2024-05-15 08:28:11 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | c0f5cee925d6ca845dff142f4f7f199d0002145f | #7 | 2024-05-17 13:01:42 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | c0f5cee925d6ca845dff142f4f7f199d0002145f | #7 | 2024-05-17 13:03:49 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | c0f5cee925d6ca845dff142f4f7f199d0002145f | #7 | 2024-05-17 13:04:57 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | c0f5cee925d6ca845dff142f4f7f199d0002145f | #7 | 2024-05-17 13:09:34 | ~12 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 214e7aa3f0b3d0facc7126b85f7da3312c42a329 | #9 | 2024-05-17 13:53:50 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 214e7aa3f0b3d0facc7126b85f7da3312c42a329 | #9 | 2024-05-17 13:55:49 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 214e7aa3f0b3d0facc7126b85f7da3312c42a329 | #9 | 2024-05-17 13:55:51 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 214e7aa3f0b3d0facc7126b85f7da3312c42a329 | #9 | 2024-05-17 14:02:59 | ~13 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 | #10 | 2024-05-20 10:46:58 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 | #10 | 2024-05-20 10:49:18 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 | #10 | 2024-05-20 10:51:23 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 | #10 | 2024-05-20 10:53:39 | ~10 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 07e81de37607d8a3618914a4d8828c68bff7f1a3 | #11 | 2024-05-20 10:59:27 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 07e81de37607d8a3618914a4d8828c68bff7f1a3 | #11 | 2024-05-20 11:01:20 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 07e81de37607d8a3618914a4d8828c68bff7f1a3 | #11 | 2024-05-20 11:01:27 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 07e81de37607d8a3618914a4d8828c68bff7f1a3 | #11 | 2024-05-20 11:07:02 | ~12 min | ios |
:iphone:ipa :calling: |
PR description missing issue number, is there an open issue to be linked?
PR description missing issue number, is there an open issue to be linked?
@OmarBasem I haven't found one, I found the bug while testing and started to work on it, I will create one issue edit the description.
EDIT: Created #19970 and linked to it in the description
88% of end-end tests have passed
Total executed tests: 52
Failed tests: 5
Expected to fail tests: 1
Passed tests: 46
IDs of failed tests: 727230,704613,727229,702807,702775
IDs of expected to fail tests: 703503
Failed tests (5)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Expected to fail tests (1)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (46)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_mute_chat, id: 703495 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 5. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Testing of wallet PRs is blocked until the problem with networks/balances is resolved https://github.com/status-im/status-mobile/issues/20011
Testing of wallet PRs is blocked until the problem with networks/balances is resolved #20011
@qoqobolo are balances not fetching for non-testnet networks? AFAIK, bridges are not supported on Sepolia (at least as of now), so this should be tested on mainnet.
BTW, I need to solve conflicts before testing
@qoqobolo are balances not fetching for non-testnet networks? AFAIK, bridges are not supported on Sepolia (at least as of now), so this should be tested on mainnet.
Hey @briansztamfater, tbh it is not completely clear what and where exactly the problem is: those banners with The providers for Arbitrum, Mainnet, Optimism are down sometimes appear both on testnet and mainnet.
Yesterday it was impossible to test this PR, today it looks better, so hopefully we can test it soon.
It might also be better to test and update go version which includes changes to the router first and then test this PR, WDYT?
No problem @qoqobolo, I finished with the rebase and solving conflicts, so now is ready to test whenever you feel the conditions are met 👍 .
87% of end-end tests have passed
Total executed tests: 52
Failed tests: 5
Expected to fail tests: 2
Passed tests: 45
IDs of failed tests: 727230,702859,702840,727229,702807
IDs of expected to fail tests: 703495,703503
Failed tests (5)
Click to expand
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_one_image_send_reply, id: 702859 |
Device 1: Device 2: |
| 2. test_community_emoji_send_copy_paste_reply, id: 702840 |
Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Expected to fail tests (2)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (45)
Click to expand
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 3. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 4. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 5. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 6. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 9. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
| Device sessions Device 1: |
| 2. test_links_deep_links, id: 702775 |
| Device sessions Device 1: |
Thanks for your work and patience @briansztamfater! PR can be merged.