status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

fix: routes ui for bridge flow

Open briansztamfater opened this issue 1 year ago • 10 comments

fixes #19970

Summary

This PR fixes broken UI for routes on bridge flow (+ button should not be displayed in To column, also selected network is not showing). Also added new unit tests on relevant utils functions to cover these cases.

Testing notes

Bridge flow seems broken and user can't confirm Bridge operation, this PR only fixes routes ui.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Login
  • Go to wallet
  • Go to account
  • Tap on Bridge
  • Select a network to bridge to
  • Enter a valid amount
  • Check routes UI are displayed correctly

Before and after screenshots comparison

Before

https://github.com/status-im/status-mobile/assets/18485527/9004400b-2faf-4d7b-afe6-4ac7fd277bf8

After

https://github.com/status-im/status-mobile/assets/18485527/2691e363-f1b0-46b4-80dc-b1c361d2a8d6

status: ready

briansztamfater avatar May 09 '24 19:05 briansztamfater

Jenkins Builds

Click to see older builds (25)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:x: 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f #1 2024-05-09 19:11:12 ~2 min tests :page_facing_up:log
:heavy_check_mark: 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f #1 2024-05-09 19:15:35 ~7 min android :robot:apk :calling:
:heavy_check_mark: 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f #1 2024-05-09 19:16:49 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 89b7b3922b15cfab5b6b0f2592bf0046d5d2c96f #1 2024-05-09 19:22:48 ~14 min ios :iphone:ipa :calling:
:heavy_check_mark: 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 #3 2024-05-09 22:41:15 ~5 min tests :page_facing_up:log
:heavy_check_mark: 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 #3 2024-05-09 22:41:45 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 #3 2024-05-09 22:42:01 ~6 min android :robot:apk :calling:
:heavy_check_mark: 4dcf3e66420c54af6e0bcc3ae0d9e7f8cce01d25 #3 2024-05-09 22:45:32 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: e9e06b99b7683e5860425a229e1d63bce3b5f94f #4 2024-05-12 22:19:01 ~4 min tests :page_facing_up:log
:heavy_check_mark: 533b755ba8766ace595186fadb1274bfc251806c #5 2024-05-12 22:26:22 ~4 min tests :page_facing_up:log
:heavy_check_mark: 533b755ba8766ace595186fadb1274bfc251806c #5 2024-05-12 22:29:53 ~8 min android :robot:apk :calling:
:heavy_check_mark: 533b755ba8766ace595186fadb1274bfc251806c #5 2024-05-12 22:30:08 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 533b755ba8766ace595186fadb1274bfc251806c #5 2024-05-12 22:31:07 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: d95def4ef7ab40f218b5672251d8b496fde49bd2 #6 2024-05-15 08:23:50 ~5 min tests :page_facing_up:log
:heavy_check_mark: d95def4ef7ab40f218b5672251d8b496fde49bd2 #6 2024-05-15 08:26:45 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: d95def4ef7ab40f218b5672251d8b496fde49bd2 #6 2024-05-15 08:26:52 ~8 min android :robot:apk :calling:
:heavy_check_mark: d95def4ef7ab40f218b5672251d8b496fde49bd2 #6 2024-05-15 08:28:11 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: c0f5cee925d6ca845dff142f4f7f199d0002145f #7 2024-05-17 13:01:42 ~5 min tests :page_facing_up:log
:heavy_check_mark: c0f5cee925d6ca845dff142f4f7f199d0002145f #7 2024-05-17 13:03:49 ~7 min android :robot:apk :calling:
:heavy_check_mark: c0f5cee925d6ca845dff142f4f7f199d0002145f #7 2024-05-17 13:04:57 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: c0f5cee925d6ca845dff142f4f7f199d0002145f #7 2024-05-17 13:09:34 ~12 min ios :iphone:ipa :calling:
:heavy_check_mark: 214e7aa3f0b3d0facc7126b85f7da3312c42a329 #9 2024-05-17 13:53:50 ~4 min tests :page_facing_up:log
:heavy_check_mark: 214e7aa3f0b3d0facc7126b85f7da3312c42a329 #9 2024-05-17 13:55:49 ~6 min android :robot:apk :calling:
:heavy_check_mark: 214e7aa3f0b3d0facc7126b85f7da3312c42a329 #9 2024-05-17 13:55:51 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 214e7aa3f0b3d0facc7126b85f7da3312c42a329 #9 2024-05-17 14:02:59 ~13 min ios :iphone:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 #10 2024-05-20 10:46:58 ~3 min tests :page_facing_up:log
:heavy_check_mark: 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 #10 2024-05-20 10:49:18 ~6 min android :robot:apk :calling:
:heavy_check_mark: 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 #10 2024-05-20 10:51:23 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 725a57a7c2a3d7ebc4810cba40609fc9b8b7a0f9 #10 2024-05-20 10:53:39 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: 07e81de37607d8a3618914a4d8828c68bff7f1a3 #11 2024-05-20 10:59:27 ~5 min tests :page_facing_up:log
:heavy_check_mark: 07e81de37607d8a3618914a4d8828c68bff7f1a3 #11 2024-05-20 11:01:20 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 07e81de37607d8a3618914a4d8828c68bff7f1a3 #11 2024-05-20 11:01:27 ~7 min android :robot:apk :calling:
:heavy_check_mark: 07e81de37607d8a3618914a4d8828c68bff7f1a3 #11 2024-05-20 11:07:02 ~12 min ios :iphone:ipa :calling:

status-im-auto avatar May 09 '24 19:05 status-im-auto

PR description missing issue number, is there an open issue to be linked?

OmarBasem avatar May 10 '24 08:05 OmarBasem

PR description missing issue number, is there an open issue to be linked?

@OmarBasem I haven't found one, I found the bug while testing and started to work on it, I will create one issue edit the description.

EDIT: Created #19970 and linked to it in the description

briansztamfater avatar May 10 '24 09:05 briansztamfater

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 5
Expected to fail tests: 1
Passed tests: 46
IDs of failed tests: 727230,704613,727229,702807,702775 
IDs of expected to fail tests: 703503 

Failed tests (5)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab`
    critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer
        sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
    critical/test_wallet.py:39: in _get_balances_before_tx
        self.wallet_1.wallet_tab.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    2. test_wallet_send_eth, id: 727229

    Device 1: Swiping right on element SlideButton
    Device 1: Find SlideButton by xpath: //*[@resource-id='slide-button-track']
    critical/test_wallet.py:109: in test_wallet_send_eth
        self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
    ../views/wallet_view.py:99: in send_asset
        self.confirm_transaction()
    ../views/wallet_view.py:86: in confirm_transaction
        self.slide_and_confirm_with_password()
    ../views/wallet_view.py:80: in slide_and_confirm_with_password
        self.slide_button_track.slide()
    ../views/base_view.py:257: in slide
        self.swipe_right_on_element(width_percentage=1.3, start_x=100)
    ../views/base_element.py:308: in swipe_right_on_element
        location, size = self.get_element_coordinates()
    ../views/base_element.py:294: in get_element_coordinates
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: SlideButton by xpath: `//*[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613

    Device 1: Find Button by xpath: //*[@text="open community"]
    Device 1: Tap on found: Button
    critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE
    



    Device sessions

    2. test_links_deep_links, id: 702775

    Device 1: Find BrowserTab by accessibility id: browser-stack-tab
    Device 1: Tap on found: BrowserTab
    critical/test_deep_and_universal_links.py:114: in test_links_deep_links
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent
    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
        self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
    ../views/chat_view.py:225: in wait_for_status_to_be
        raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
     Message status was not changed to Delivered, it's Sent
    



    Device sessions

    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503
    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    status-im-auto avatar May 13 '24 08:05 status-im-auto

    Testing of wallet PRs is blocked until the problem with networks/balances is resolved https://github.com/status-im/status-mobile/issues/20011

    qoqobolo avatar May 15 '24 08:05 qoqobolo

    Testing of wallet PRs is blocked until the problem with networks/balances is resolved #20011

    @qoqobolo are balances not fetching for non-testnet networks? AFAIK, bridges are not supported on Sepolia (at least as of now), so this should be tested on mainnet.

    briansztamfater avatar May 15 '24 14:05 briansztamfater

    BTW, I need to solve conflicts before testing

    briansztamfater avatar May 15 '24 21:05 briansztamfater

    @qoqobolo are balances not fetching for non-testnet networks? AFAIK, bridges are not supported on Sepolia (at least as of now), so this should be tested on mainnet.

    Hey @briansztamfater, tbh it is not completely clear what and where exactly the problem is: those banners with The providers for Arbitrum, Mainnet, Optimism are down sometimes appear both on testnet and mainnet. Yesterday it was impossible to test this PR, today it looks better, so hopefully we can test it soon.

    It might also be better to test and update go version which includes changes to the router first and then test this PR, WDYT?

    qoqobolo avatar May 16 '24 12:05 qoqobolo

    No problem @qoqobolo, I finished with the rebase and solving conflicts, so now is ready to test whenever you feel the conditions are met 👍 .

    briansztamfater avatar May 17 '24 13:05 briansztamfater

    87% of end-end tests have passed

    Total executed tests: 52
    Failed tests: 5
    Expected to fail tests: 2
    Passed tests: 45
    
    IDs of failed tests: 727230,702859,702840,727229,702807 
    
    IDs of expected to fail tests: 703495,703503 
    

    Failed tests (5)

    Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    # STEP: Getting ETH amount in the wallet of the sender before transaction
    Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab`
    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
        sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx()
    critical/test_wallet.py:41: in _get_balances_before_tx
        self.wallet_1.wallet_tab.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:84: in find_element
        raise exception
    ../views/base_element.py:77: in find_element
        return self.driver.find_element(self.by, self.locator)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/webdriver.py:409: in find_element
        return self.execute(RemoteCommand.FIND_ELEMENT, {'using': by, 'value': value})['value']
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
        self.error_handler.check_response(response)
    ../../../../status-app-prs@tmp/venv/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
        raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
     An unknown server-side error occurred while processing the command. Original error: 'POST /element' cannot be proxied to UiAutomator2 server because the instrumentation process is not running (probably crashed). Check the server log and/or the logcat output for more details
    E   Stacktrace:
    E   UnknownError: An unknown server-side error occurred while processing the command. Original error: 'POST /element' cannot be proxied to UiAutomator2 server because the instrumentation process is not running (probably crashed). Check the server log and/or the logcat output for more details
    E       at UIA2Proxy.command (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/jsonwp-proxy/proxy.js:355:13)
    E       at processTicksAndRejections (node:internal/process/task_queues:95:5)
    E       at AndroidUiautomator2Driver.helpers.doFindElementOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/lib/commands/find.js:30:10)
    E       at doFind (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:36:17)
    E       at wrappedCondFn (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:137:14)
    E       at spin (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:221:20)
    E       at waitForCondition (/mnt/sauce/appium/appium-v2.0.0/node_modules/asyncbox/lib/asyncbox.js:238:10)
    E       at AndroidUiautomator2Driver.implicitWaitForCondition (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/timeout.ts:139:12)
    E       at AndroidUiautomator2Driver.findElOrEls (/mnt/sauce/appium/appium-v2.0.0/appium_home/linux/node_modules/appium-uiautomator2-driver/node_modules/appium-android-driver/lib/commands/find.js:60:5)
    E       at AndroidUiautomator2Driver.findElOrElsWithProcessing (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:60:12)
    E       at AndroidUiautomator2Driver.findElement (/mnt/sauce/appium/appium-v2.0.0/packages/base-driver/lib/basedriver/commands/find.ts:75:12)
    



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: LogInButton
    Device 1: Find Button by accessibility id: done
    critical/test_wallet.py:111: in test_wallet_send_eth
        self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
    ../views/wallet_view.py:100: in send_asset
        self.confirm_transaction()
    ../views/wallet_view.py:88: in confirm_transaction
        self.done_button.click()
    ../views/base_element.py:90: in click
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Class TestCommunityMultipleDeviceMerged:

    1. test_community_one_image_send_reply, id: 702859

    Device 2: Click system back button
    Device 2: Looking for a message by text: description
    critical/chats/test_public_chat_browsing.py:440: in test_community_one_image_send_reply
        self.channel_2.chat_element_by_text(image_description).wait_for_visibility_of_element(10)
    ../views/base_element.py:147: in wait_for_visibility_of_element
        raise TimeoutException(
     Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'description')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element
    



    Device sessions

    2. test_community_emoji_send_copy_paste_reply, id: 702840

    Device 2: Quoting '🤜🏽' message
    Device 2: Find BaseElement by xpath: //*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'🤜🏽')]
    critical/chats/test_public_chat_browsing.py:523: in test_community_emoji_send_copy_paste_reply
        self.channel_2.quote_message(emoji_unicode)
    ../views/chat_view.py:1040: in quote_message
        self.chat_view_element_starts_with_text(message).long_press_until_element_is_shown(self.reply_message_button)
    ../views/base_element.py:327: in long_press_until_element_is_shown
        element = self.find_element()
    ../views/base_element.py:79: in find_element
        raise NoSuchElementException(
     Device 2: BaseElement by xpath: `//*[@content-desc=':chat-floating-screen']//*[starts-with(@text,'🤜🏽')]` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
    



    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent
    critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
        self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
    ../views/chat_view.py:225: in wait_for_status_to_be
        raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
     Message status was not changed to Delivered, it's Sent
    



    Device sessions

    Expected to fail tests (2)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement
    critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat
        self.errors.verify_no_errors()
    base_test_case.py:190: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Chat is still muted after timeout 
    

    [[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503
    Test is not run, e2e blocker  
    

    [[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    4. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    5. test_community_message_delete, id: 702839
    Device sessions

    6. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    7. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    8. test_community_message_edit, id: 702843
    Device sessions

    9. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    2. test_wallet_add_remove_watch_only_account, id: 727232
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    status-im-auto avatar May 17 '24 15:05 status-im-auto

    Thanks for your work and patience @briansztamfater! PR can be merged.

    qoqobolo avatar May 20 '24 10:05 qoqobolo