Wallet: Activity Items - Sections
fixes: https://github.com/status-im/status-mobile/issues/19852
epic: https://github.com/status-im/status-mobile/issues/19849
Summary
This PR implements sectioning for the activity items.
Note:
The other two issues in this epic will be out of scope from the July release.
Demo:
https://github.com/status-im/status-mobile/assets/29354102/f17849c1-6e55-4237-9038-3b2547b1cba1
Jenkins Builds
Click to see older builds (51)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | cabe5ab02915c93c9d91773a124efd8e5c7d7f24 | #1 | 2024-05-06 08:55:48 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | cabe5ab02915c93c9d91773a124efd8e5c7d7f24 | #1 | 2024-05-06 08:59:48 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | cabe5ab02915c93c9d91773a124efd8e5c7d7f24 | #1 | 2024-05-06 09:01:25 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | cabe5ab02915c93c9d91773a124efd8e5c7d7f24 | #1 | 2024-05-06 09:02:42 | ~9 min | android-e2e |
:robot:apk :calling: |
| :x: | ef180796d56d3be000bc87eed9f30640fe550466 | #2 | 2024-05-06 09:05:22 | ~2 min | tests |
:page_facing_up:log |
| :x: | 10237b933641e1ff5aca7b8314cdf4ba16b041e4 | #3 | 2024-05-06 09:07:26 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 10237b933641e1ff5aca7b8314cdf4ba16b041e4 | #3 | 2024-05-06 09:12:26 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 10237b933641e1ff5aca7b8314cdf4ba16b041e4 | #3 | 2024-05-06 09:12:41 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 10237b933641e1ff5aca7b8314cdf4ba16b041e4 | #3 | 2024-05-06 09:14:02 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | 2a22cf339d8c181856008e49792fee30a5d1bbf2 | #4 | 2024-05-08 06:47:00 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 2a22cf339d8c181856008e49792fee30a5d1bbf2 | #4 | 2024-05-08 06:51:22 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 2a22cf339d8c181856008e49792fee30a5d1bbf2 | #4 | 2024-05-08 06:52:45 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 2a22cf339d8c181856008e49792fee30a5d1bbf2 | #4 | 2024-05-08 06:53:46 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | 62383cf205bc0da43c113bf5deeb902dff5bf1cb | #5 | 2024-05-08 06:58:35 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 62383cf205bc0da43c113bf5deeb902dff5bf1cb | #5 | 2024-05-08 07:02:45 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 62383cf205bc0da43c113bf5deeb902dff5bf1cb | #5 | 2024-05-08 07:02:47 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 62383cf205bc0da43c113bf5deeb902dff5bf1cb | #5 | 2024-05-08 07:03:51 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | 8223986188567902840a70580a3e0896a49603db | #6 | 2024-05-08 07:11:19 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 8223986188567902840a70580a3e0896a49603db | #6 | 2024-05-08 07:15:20 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 8223986188567902840a70580a3e0896a49603db | #6 | 2024-05-08 07:15:49 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 8223986188567902840a70580a3e0896a49603db | #6 | 2024-05-08 07:16:57 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | f311af84e8fe5f79c6de4d5eae6d067c08a2b89d | #7 | 2024-05-08 07:42:17 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | f311af84e8fe5f79c6de4d5eae6d067c08a2b89d | #7 | 2024-05-08 07:43:56 | ~5 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | f311af84e8fe5f79c6de4d5eae6d067c08a2b89d | #7 | 2024-05-08 07:44:51 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | f311af84e8fe5f79c6de4d5eae6d067c08a2b89d | #7 | 2024-05-08 07:48:23 | ~10 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | d84afea1404d5df6db7fed43b179e6c281fed142 | #8 | 2024-05-09 08:32:26 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | d84afea1404d5df6db7fed43b179e6c281fed142 | #8 | 2024-05-09 08:33:22 | ~5 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | d84afea1404d5df6db7fed43b179e6c281fed142 | #8 | 2024-05-09 08:33:25 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | d84afea1404d5df6db7fed43b179e6c281fed142 | #8 | 2024-05-09 08:35:47 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | 1c1516cd5aa4a3dd9f57605d9cdc1308b8e4e580 | #9 | 2024-05-10 06:23:46 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 1c1516cd5aa4a3dd9f57605d9cdc1308b8e4e580 | #9 | 2024-05-10 06:27:07 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 1c1516cd5aa4a3dd9f57605d9cdc1308b8e4e580 | #9 | 2024-05-10 06:27:57 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 1c1516cd5aa4a3dd9f57605d9cdc1308b8e4e580 | #9 | 2024-05-10 06:29:37 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | b7c7b5004f6df005c05b8487203e3979ac84de97 | #10 | 2024-05-13 16:53:00 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | b7c7b5004f6df005c05b8487203e3979ac84de97 | #10 | 2024-05-13 16:55:56 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | b7c7b5004f6df005c05b8487203e3979ac84de97 | #10 | 2024-05-13 16:56:11 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | b7c7b5004f6df005c05b8487203e3979ac84de97 | #10 | 2024-05-13 16:58:45 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | c0cb3562db8184068380e4717bec68bf1ec9c1a3 | #11 | 2024-05-14 07:23:58 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | c0cb3562db8184068380e4717bec68bf1ec9c1a3 | #11 | 2024-05-14 07:27:08 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | c0cb3562db8184068380e4717bec68bf1ec9c1a3 | #11 | 2024-05-14 07:28:06 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | c0cb3562db8184068380e4717bec68bf1ec9c1a3 | #11 | 2024-05-14 07:29:51 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | 5069fab4cab878b37f4309fb8dce4f426da4ef69 | #12 | 2024-05-14 16:06:03 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 5069fab4cab878b37f4309fb8dce4f426da4ef69 | #12 | 2024-05-14 16:08:41 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 5069fab4cab878b37f4309fb8dce4f426da4ef69 | #12 | 2024-05-14 16:10:01 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 5069fab4cab878b37f4309fb8dce4f426da4ef69 | #12 | 2024-05-14 16:12:57 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | 7a3b5d41f60ca2e583269b45aa3dec29f5827e2f | #14 | 2024-05-15 16:06:39 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 7a3b5d41f60ca2e583269b45aa3dec29f5827e2f | #14 | 2024-05-15 16:10:55 | ~7 min | android-e2e |
:robot:apk :calling: |
| :x: | 0957655d3968a4dddc16895cacdb4b75a70824cf | #15 | 2024-05-15 16:15:37 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 0957655d3968a4dddc16895cacdb4b75a70824cf | #15 | 2024-05-15 16:19:42 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 0957655d3968a4dddc16895cacdb4b75a70824cf | #15 | 2024-05-15 16:19:45 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 0957655d3968a4dddc16895cacdb4b75a70824cf | #15 | 2024-05-15 16:21:09 | ~8 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 30557daf4f7d1fb309cbea4a5f0df6484307319b | #17 | 2024-05-17 06:14:48 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 30557daf4f7d1fb309cbea4a5f0df6484307319b | #17 | 2024-05-17 06:19:11 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 30557daf4f7d1fb309cbea4a5f0df6484307319b | #17 | 2024-05-17 06:21:08 | ~10 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 30557daf4f7d1fb309cbea4a5f0df6484307319b | #17 | 2024-05-17 06:21:14 | ~10 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 4e0c883b2eca88b063ae6ee055383b549a428653 | #18 | 2024-05-17 06:38:43 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 4e0c883b2eca88b063ae6ee055383b549a428653 | #18 | 2024-05-17 06:39:40 | ~5 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 4e0c883b2eca88b063ae6ee055383b549a428653 | #18 | 2024-05-17 06:39:44 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 4e0c883b2eca88b063ae6ee055383b549a428653 | #18 | 2024-05-17 06:43:49 | ~9 min | ios |
:iphone:ipa :calling: |
69% of end-end tests have passed
Total executed tests: 52
Failed tests: 14
Expected to fail tests: 2
Passed tests: 36
IDs of failed tests: 727230,702784,703194,704613,703086,702948,702894,702783,704615,727229,703496,702786,702807,702775
IDs of expected to fail tests: 703495,703503
Failed tests (14)
Click to expand
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_hashtag_links_to_community_channels, id: 702948 |
Device 1: Device 2: |
| 2. test_community_mentions_push_notification, id: 702786 |
Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
|
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
|
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
Device 1: Device 2: |
| 2. test_community_mark_all_messages_as_read, id: 703086 |
Device 1: Device 2: |
| 3. test_community_contact_block_unblock_offline, id: 702894 |
Device 1: Device 2: |
| 4. test_community_edit_delete_message_when_offline, id: 704615 |
Device 1: Device 2: |
Expected to fail tests (2)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Passed tests (36)
Click to expand
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 3. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 2. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 3. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 4. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 5. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 6. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 7. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
@OmarBasem thanks for the PR. Please, take a look at the issues.
ISSUE 1 Only part of transactions are fetched in Activity tab
I have checked my old account that has a long history of activity on Mainnet.
Expected result:
According to Etherscan 37 transactions have been performed on Mainnet https://etherscan.io/txs?a=0x527d22094166ad33e7523d2cbca287798e149c7f
Actual result: only 18 transactions have been fetched in Activity tab in Status Mobile app. At the same time, all 37 transactions are fetched on latest Desktop master app.
Status-debug-logs - 2024-05-09T173052.604.zip
https://github.com/status-im/status-mobile/assets/97245802/937834b8-121c-4be4-b5e4-bef803a73323
ISSUE 2 Some of transactions have wrong sorting by date
Expected result: transactions should be sorted by date in desc order (from latest to oldest)
Actual result: on screenshot below you can see Oct 25, 2023 transaction appearing between Oct 6, 2022 and Sep 27, 2022 transactions.
@OmarBasem thanks for the PR. Please, take a look at the issues.
ISSUE 1 Only part of transactions are fetched in Activity tab
I have checked my old account that has a long history of activity on Mainnet.
Expected result:
According to Etherscan 37 transactions have been performed on Mainnet https://etherscan.io/txs?a=0x527d22094166ad33e7523d2cbca287798e149c7f
Actual result: only 18 transactions have been fetched in Activity tab in Status Mobile app. At the same time, all 37 transactions are fetched on latest Desktop master app.
Status-debug-logs - 2024-05-09T173052.604.zip
telegram-cloud-document-2-5326063766947777498.mp4
yeah I think we need to align with Desktop team on this. Pretty sure @smohamedjavid & I discussed this with @stefandunca and we will need to adjust a bit to get the rest of the activities that we are not seeing here. In any case, I think the steps this pr takes is good for now and those missing activities can be considered beyond the scope of this pr and we can work with @smohamedjavid next week when he returns to gather all of the missing transaction data.
It's also clear we're missing some address details, i.e right now it just shows the address but it can be an account name or a saved address or a multichain address so we need to eventually handle those cases as well.
yeah I think we need to align with Desktop team on this. Pretty sure @smohamedjavid & I discussed this with @stefandunca and we will need to adjust a bit to get the rest of the activities that we are not seeing here. In any case, I think the steps this pr takes is good for now and those missing activities can be considered beyond the scope of this pr and we can work with @smohamedjavid next week when he returns to gather all of the missing transaction data.
It's also clear we're missing some address details, i.e right now it just shows the address but it can be an account name or a saved address or a multichain address so we need to eventually handle those cases as well.
@J-Son89 thanks! Are we tracking the issue with missing activities? Should it be the part of https://github.com/status-im/status-mobile/issues/19849 epic?
Regarding this PR: according to @OmarBasem The other two issues in this epic will be out of scope from the July release. So this PR is the last one in epic https://github.com/status-im/status-mobile/issues/19849. That's why I assumed I need to test the entire Activity tab feature, as after merging this PR we are closing the epic. Am I right?
yeah I think we need to align with Desktop team on this. Pretty sure @smohamedjavid & I discussed this with @stefandunca and we will need to adjust a bit to get the rest of the activities that we are not seeing here. In any case, I think the steps this pr takes is good for now and those missing activities can be considered beyond the scope of this pr and we can work with @smohamedjavid next week when he returns to gather all of the missing transaction data. It's also clear we're missing some address details, i.e right now it just shows the address but it can be an account name or a saved address or a multichain address so we need to eventually handle those cases as well.
@J-Son89 thanks! Are we tracking the issue with missing activities? Should it be the part of #19849 epic?
Regarding this PR: according to @OmarBasem
The other two issues in this epic will be out of scope from the July release.So this PR is the last one in epic #19849. That's why I assumed I need to test the entire Activity tab feature, as after merging this PR we are closing the epic. Am I right?
good point @pavloburykh - apologies that's my fault. 🙏 I somewhat forgot about these missing transactions until you reminded me here! However I do recall these details were discussed now.
Let's add this issue you found as part of the same epic and we can close it then. @OmarBasem is correct in that the other two issues are out of scope, I will adjust the epic to reflect that and pull them out to some separate work in the future. Apologies again, I should have organised that epic in advance too, it's slightly confusing the way I organised it at this point. 👍
good point @pavloburykh - apologies that's my fault. 🙏
@J-Son89 no worries at all, not your fault. I have logged the issue https://github.com/status-im/status-mobile/issues/19956 and added it to https://github.com/status-im/status-mobile/issues/19852 epic.
Meanwhile, @OmarBasem could you please take a look at ISSUE 2. It might be PR related. Thank you!
Meanwhile, @OmarBasem could you please take a look at ISSUE 2. It might be PR related. Thank you!
Hi @pavloburykh, thanks for your testing!
Issue is fixed now!
85% of end-end tests have passed
Total executed tests: 52
Failed tests: 7
Expected to fail tests: 1
Passed tests: 44
IDs of failed tests: 727230,704613,727229,703391,702807,702775,703629
IDs of expected to fail tests: 703503
Failed tests (7)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_join_when_node_owner_offline, id: 703629 |
Device 1: Device 2: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_send_image_save_and_share, id: 703391 |
Device 1: Device 2: |
Expected to fail tests (1)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (44)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_mute_chat, id: 703495 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 5. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
| Device sessions Device 1: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Meanwhile, @OmarBasem could you please take a look at ISSUE 2. It might be PR related. Thank you!
Hi @pavloburykh, thanks for your testing!
Issue is fixed now!
Thank you @OmarBasem! I will continue testing once we update go version in order to get the fix of updating balances on testnet. Currently balances are not updating in develop so I cannot test new transactions to make sure they appear in Activity tab.
Hey @OmarBasem! Could you please rebase the branch? There are conflicts so I am unable to do it myself. Thank you.
Hey @OmarBasem! Could you please rebase the branch? There are conflicts so I am unable to do it myself. Thank you.
@pavloburykh Done!
@pavloburykh Done!
Thanks @OmarBasem! Could you please take a look at failed integration tests https://ci.status.im/job/status-mobile/job/prs/job/tests/job/PR-19906/9/consoleText ?
Hey @OmarBasem!
I am wondering if Activity items are ready for testing from design perspective? I see some differences compared to the designs. For example:
ISSUE 3 Activity item misses circle
ISSUE 4 Transaction status icon differs from the designs
Actual result:
Expected result:
@OmarBasem btw, integration tests are still failing.
ISSUE 5 Some transactions are doubled/trippled in Activity tab
Steps:
- Perform transaction
- Check transaction in Activity tab (pay attention if it is not doubled/tripled)
Actual result: transaction is tripled
Expected result: there is only one outgoing transaction at this time
https://arbiscan.io/address/0x527d22094166ad33e7523d2cbca287798e149c7f
ISSUE 6 Wrong chain is displayed for transaction in Activity tab
Steps:
- Perform transaction using Arbitrum network
- See which network is displayed in Activity tab
Actual result: Mainnet is displayed instead of Arbitrum
Expected result: this is Arbotrum transaction, so Arbitrum icon should be shown
https://arbiscan.io/tx/0xe8b75a8a23ab1237792cd29aaaed598a47d271b5057afd4f91247b03e0fb3d9e
ISSUE 7 Type 'Send' is shown fro recipient account when transferring funds between own accounts
Steps:
- Transfer funds between own accounts i.e. from Account A to Account B
- Check incoming transaction in Account B
- Pay attention at the type of transaction
Actual result: the type of transaction os 'Send' though it should be 'Received'
https://github.com/status-im/status-mobile/assets/97245802/605a0789-fc3d-4e28-94f8-e697969cd1e4
Expected result: For Account 2 transaction is incoming, so it should be 'Received' instead of 'Send' Account 1 - outgoing transaction https://arbiscan.io/address/0x49bb53433278b8ff318a04ec2c30cf2e9655f940 Account 2 - incoming transaction https://arbiscan.io/tx/0xe8b75a8a23ab1237792cd29aaaed598a47d271b5057afd4f91247b03e0fb3d9e
ISSUE 8 Transaction shows Pending status in Activity tab despite it is completed
Steps:
- Perform transaction
- Wait until Success status in blockchain
- Check transaction status in Activity tab
Actual result: transaction is in Pending
Expected result: transaction should be Completed
https://arbiscan.io/tx/0xe8b75a8a23ab1237792cd29aaaed598a47d271b5057afd4f91247b03e0fb3d9e
Thanks for your testing @pavloburykh !
Issue 3 is out of scope. There is an open issue for it: https://github.com/status-im/status-mobile/issues/19853
@OmarBasem btw, integration tests are still failing.
That's linting 👍
I will take a look at the other issues
@OmarBasem for some reason go version is still outdated in your PR despite you have rebased it. I see version v0.179.13 in this PR, but it should be v0.179.16 as in develop.
Could you please rebase once again so go version be up to date? Thanks.
Hey @pavloburykh,
I have reviewed and fixed the issues.
Issue 4: that icon means finalized. You can check the designs here
Issue 5: Please check if it is fixed now
Issue 6: I am displaying the chain as it comes from the backed. It is probably a status-go issue. Please note that the current method we are using for fetching activities is deprecated and will be replaced soon https://github.com/status-im/status-mobile/issues/19864
Issue 7: Fixed!
Issue 8: For me it works as expected. Please note that currently we fetch/refresh the activities when a user presses on the account card.
83% of end-end tests have passed
Total executed tests: 52
Failed tests: 7
Expected to fail tests: 2
Passed tests: 43
IDs of failed tests: 704613,727231,727230,727229,702807,727232,702775
IDs of expected to fail tests: 703503,703495
Failed tests (7)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
Device 1: |
| 2. test_wallet_add_remove_watch_only_account, id: 727232 |
Device 1: |
Expected to fail tests (2)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Passed tests (43)
Click to expand
Class TestActivityMultipleDevicePR:
| 1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
| 2. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 3. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
| 4. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 5. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestCommunityOneDeviceMerged:
| 1. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 4. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 5. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 3. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 4. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 5. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 8. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 9. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 10. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
| 11. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
@OmarBasem thanks for the PR. Issues 2, 5, 7 seem to be fixed. It is hard to test functionality as balances are barely fetched, activities sometimes fetched, sometimes not. I do not want to block the PR anymore, so let's merge it. Will continue more thorough testing once https://github.com/status-im/status-mobile/issues/19864 and https://github.com/status-im/status-mobile/issues/20011 are fixed.