status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Refactor add address to watch component and make it generic and use it in add saved addresses screen behind a FF

Open ibrkhalil opened this issue 9 months ago • 4 comments

fixes #19796, #19765, #19766, #19764

Summary

This PR refactors the add address to watch component and makes it reusable, It abstracts the definition of the title, subtitle and the event that's going to be executed after the user proceeds after typing/scanning an ETH address or ENS name.

Review notes

The previous add address to watch should be tested to make sure no regressions happened and the addition of saved addresses will be under a feature flag as it's still WIP (The addition is added but the rendering of the accounts isn't here so you can add addresses but they won't show up lolz).

Add address to watch flow: CleanShot 2024-05-13 at 10 56 04

Add saved address flow: CleanShot 2024-05-13 at 10 52 31

Testing notes

Please only test that adding addresses to watch isn't broken.

Platforms

  • Android
  • iOS

Areas that maybe impacted

Adding addresses to watch

Functional
  • wallet / transactions

Steps to test

  • Open Status
  • Try adding address to watch by scanning or by entering an ETH or ENS address.

Before and after screenshots comparison

Not required

status: ready

ibrkhalil avatar Apr 25 '24 11:04 ibrkhalil

Jenkins Builds

Click to see older builds (140)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:x: c75bd3ea418803e9902579bfaa478cf775c20391 #1 2024-04-25 11:38:53 ~2 min tests :page_facing_up:log
:heavy_check_mark: c75bd3ea418803e9902579bfaa478cf775c20391 #1 2024-04-25 11:42:21 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: c75bd3ea418803e9902579bfaa478cf775c20391 #1 2024-04-25 11:42:39 ~6 min android :robot:apk :calling:
:heavy_check_mark: c75bd3ea418803e9902579bfaa478cf775c20391 #1 2024-04-25 11:44:55 ~8 min ios :iphone:ipa :calling:
:x: 82a69ea5bff501fb512258d8ec571a3587f36ae7 #2 2024-04-25 11:54:21 ~2 min tests :page_facing_up:log
:heavy_check_mark: 82a69ea5bff501fb512258d8ec571a3587f36ae7 #3 2024-04-25 11:58:57 ~7 min android :robot:apk :calling:
:heavy_check_mark: 82a69ea5bff501fb512258d8ec571a3587f36ae7 #3 2024-04-25 11:58:59 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 82a69ea5bff501fb512258d8ec571a3587f36ae7 #3 2024-04-25 12:02:26 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: 458c7e1adeefbe83dac89ccb28499070a543af71 #4 2024-04-25 15:29:57 ~4 min tests :page_facing_up:log
:heavy_check_mark: 458c7e1adeefbe83dac89ccb28499070a543af71 #5 2024-04-25 15:34:11 ~8 min android :robot:apk :calling:
:heavy_check_mark: 458c7e1adeefbe83dac89ccb28499070a543af71 #5 2024-04-25 15:34:27 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 458c7e1adeefbe83dac89ccb28499070a543af71 #5 2024-04-25 15:35:58 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: 1cc2f2f61bf4d47c98eca3c049e211947b55c9b8 #5 2024-04-25 15:44:27 ~3 min tests :page_facing_up:log
:heavy_check_mark: 1cc2f2f61bf4d47c98eca3c049e211947b55c9b8 #6 2024-04-25 15:46:38 ~6 min android :robot:apk :calling:
:heavy_check_mark: 1cc2f2f61bf4d47c98eca3c049e211947b55c9b8 #6 2024-04-25 15:49:05 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 1cc2f2f61bf4d47c98eca3c049e211947b55c9b8 #6 2024-04-25 15:53:48 ~13 min ios :iphone:ipa :calling:
:heavy_check_mark: 7dcb21fc166b46e7e680c9ba1c9e1aaa379f6832 #6 2024-04-25 19:59:53 ~4 min tests :page_facing_up:log
:heavy_check_mark: 7dcb21fc166b46e7e680c9ba1c9e1aaa379f6832 #7 2024-04-25 20:03:16 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 7dcb21fc166b46e7e680c9ba1c9e1aaa379f6832 #7 2024-04-25 20:03:17 ~8 min android :robot:apk :calling:
:heavy_check_mark: 7dcb21fc166b46e7e680c9ba1c9e1aaa379f6832 #7 2024-04-25 20:03:50 ~8 min ios :iphone:ipa :calling:
:x: 6941451299cac64d70be16ed23dc4cbd2030d3fa #7 2024-04-26 08:00:37 ~2 min tests :page_facing_up:log
:heavy_check_mark: 6941451299cac64d70be16ed23dc4cbd2030d3fa #8 2024-04-26 08:04:44 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 6941451299cac64d70be16ed23dc4cbd2030d3fa #8 2024-04-26 08:04:52 ~6 min android :robot:apk :calling:
:x: 9cd5f681f5c001db15ecebeaa69cff603a025763 #8 2024-04-26 08:09:03 ~2 min tests :page_facing_up:log
:heavy_check_mark: 9cd5f681f5c001db15ecebeaa69cff603a025763 #9 2024-04-26 08:14:31 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 9cd5f681f5c001db15ecebeaa69cff603a025763 #9 2024-04-26 08:14:34 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 9cd5f681f5c001db15ecebeaa69cff603a025763 #9 2024-04-26 08:14:40 ~8 min android :robot:apk :calling:
:x: f2f2b9781a86ba40052cc4b1bac5b02966269b59 #9 2024-04-26 08:21:13 ~2 min tests :page_facing_up:log
:x: 1abf3a5f7a98cb65ce1f6bfcf1024b63ad377f3d #10 2024-04-26 08:27:55 ~2 min tests :page_facing_up:log
:heavy_check_mark: 1abf3a5f7a98cb65ce1f6bfcf1024b63ad377f3d #11 2024-04-26 08:31:09 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: 1abf3a5f7a98cb65ce1f6bfcf1024b63ad377f3d #11 2024-04-26 08:31:15 ~5 min android :robot:apk :calling:
:heavy_check_mark: 1abf3a5f7a98cb65ce1f6bfcf1024b63ad377f3d #11 2024-04-26 08:34:13 ~8 min ios :iphone:ipa :calling:
:x: 4b46fe0788f98836c2ce9c6ea0b43e789e395ef2 #12 2024-04-26 09:25:02 ~2 min tests :page_facing_up:log
:heavy_check_mark: 4b46fe0788f98836c2ce9c6ea0b43e789e395ef2 #13 2024-04-26 09:28:29 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: 4b46fe0788f98836c2ce9c6ea0b43e789e395ef2 #13 2024-04-26 09:29:31 ~6 min android :robot:apk :calling:
:heavy_check_mark: 4b46fe0788f98836c2ce9c6ea0b43e789e395ef2 #13 2024-04-26 09:31:02 ~8 min ios :iphone:ipa :calling:
:x: 6edd0110c81bb1df5b08096f7b3c153bc607be97 #13 2024-04-26 10:05:50 ~2 min tests :page_facing_up:log
:x: b11806548e9b78740d90e87a270a0b13d80c3b8a #14 2024-04-26 10:12:23 ~2 min tests :page_facing_up:log
:heavy_check_mark: b11806548e9b78740d90e87a270a0b13d80c3b8a #15 2024-04-26 10:15:35 ~5 min android :robot:apk :calling:
:heavy_check_mark: b11806548e9b78740d90e87a270a0b13d80c3b8a #15 2024-04-26 10:16:28 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: b11806548e9b78740d90e87a270a0b13d80c3b8a #15 2024-04-26 10:18:02 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: f7ecbdcdf1e50b5e2e2299af74fa6ca2ed5296e8 #15 2024-04-26 10:37:37 ~4 min tests :page_facing_up:log
:heavy_check_mark: f7ecbdcdf1e50b5e2e2299af74fa6ca2ed5296e8 #16 2024-04-26 10:39:19 ~5 min android :robot:apk :calling:
:heavy_check_mark: f7ecbdcdf1e50b5e2e2299af74fa6ca2ed5296e8 #16 2024-04-26 10:40:17 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: f7ecbdcdf1e50b5e2e2299af74fa6ca2ed5296e8 #16 2024-04-26 10:41:56 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 3b68e21ca1b9beebad53206e24f09fcde4508844 #16 2024-04-26 15:03:33 ~4 min tests :page_facing_up:log
:x: 75cde660b8418ee3cd8d9cfd1b38337bf38d566c #18 2024-04-26 15:08:26 ~2 min tests :page_facing_up:log
:heavy_check_mark: 75cde660b8418ee3cd8d9cfd1b38337bf38d566c #19 2024-04-26 15:11:36 ~5 min android :robot:apk :calling:
:heavy_check_mark: 75cde660b8418ee3cd8d9cfd1b38337bf38d566c #19 2024-04-26 15:12:40 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: d00dae0831c77627b147e08e9ab53528c3b991e7 #19 2024-04-26 15:18:00 ~4 min tests :page_facing_up:log
:heavy_check_mark: d00dae0831c77627b147e08e9ab53528c3b991e7 #20 2024-04-26 15:21:44 ~8 min android :robot:apk :calling:
:heavy_check_mark: d00dae0831c77627b147e08e9ab53528c3b991e7 #20 2024-04-26 15:21:45 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: d00dae0831c77627b147e08e9ab53528c3b991e7 #20 2024-04-26 15:21:47 ~8 min ios :iphone:ipa :calling:
:x: 5e23cf91f9552ec568d14aefa7f77cc144831288 #20 2024-05-03 12:12:11 ~2 min tests :page_facing_up:log
:heavy_check_mark: 5e23cf91f9552ec568d14aefa7f77cc144831288 #21 2024-05-03 12:17:22 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5e23cf91f9552ec568d14aefa7f77cc144831288 #21 2024-05-03 12:17:23 ~7 min android :robot:apk :calling:
:heavy_check_mark: 5e23cf91f9552ec568d14aefa7f77cc144831288 #21 2024-05-03 12:17:47 ~8 min ios :iphone:ipa :calling:
:x: 5bde74857720faf8fb795d30056ed62b084bd925 #22 2024-05-03 15:12:35 ~2 min tests :page_facing_up:log
:heavy_check_mark: 5bde74857720faf8fb795d30056ed62b084bd925 #23 2024-05-03 15:16:41 ~6 min android :robot:apk :calling:
:heavy_check_mark: 5bde74857720faf8fb795d30056ed62b084bd925 #23 2024-05-03 15:16:46 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5bde74857720faf8fb795d30056ed62b084bd925 #23 2024-05-03 15:19:32 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: d55e54c18fb913495c31a03201a475fbe11cf7c6 #23 2024-05-03 15:56:37 ~3 min tests :page_facing_up:log
:heavy_check_mark: d55e54c18fb913495c31a03201a475fbe11cf7c6 #24 2024-05-03 15:58:23 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: d55e54c18fb913495c31a03201a475fbe11cf7c6 #24 2024-05-03 15:58:27 ~5 min android :robot:apk :calling:
:heavy_check_mark: d55e54c18fb913495c31a03201a475fbe11cf7c6 #24 2024-05-03 16:01:03 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 5b4d8d1dc7151c279d1748258b6d49d9fedc6e6a #25 2024-05-04 10:00:47 ~4 min tests :page_facing_up:log
:heavy_check_mark: 5b4d8d1dc7151c279d1748258b6d49d9fedc6e6a #26 2024-05-04 10:03:29 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 5b4d8d1dc7151c279d1748258b6d49d9fedc6e6a #26 2024-05-04 10:03:33 ~6 min android :robot:apk :calling:
:heavy_check_mark: 5b4d8d1dc7151c279d1748258b6d49d9fedc6e6a #26 2024-05-04 10:05:57 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: 821570a691c5bb914de74edbcab4468fc7fd45dc #26 2024-05-04 10:45:52 ~4 min tests :page_facing_up:log
:heavy_check_mark: 821570a691c5bb914de74edbcab4468fc7fd45dc #27 2024-05-04 10:49:37 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 821570a691c5bb914de74edbcab4468fc7fd45dc #27 2024-05-04 10:49:40 ~8 min android :robot:apk :calling:
:heavy_check_mark: 821570a691c5bb914de74edbcab4468fc7fd45dc #27 2024-05-04 10:49:47 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 3f5208e4e7147a83eb33485e768bf7bffed1fada #27 2024-05-04 11:15:42 ~3 min tests :page_facing_up:log
:heavy_check_mark: 3f5208e4e7147a83eb33485e768bf7bffed1fada #28 2024-05-04 11:18:38 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 3f5208e4e7147a83eb33485e768bf7bffed1fada #28 2024-05-04 11:18:41 ~6 min android :robot:apk :calling:
:heavy_check_mark: 3f5208e4e7147a83eb33485e768bf7bffed1fada #28 2024-05-04 11:19:57 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 9de279c36e7b9fdeb022a16dbfa2863d48d675a0 #28 2024-05-04 11:28:11 ~4 min tests :page_facing_up:log
:heavy_check_mark: 9de279c36e7b9fdeb022a16dbfa2863d48d675a0 #29 2024-05-04 11:31:50 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 9de279c36e7b9fdeb022a16dbfa2863d48d675a0 #29 2024-05-04 11:32:00 ~8 min android :robot:apk :calling:
:heavy_check_mark: 9de279c36e7b9fdeb022a16dbfa2863d48d675a0 #29 2024-05-04 11:32:10 ~8 min ios :iphone:ipa :calling:
:x: e31d86d80c8121c485c1c652e86c50af8ac7737e #29 2024-05-04 11:49:51 ~2 min tests :page_facing_up:log
:heavy_check_mark: e31d86d80c8121c485c1c652e86c50af8ac7737e #30 2024-05-04 11:54:53 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: e31d86d80c8121c485c1c652e86c50af8ac7737e #30 2024-05-04 11:54:58 ~7 min android :robot:apk :calling:
:heavy_check_mark: e31d86d80c8121c485c1c652e86c50af8ac7737e #30 2024-05-04 11:55:22 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 4b595dffa9b12fd73e4549efb57d2d50bec83c56 #30 2024-05-05 12:42:45 ~3 min tests :page_facing_up:log
:heavy_check_mark: 4b595dffa9b12fd73e4549efb57d2d50bec83c56 #31 2024-05-05 12:46:34 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 4b595dffa9b12fd73e4549efb57d2d50bec83c56 #31 2024-05-05 12:46:40 ~7 min android :robot:apk :calling:
:heavy_check_mark: 4b595dffa9b12fd73e4549efb57d2d50bec83c56 #31 2024-05-05 12:47:47 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: a2766eb72bf7c65975bc445b00e731bd4bba03a9 #33 2024-05-06 13:38:08 ~3 min tests :page_facing_up:log
:heavy_check_mark: a2766eb72bf7c65975bc445b00e731bd4bba03a9 #34 2024-05-06 13:42:01 ~7 min android :robot:apk :calling:
:heavy_check_mark: a2766eb72bf7c65975bc445b00e731bd4bba03a9 #34 2024-05-06 13:43:43 ~9 min ios :iphone:ipa :calling:
:x: cf0ae137981a16df573d62195906c0146dfdf23b #34 2024-05-06 16:30:32 ~1 min tests :page_facing_up:log
:heavy_check_mark: cf0ae137981a16df573d62195906c0146dfdf23b #35 2024-05-06 16:34:37 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: cf0ae137981a16df573d62195906c0146dfdf23b #35 2024-05-06 16:35:01 ~6 min android :robot:apk :calling:
:heavy_check_mark: cf0ae137981a16df573d62195906c0146dfdf23b #35 2024-05-06 16:37:22 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 0007c3590f5875cbb47f87a0627bf6aec55229e5 #36 2024-05-07 08:51:18 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: 0007c3590f5875cbb47f87a0627bf6aec55229e5 #36 2024-05-07 10:11:32 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: 0007c3590f5875cbb47f87a0627bf6aec55229e5 #36 2024-05-07 10:48:25 ~5 min android :robot:apk :calling:
:heavy_check_mark: 0007c3590f5875cbb47f87a0627bf6aec55229e5 #35 2024-05-07 11:05:23 ~3 min tests :page_facing_up:log
:heavy_check_mark: 6837c2cf34059738017d8b4a85225a27059e8339 #36 2024-05-07 12:34:47 ~4 min tests :page_facing_up:log
:heavy_check_mark: 6837c2cf34059738017d8b4a85225a27059e8339 #37 2024-05-07 12:36:31 ~5 min android :robot:apk :calling:
:heavy_check_mark: 6837c2cf34059738017d8b4a85225a27059e8339 #37 2024-05-07 12:37:35 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: 6837c2cf34059738017d8b4a85225a27059e8339 #37 2024-05-07 12:41:01 ~10 min ios :iphone:ipa :calling:
:heavy_check_mark: c9528d88444f6305bab5a147c7cbf43073b0b5b4 #37 2024-05-08 04:15:14 ~4 min tests :page_facing_up:log
:heavy_check_mark: c9528d88444f6305bab5a147c7cbf43073b0b5b4 #38 2024-05-08 04:19:22 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: c9528d88444f6305bab5a147c7cbf43073b0b5b4 #38 2024-05-08 04:21:53 ~10 min android-e2e :robot:apk :calling:
:heavy_check_mark: c9528d88444f6305bab5a147c7cbf43073b0b5b4 #38 2024-05-08 04:22:05 ~10 min android :robot:apk :calling:
:heavy_check_mark: fe766d8aa63d6a2638ee53322103fee31ce0ffa8 #38 2024-05-08 09:18:16 ~3 min tests :page_facing_up:log
:heavy_check_mark: fe766d8aa63d6a2638ee53322103fee31ce0ffa8 #39 2024-05-08 09:21:14 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: fe766d8aa63d6a2638ee53322103fee31ce0ffa8 #39 2024-05-08 09:21:15 ~7 min android :robot:apk :calling:
:heavy_check_mark: fe766d8aa63d6a2638ee53322103fee31ce0ffa8 #39 2024-05-08 09:23:23 ~9 min ios :iphone:ipa :calling:
:heavy_check_mark: af2cab1897c0d38a4c47dcfb2dbf11746c936a97 #39 2024-05-10 18:07:44 ~7 min tests :page_facing_up:log
:heavy_check_mark: af2cab1897c0d38a4c47dcfb2dbf11746c936a97 #40 2024-05-10 18:08:34 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: af2cab1897c0d38a4c47dcfb2dbf11746c936a97 #40 2024-05-10 18:08:38 ~8 min android :robot:apk :calling:
:heavy_check_mark: af2cab1897c0d38a4c47dcfb2dbf11746c936a97 #40 2024-05-10 18:09:14 ~8 min ios :iphone:ipa :calling:
:x: 4e2f6d55615ecee3c102998cc0c93667fd70cd12 #41 2024-05-10 18:28:55 ~27 sec ios :page_facing_up:log
:x: 4e2f6d55615ecee3c102998cc0c93667fd70cd12 #41 2024-05-10 18:29:01 ~32 sec android-e2e :page_facing_up:log
:x: 4e2f6d55615ecee3c102998cc0c93667fd70cd12 #41 2024-05-10 18:29:01 ~32 sec android :page_facing_up:log
:x: 4e2f6d55615ecee3c102998cc0c93667fd70cd12 #40 2024-05-10 18:30:09 ~1 min tests :page_facing_up:log
:x: b97a40dd50e30ed40697565d9582263e1a961a1c #42 2024-05-11 03:47:25 ~25 sec ios :page_facing_up:log
:x: b97a40dd50e30ed40697565d9582263e1a961a1c #42 2024-05-11 03:47:31 ~37 sec android-e2e :page_facing_up:log
:x: b97a40dd50e30ed40697565d9582263e1a961a1c #42 2024-05-11 03:47:38 ~39 sec android :page_facing_up:log
:x: b97a40dd50e30ed40697565d9582263e1a961a1c #41 2024-05-11 03:48:35 ~1 min tests :page_facing_up:log
:heavy_check_mark: 8f158292724dc60a793937fbb92d74560c545eb0 #42 2024-05-11 03:52:51 ~3 min tests :page_facing_up:log
:heavy_check_mark: 8f158292724dc60a793937fbb92d74560c545eb0 #43 2024-05-11 03:57:49 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 8f158292724dc60a793937fbb92d74560c545eb0 #43 2024-05-11 03:58:44 ~9 min android-e2e :robot:apk :calling:
:heavy_check_mark: 8f158292724dc60a793937fbb92d74560c545eb0 #43 2024-05-11 03:58:44 ~9 min android :robot:apk :calling:
:heavy_check_mark: 911cdfecb568ebd3c0a2c815a51e9fff95ed390a #43 2024-05-11 04:18:24 ~4 min tests :page_facing_up:log
:heavy_check_mark: 911cdfecb568ebd3c0a2c815a51e9fff95ed390a #44 2024-05-11 04:22:36 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 911cdfecb568ebd3c0a2c815a51e9fff95ed390a #44 2024-05-11 04:24:30 ~10 min android-e2e :robot:apk :calling:
:heavy_check_mark: 911cdfecb568ebd3c0a2c815a51e9fff95ed390a #44 2024-05-11 04:24:42 ~10 min android :robot:apk :calling:
:heavy_check_mark: 258b1ec1929df53cb83beb9181184a9791813394 #45 2024-05-12 06:43:28 ~5 min tests :page_facing_up:log
:heavy_check_mark: 258b1ec1929df53cb83beb9181184a9791813394 #46 2024-05-12 06:43:59 ~5 min android-e2e :robot:apk :calling:
:heavy_check_mark: 258b1ec1929df53cb83beb9181184a9791813394 #46 2024-05-12 06:45:13 ~6 min android :robot:apk :calling:
:heavy_check_mark: 258b1ec1929df53cb83beb9181184a9791813394 #46 2024-05-12 06:47:25 ~9 min ios :iphone:ipa :calling:
:x: c8805b5bf8b71e48516cfd17995165e99335f0ef #46 2024-05-12 10:08:55 ~2 min tests :page_facing_up:log
:heavy_check_mark: c8805b5bf8b71e48516cfd17995165e99335f0ef #47 2024-05-12 10:14:01 ~7 min android-e2e :robot:apk :calling:
:heavy_check_mark: c8805b5bf8b71e48516cfd17995165e99335f0ef #47 2024-05-12 10:14:05 ~7 min android :robot:apk :calling:
:heavy_check_mark: c8805b5bf8b71e48516cfd17995165e99335f0ef #47 2024-05-12 10:14:44 ~8 min ios :iphone:ipa :calling:
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 6e0b8ae2f3ed0cc43ba49a32bc2cec7ebf53e2c8 #47 2024-05-12 10:31:54 ~5 min tests :page_facing_up:log
:heavy_check_mark: 6e0b8ae2f3ed0cc43ba49a32bc2cec7ebf53e2c8 #48 2024-05-12 10:34:04 ~8 min android-e2e :robot:apk :calling:
:heavy_check_mark: 6e0b8ae2f3ed0cc43ba49a32bc2cec7ebf53e2c8 #48 2024-05-12 10:34:14 ~8 min android :robot:apk :calling:
:heavy_check_mark: 6e0b8ae2f3ed0cc43ba49a32bc2cec7ebf53e2c8 #48 2024-05-12 10:34:43 ~8 min ios :iphone:ipa :calling:
:heavy_check_mark: 26b26f85bd0eb28d55e8aae89e21e236030f697c #48 2024-05-13 06:41:37 ~4 min tests :page_facing_up:log
:heavy_check_mark: 26b26f85bd0eb28d55e8aae89e21e236030f697c #49 2024-05-13 06:42:56 ~5 min android :robot:apk :calling:
:heavy_check_mark: 26b26f85bd0eb28d55e8aae89e21e236030f697c #49 2024-05-13 06:43:47 ~6 min android-e2e :robot:apk :calling:
:heavy_check_mark: 26b26f85bd0eb28d55e8aae89e21e236030f697c #49 2024-05-13 06:45:43 ~8 min ios :iphone:ipa :calling:

status-im-auto avatar Apr 25 '24 11:04 status-im-auto

Drafting till improvements are done.

ibrkhalil avatar Apr 26 '24 15:04 ibrkhalil

@ibrkhalil - since this pr is in draft now I'd suggest removing the request-manual-qa label. Imo we should only add this once the pr is truly ready for the pr process, i.e it has sufficient dev approvals etc 👍

J-Son89 avatar Apr 29 '24 16:04 J-Son89

https://discord.com/channels/1210237582470807632/1217175613702410310/1237047050332278904

Drafting this PR until the decisions/ideas here are pushed.

ibrkhalil avatar May 06 '24 14:05 ibrkhalil

Taking over this PR. Marking this PR as a Draft until the reviews are addressed.

smohamedjavid avatar May 23 '24 09:05 smohamedjavid