status-mobile
status-mobile copied to clipboard
[#18817] Import private key: UI for key pair name #18817
Fixes #18817
Summary
UI for adding key pair name, re-frame subs and events
Testing notes
Example of private key - 0xcaed41dd92c1548cf7536c290e6a1871757fb5fea5721dea3a08c6d4abcd16cf,
result of account activity (no activity/has activity) is random now.
Public address of private key is hardcoded now.
!!! Important
It reuses status-im.contexts.wallet.add-account.create-account.key-pair-name.view screen in this import private key workflow and in new key pair (check video)
Before and after screenshots comparison
!!! After updates
https://github.com/status-im/status-mobile/assets/10757633/002d627a-d505-4161-be95-f363601bb159
||
|
||
|
||
|
status: ready
Jenkins Builds
Click to see older builds (64)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 5508ca40a0877f9feb5d2df922c67c6adf50edc7 | #1 | 2024-04-20 21:04:28 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 5508ca40a0877f9feb5d2df922c67c6adf50edc7 | #1 | 2024-04-20 21:08:04 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 5508ca40a0877f9feb5d2df922c67c6adf50edc7 | #1 | 2024-04-20 21:08:08 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 5508ca40a0877f9feb5d2df922c67c6adf50edc7 | #1 | 2024-04-20 21:08:36 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 583b450dbcc97841aab3da2177a005aefdb13d31 | #2 | 2024-04-23 17:20:32 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 583b450dbcc97841aab3da2177a005aefdb13d31 | #2 | 2024-04-23 17:23:56 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 583b450dbcc97841aab3da2177a005aefdb13d31 | #2 | 2024-04-23 17:24:06 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 583b450dbcc97841aab3da2177a005aefdb13d31 | #2 | 2024-04-23 17:24:30 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | daa5b59848a6394d090185d28c77449abfd69e67 | #3 | 2024-04-24 16:35:39 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | daa5b59848a6394d090185d28c77449abfd69e67 | #3 | 2024-04-24 16:39:14 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | daa5b59848a6394d090185d28c77449abfd69e67 | #3 | 2024-04-24 16:39:15 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | daa5b59848a6394d090185d28c77449abfd69e67 | #3 | 2024-04-24 16:39:29 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 6e88be86f27137b730b442d161ca452ff41b2895 | #4 | 2024-04-25 11:53:27 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 6e88be86f27137b730b442d161ca452ff41b2895 | #4 | 2024-04-25 11:56:56 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 6e88be86f27137b730b442d161ca452ff41b2895 | #4 | 2024-04-25 11:57:00 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 6e88be86f27137b730b442d161ca452ff41b2895 | #4 | 2024-04-25 11:58:43 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | bf387c37ec2a875c8c661faea7747d0c706c9ddb | #6 | 2024-04-25 20:52:40 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | bf387c37ec2a875c8c661faea7747d0c706c9ddb | #6 | 2024-04-25 20:55:56 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | bf387c37ec2a875c8c661faea7747d0c706c9ddb | #6 | 2024-04-25 20:56:01 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | bf387c37ec2a875c8c661faea7747d0c706c9ddb | #6 | 2024-04-25 20:58:09 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | cfef1549906ccd996f7ce1d979884ee708e1f52b | #7 | 2024-04-30 11:25:45 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | cfef1549906ccd996f7ce1d979884ee708e1f52b | #7 | 2024-04-30 11:29:18 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | cfef1549906ccd996f7ce1d979884ee708e1f52b | #7 | 2024-04-30 11:29:23 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | cfef1549906ccd996f7ce1d979884ee708e1f52b | #7 | 2024-04-30 11:29:48 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 77a5fa0b52222241464494168de59bd376f0d37b | #8 | 2024-04-30 13:48:25 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 77a5fa0b52222241464494168de59bd376f0d37b | #8 | 2024-04-30 13:51:55 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 77a5fa0b52222241464494168de59bd376f0d37b | #8 | 2024-04-30 13:52:01 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 77a5fa0b52222241464494168de59bd376f0d37b | #8 | 2024-04-30 13:52:50 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | e7fa186cd63fb5b49b0de307609aa8250d6ae0c1 | #9 | 2024-05-01 15:36:35 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | e7fa186cd63fb5b49b0de307609aa8250d6ae0c1 | #9 | 2024-05-01 15:39:16 | ~6 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | e7fa186cd63fb5b49b0de307609aa8250d6ae0c1 | #9 | 2024-05-01 15:39:19 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | e7fa186cd63fb5b49b0de307609aa8250d6ae0c1 | #9 | 2024-05-01 15:42:30 | ~10 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 2d36fd18c415bdd63a1808229be2848872e96faa | #10 | 2024-05-01 20:00:21 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 2d36fd18c415bdd63a1808229be2848872e96faa | #10 | 2024-05-01 20:03:48 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 2d36fd18c415bdd63a1808229be2848872e96faa | #10 | 2024-05-01 20:03:55 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 2d36fd18c415bdd63a1808229be2848872e96faa | #10 | 2024-05-01 20:06:18 | ~10 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 538fffc22ff58e60c84be576c9285f850ced6bff | #11 | 2024-05-02 23:01:11 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 538fffc22ff58e60c84be576c9285f850ced6bff | #11 | 2024-05-02 23:04:46 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 538fffc22ff58e60c84be576c9285f850ced6bff | #11 | 2024-05-02 23:04:50 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 538fffc22ff58e60c84be576c9285f850ced6bff | #11 | 2024-05-02 23:05:15 | ~8 min | ios |
:iphone:ipa :calling: |
| :x: | 0d22806b9bff4efe502cf3ddc1bef7568b4514be | #13 | 2024-05-03 00:10:17 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 0d22806b9bff4efe502cf3ddc1bef7568b4514be | #13 | 2024-05-03 00:13:37 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 0d22806b9bff4efe502cf3ddc1bef7568b4514be | #13 | 2024-05-03 00:14:34 | ~6 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 0d22806b9bff4efe502cf3ddc1bef7568b4514be | #13 | 2024-05-03 00:16:17 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 5de289da8e1b3b613e8a5dcbcc7207cad06caa45 | #14 | 2024-05-07 08:51:14 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 5de289da8e1b3b613e8a5dcbcc7207cad06caa45 | #14 | 2024-05-07 10:11:13 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 5de289da8e1b3b613e8a5dcbcc7207cad06caa45 | #14 | 2024-05-07 10:48:16 | ~5 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 5de289da8e1b3b613e8a5dcbcc7207cad06caa45 | #14 | 2024-05-07 11:05:24 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 399a44ec1aaad1172ea9f154835b39a398d46849 | #15 | 2024-05-07 22:08:46 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 399a44ec1aaad1172ea9f154835b39a398d46849 | #15 | 2024-05-07 22:12:16 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 399a44ec1aaad1172ea9f154835b39a398d46849 | #15 | 2024-05-07 22:12:22 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 399a44ec1aaad1172ea9f154835b39a398d46849 | #15 | 2024-05-07 22:12:38 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 76e3ffa539bc536fcfcc9df09c7d3a69428d9ff6 | #16 | 2024-05-08 10:20:56 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 76e3ffa539bc536fcfcc9df09c7d3a69428d9ff6 | #16 | 2024-05-08 10:26:11 | ~9 min | ios |
:iphone:ipa :calling: |
| :x: | 76e3ffa539bc536fcfcc9df09c7d3a69428d9ff6 | #16 | 2024-05-08 10:27:21 | ~10 min | android |
:page_facing_up:log |
| :x: | 76e3ffa539bc536fcfcc9df09c7d3a69428d9ff6 | #16 | 2024-05-08 10:27:30 | ~10 min | android-e2e |
:page_facing_up:log |
| :heavy_check_mark: | 0d332e6c99236876f572880eb12bde9adcc101eb | #17 | 2024-05-08 10:39:59 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 0d332e6c99236876f572880eb12bde9adcc101eb | #17 | 2024-05-08 10:43:34 | ~9 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 0d332e6c99236876f572880eb12bde9adcc101eb | #17 | 2024-05-08 10:43:39 | ~9 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 0d332e6c99236876f572880eb12bde9adcc101eb | #17 | 2024-05-08 10:44:21 | ~9 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | a82a2b3423fbda4a171771c2c3dbfb99ada76b2f | #18 | 2024-05-08 13:04:14 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | a82a2b3423fbda4a171771c2c3dbfb99ada76b2f | #18 | 2024-05-08 13:07:43 | ~8 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | a82a2b3423fbda4a171771c2c3dbfb99ada76b2f | #18 | 2024-05-08 13:07:50 | ~8 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | a82a2b3423fbda4a171771c2c3dbfb99ada76b2f | #18 | 2024-05-08 13:10:34 | ~10 min | ios |
:iphone:ipa :calling: |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 067ae6f19251b68bdf3bc16c356e32e2f00dd1ee | #19 | 2024-05-08 18:38:51 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 067ae6f19251b68bdf3bc16c356e32e2f00dd1ee | #19 | 2024-05-08 18:40:14 | ~5 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 067ae6f19251b68bdf3bc16c356e32e2f00dd1ee | #19 | 2024-05-08 18:41:52 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 067ae6f19251b68bdf3bc16c356e32e2f00dd1ee | #19 | 2024-05-08 18:42:57 | ~8 min | ios |
:iphone:ipa :calling: |
| :heavy_check_mark: | 54f1b505e775d80301e9bd84c0b24b08c2d6791e | #20 | 2024-05-13 09:37:46 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 54f1b505e775d80301e9bd84c0b24b08c2d6791e | #20 | 2024-05-13 09:39:17 | ~7 min | android-e2e |
:robot:apk :calling: |
| :heavy_check_mark: | 54f1b505e775d80301e9bd84c0b24b08c2d6791e | #20 | 2024-05-13 09:39:25 | ~7 min | android |
:robot:apk :calling: |
| :heavy_check_mark: | 54f1b505e775d80301e9bd84c0b24b08c2d6791e | #20 | 2024-05-13 09:41:31 | ~9 min | ios |
:iphone:ipa :calling: |
Thanks @Rende11 for addressing the comments. There is currently a conflict in the keypair_name screen, please resolve that conflict and make sure to copy the new changes
@status-im/mobile-qa - this pr will skip manual QA as it is all behind a feature flag 👍
85% of end-end tests have passed
Total executed tests: 52
Failed tests: 6
Expected to fail tests: 2
Passed tests: 44
IDs of failed tests: 727230,704613,727229,702807,727232,702775
IDs of expected to fail tests: 703495,703503
Failed tests (6)
Click to expand
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_join_send_text_messages_push, id: 702807 |
Device 1: Device 2: Device 3: |
Class TestWalletMultipleDevice:
| 1. test_wallet_send_asset_from_drawer, id: 727230 |
|
| 2. test_wallet_send_eth, id: 727229 |
|
Class TestDeepLinksOneDevice:
| 1. test_links_open_universal_links_from_chat, id: 704613 |
Device 1: |
| 2. test_links_deep_links, id: 702775 |
Device 1: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_watch_only_account, id: 727232 |
Device 1: |
Expected to fail tests (2)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_community_discovery, id: 703503 |
[[reason: [NOTRUN] Curated communities not loading, https://github.com/status-im/status-mobile/issues/17852]] |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_mute_chat, id: 703495 |
[[Chat is not unmuted after expected time: https://github.com/status-im/status-mobile/issues/19627]] Device 1: Device 2: Device 3: |
Passed tests (44)
Click to expand
Class TestCommunityOneDeviceMerged:
| 1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133 |
| Device sessions Device 1: |
| 2. test_community_copy_and_paste_message_in_chat_input, id: 702742 |
| Device sessions Device 1: |
| 3. test_community_undo_delete_message, id: 702869 |
| Device sessions Device 1: |
| 4. test_community_navigate_to_channel_when_relaunch, id: 702846 |
| Device sessions Device 1: |
| 5. test_community_mute_community_and_channel, id: 703382 |
| Device sessions Device 1: |
Class TestActivityMultipleDevicePR:
| 1. test_navigation_jump_to, id: 702936 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMerged:
| 1. test_community_several_images_send_reply, id: 703194 |
| Device sessions Device 1: Device 2: |
| 2. test_community_one_image_send_reply, id: 702859 |
| Device sessions Device 1: Device 2: |
| 3. test_community_emoji_send_copy_paste_reply, id: 702840 |
| Device sessions Device 1: Device 2: |
| 4. test_community_mark_all_messages_as_read, id: 703086 |
| Device sessions Device 1: Device 2: |
| 5. test_community_contact_block_unblock_offline, id: 702894 |
| Device sessions Device 1: Device 2: |
| 6. test_community_edit_delete_message_when_offline, id: 704615 |
| Device sessions Device 1: Device 2: |
| 7. test_community_message_delete, id: 702839 |
| Device sessions Device 1: Device 2: |
| 8. test_community_message_send_check_timestamps_sender_username, id: 702838 |
| Device sessions Device 1: Device 2: |
| 9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844 |
| Device sessions Device 1: Device 2: |
| 10. test_community_message_edit, id: 702843 |
| Device sessions Device 1: Device 2: |
| 11. test_community_unread_messages_badge, id: 702841 |
| Device sessions Device 1: Device 2: |
Class TestWalletOneDevice:
| 1. test_wallet_add_remove_regular_account, id: 727231 |
| Device sessions Device 1: |
Class TestOneToOneChatMultipleSharedDevicesNewUi:
| 1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_text_message_delete_push_disappear, id: 702733 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_push_emoji, id: 702813 |
| Device sessions Device 1: Device 2: |
| 4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745 |
| Device sessions Device 1: Device 2: |
| 5. test_1_1_chat_edit_message, id: 702855 |
| Device sessions Device 1: Device 2: |
| 6. test_1_1_chat_send_image_save_and_share, id: 703391 |
| Device sessions Device 1: Device 2: |
| 7. test_1_1_chat_pin_messages, id: 702731 |
| Device sessions Device 1: Device 2: |
| 8. test_1_1_chat_message_reaction, id: 702730 |
| Device sessions Device 1: Device 2: |
Class TestActivityCenterContactRequestMultipleDevicePR:
| 1. test_add_contact_field_validation, id: 702777 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851 |
| Device sessions Device 1: Device 2: |
| 3. test_activity_center_contact_request_decline, id: 702850 |
| Device sessions Device 1: Device 2: |
Class TestGroupChatMultipleDeviceMergedNewUI:
| 1. test_group_chat_pin_messages, id: 702732 |
| Device sessions Device 1: Device 2: Device 3: |
| 2. test_group_chat_send_image_save_and_share, id: 703297 |
| Device sessions Device 1: Device 2: Device 3: |
| 3. test_group_chat_reactions, id: 703202 |
| Device sessions Device 1: Device 2: Device 3: |
| 4. test_group_chat_offline_pn, id: 702808 |
| Device sessions Device 1: Device 2: Device 3: |
Class TestActivityMultipleDevicePRTwo:
| 1. test_activity_center_mentions, id: 702957 |
| Device sessions Device 1: Device 2: |
| 2. test_activity_center_admin_notification_accept_swipe, id: 702958 |
| Device sessions Device 1: Device 2: |
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
| 1. test_1_1_chat_delete_via_long_press_relogin, id: 702784 |
| Device sessions Device 1: Device 2: |
| 2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783 |
| Device sessions Device 1: Device 2: |
| 3. test_1_1_chat_mute_chat, id: 703496 |
| Device sessions Device 1: Device 2: |
Class TestCommunityMultipleDeviceMergedTwo:
| 1. test_community_markdown_support, id: 702809 |
| Device sessions Device 1: Device 2: |
| 2. test_community_hashtag_links_to_community_channels, id: 702948 |
| Device sessions Device 1: Device 2: |
| 3. test_community_mentions_push_notification, id: 702786 |
| Device sessions Device 1: Device 2: |
| 4. test_community_leave, id: 702845 |
| Device sessions Device 1: Device 2: |
| 5. test_community_join_when_node_owner_offline, id: 703629 |
| Device sessions Device 1: Device 2: |
Hey @Rende11 🙌!
Thanks for your PR! All failed e2e tests are known and not related to your PR.
hey @J-Son89 should we merge this?
@flexsurfer - yes let's merge and I can address @ilmotta's comments in a follow up pr 👍