status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Published 20 hours ago • verified publisher icon status-im

[iOS] Keyboard opens automatically when creating a new wallet account

Open qoqobolo opened this issue 1 year ago • 6 comments

Bug Report

Reproduction:

  1. Open wallet on iOS
  2. Add a new account

https://github.com/status-im/status-mobile/assets/67952253/87eaaf39-d942-4abc-ac4b-81dbae9b5e39

Additional Information

  • Status version: nightly 16/02
  • Operating System: iOS

qoqobolo avatar Feb 16 '24 16:02 qoqobolo

I'm not 100% sure if it is the intended behaviour but I got the keyboard to not auto appear when navigating to create wallet account page. ref : https://github.com/status-im/status-mobile/pull/18881 cc @J-Son89 I leave it to your judgement.

siddarthkay avatar Feb 17 '24 10:02 siddarthkay

I'm not 100% sure if it is the intended behaviour but I got the keyboard to not auto appear when navigating to create wallet account page.

Based on the designs, we shouldn't open the keyboard right after navigating to that screen. I also see that the slider should be above the keyboard when it is opened, as it happens on Android, so there is another part of the issue that I did not specify in the description.

Screenshot 2024-02-19 at 12 24 32

@siddarthkay I checked this PR and it fixes the original keyboard auto opening issue. But maybe we should also fix the slider position? @J-Son89 @siddarthkay WDYT?

qoqobolo avatar Feb 19 '24 11:02 qoqobolo

@qoqobolo - the slider position has a bug for that here https://github.com/status-im/status-mobile/issues/18841

Happy to put these into one issue if that's easier?

J-Son89 avatar Feb 19 '24 11:02 J-Son89

@J-Son89 okay, I'll move this to https://github.com/status-im/status-mobile/issues/18841 they just didn't seem the same due to keyboard opening, so logged it separately.

What then should we do with @siddarthkay's PR https://github.com/status-im/status-mobile/pull/18881, should we merge it?

qoqobolo avatar Feb 19 '24 11:02 qoqobolo

Since https://github.com/status-im/status-mobile/pull/18881 is ready better to merge it. I'm okay either way :)

siddarthkay avatar Feb 19 '24 14:02 siddarthkay

Updated https://github.com/status-im/status-mobile/issues/18841

Since https://github.com/status-im/status-mobile/pull/18881 is ready better to merge it. I'm okay either way :)

Checking it again to make sure there is no regression in other parts of the app.

qoqobolo avatar Feb 19 '24 14:02 qoqobolo

Adding the design label and a link to the discussion to make it clear why testing of the corresponding PR was postponed

qoqobolo avatar Mar 01 '24 09:03 qoqobolo

@qoqobolo, @siddarthkay - any confirmation on this. Should we close it?

J-Son89 avatar Apr 08 '24 10:04 J-Son89

Hey @J-Son89 : Sorry I missed this comment. At the moment I am unsure of what was the latest decision. However It would be best if I un-assign myself so others could take this up. Thank you

siddarthkay avatar May 27 '24 06:05 siddarthkay

Seems to me like this issue can be closed. If someone thinks otherwise feel free to reopen.

OmarBasem avatar Jun 03 '24 05:06 OmarBasem