status-mobile
status-mobile copied to clipboard
status-im
Context tags are broken in jump-to screen
Screenshot
Link to figma
https://www.figma.com/file/Tf5nfkYvpbnNCo4rKLK7lS?node-id=6117:66732&mode=design#567169852
@status-im/mobile-qa Can you please make sure that this is still reproducible?
Can't reproduce
Hi @ibrkhalil! Thanks for looking at the issue. I got 1 question: how were you able to generate such context tag that is shown on your screenshot? Current mobile app generates regular community links that do not generate such context tag within chat card and are displayed as a regular message (see screenshot below).
For reproduction of this issue we need to user community invite cards which have been recently deprecated in favor of regular links so I do not know how to verify if the issue still exists. Give me some tips please on how you have managed to generate such community link
Can't reproduce
Hi @ibrkhalil! Thanks for looking at the issue. I got 1 question: how were you able to generate such context tag that is shown on your screenshot? Current mobile app generates regular community links that do not generate such context tag within chat card and are displayed as a regular message (see screenshot below).
For reproduction of this issue we need to user community invite cards which have been recently deprecated in favor of regular links so I do not know how to verify if the issue still exists. Give me some tips please on how you have managed to generate such community link
I remember using Desktop to share
I remember using Desktop to share
I tried Desktop too (the latest nightly build). But got the same link as in mobile.
So currently I cannot verify if the bug is fixed as I cannot generate community context tag which appeared to be broken according to the issue description.
I remember using Desktop to share
I tried Desktop too (the latest nightly build). But got the same link as in mobile.
So currently I cannot verify if the bug is fixed as I cannot generate community context tag which appeared to be broken according to the issue description.
Okay, Thank you very much for trying it out I'll update my desktop/mobile clients and retry to reproduce
Okay, Thank you very much for trying it out I'll update my desktop/mobile clients and retry to reproduce
Thank you for looking at the issue @ibrkhalil. Maybe after this one https://github.com/status-im/status-mobile/pull/18484 is merged we will be able to verify if the bug exists? WDYT?
Okay, Thank you very much for trying it out I'll update my desktop/mobile clients and retry to reproduce
Thank you for looking at the issue @ibrkhalil. Maybe after this one #18484 is merged we will be able to verify if the bug exists? WDYT?
Sure thing :)
Can I please get more clarification if this issue exists or not and what is exactly broken here? CC: @pavloburykh
Can I please get more clarification if this issue exists or not and what is exactly broken here? CC: @pavloburykh
@ibrkhalil we will check if it is reproducible when we will take this https://github.com/status-im/status-mobile/pull/18484 into testing. Currently we are busy with testing those features that need to be included into upcoming release so there might be delay with testing of other PRs.
Hi @ibrkhalil !
Unfortunately I have no ability to check how context tag works at this moment and if this issue exist as we do not have implementation of shared community link view inside 1-1 chat.
https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Design-System-for-Mobile?type=design&node-id=611-22756&mode=design&t=IvH1kGG6pzeCCD1A-0
So, this issue is not connected to the preview you've implemented here.
Hi @Parveshdhull @ibrkhalil ! This design review comment is no longer an expected behaviour for now as we discussed that current implementation previews communities as links and not as tags. Temporary we decided it is a normal behaviour.
I am going to close this issue.
For more details please look at this thread: https://discord.com/channels/624634427930312714/975775548007678033/1209198425074307193