status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Allow message sender to toggle on/off link previews

Open ilmotta opened this issue 2 years ago • 8 comments

Problem

Depends on https://github.com/status-im/status-mobile/pull/15891

Not all users are willing to affect their privacy to share URLs with previews, so we should not always unfurl URLs.

Solution

Show a confirmation dialog the first time ever the user types a URL and no URL was ever unfurled. See Figma > Composer for Mobile. If the user has enabled link previews, then the dialog won't be shown again. In the future, the user will also be able to change this setting globally from setting's screens.

The options "Always show previews" and "Never show previews" are associated with the type https://github.com/status-im/status-go/blob/ceae9d33ad884baafebcf302df05ba3bcff7f3a9/multiaccounts/settings/enums.go#L29


Furthermore, the user should be able to change the settings later on from the Profile Settings (see in Figma). Ignore the GIF previews feature/setting

Image

The feature is already supported in status-desktop, as we can see from the screenshot below:

Image

Acceptance criteria

  • PR, QA, and design reviews all pass.
  • User can change the unfurling mode in the Profile Settings.
  • The user's choice is persisted between app restarts.
  • There's no major discrepancy in behavior between the Mobile and Desktop clients.
  • Choosing "Show for this message" will only affect the current composer message. As soon as the user goes to another screen and return, if they type a URL they will be asked again for unfurling options. Therefore, this state doesn't need to live in status-go.

ilmotta avatar May 16 '23 14:05 ilmotta

Just linking with issue https://github.com/status-im/status-desktop/issues/10866 on the Desktop app.

ilmotta avatar May 31 '23 01:05 ilmotta

I'm unassigning this issue as I am currently not working on it. Please feel free to pick it up. If no one takes it, I will reassign it to myself when I am able to actively work on it again.

ajayesivan avatar Sep 07 '23 21:09 ajayesivan

status-go unfurling settings are tracked here: https://github.com/status-im/status-go/issues/4130

igor-sirotin avatar Oct 12 '23 21:10 igor-sirotin

This feature is implemented in the desktop app, which means the persistence layer is ready, so this is issue should be relatively simple to implement. It's an important feature for users who do not want to expose their IP addresses or simply don't want to generate previews.

@churik I'm reopening with the label you created feature-parity.

ilmotta avatar Nov 07 '24 23:11 ilmotta

i am working on this too

jo-mut avatar May 02 '25 08:05 jo-mut

@ilmotta I have worked on this just by following the designs in this feature request. I think it would a good thing to have access to the figma designs just to cross-check everything. I would appreciate that

jo-mut avatar May 05 '25 12:05 jo-mut

@jo-mut can you access any of the sub links in this special Figma page and can you see the detailed Figma properties? https://www.figma.com/design/aS0Yx5Un99ZXAQWciP3Dy1/Status-Design-Index?node-id=2-31894&m=dev We are in the process of opening up Figma for anyone, but it's still being ironed out.

Have you tried to request access to from Figma and got no response back yet? @xAlisher could you please give read-only access to @jo-mut in a way that allows him to see all component properties?

ilmotta avatar May 14 '25 03:05 ilmotta

@ilmotta I can access them. Thank you @ilmotta

jo-mut avatar May 14 '25 04:05 jo-mut