status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Add Status Waku v2 nodes to fleet configuration

Open felicio opened this issue 2 years ago • 6 comments

Summary

Resolves #13952

Testing notes

Platforms

  • Android
  • iOS
  • macOS
  • Linux
  • Windows

Areas that maybe impacted

Functional
  • communities
  • 1-1 chats
  • public chats
  • group chats
  • user profile updates
  • fleet

Steps to test

  1. The status.prod and status.test fleets are under Settings > Advanced > Fleet
  2. When both Mobile and Desktop have status.test set, then messages between them should be delivered in real time.
  3. When both Mobile and Desktop have status.prod set, then messages between them should be delivered in real time.
  4. When Mobile has status.test set and Desktop has eth.test set, then messages from Desktop should be delivered in real time to Mobile.
  5. When Mobile has status.test set and Desktop has wakuv2.prod set, and when messages are sent from Mobile and Desktop is later set to status.test, then messages should be retrieved on Desktop from history.

status: wip

felicio avatar Sep 08 '22 07:09 felicio

Hey @felicio, and thank you so much for making your first pull request in status-mobile! :heart: Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

status-github-bot[bot] avatar Sep 08 '22 07:09 status-github-bot[bot]

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 0c01b5b8 #1 2022-09-08 07:35:47 ~2 min tests :package:log
:heavy_check_mark: 0c01b5b8 #1 2022-09-08 07:41:08 ~7 min android :package:apk :calling:
:heavy_check_mark: 0c01b5b8 #1 2022-09-08 07:41:40 ~8 min android-e2e :package:apk :calling:
:heavy_check_mark: 0c01b5b8 #1 2022-09-08 07:52:29 ~18 min ios :package:ipa :calling:

status-im-auto avatar Sep 08 '22 07:09 status-im-auto

99% of end-end tests have passed

Total executed tests: 87
Failed tests: 1
Passed tests: 86
IDs of failed tests: 702076 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestPublicChatBrowserOneDeviceMerged:

    1. test_browser_delete_close_tabs, id: 702076

    Device 1: Find `Button` by `xpath`: `//*[contains(@text, 'bbc.com')]/../../../../*[@content-desc='empty-tab']`
    Device 1: Tap on found: Button
    critical/test_public_chat_browsing.py:423: in test_browser_delete_close_tabs
        web_page.element_by_text_part(urls['bbc.com']).wait_for_invisibility_of_element()
    ../views/base_element.py:144: in wait_for_invisibility_of_element
        raise TimeoutException("Device %s: %s by %s: `%s`  is still visible on the screen after %s seconds after wait_for_invisibility_of_element" % (
     Device 1: Button by xpath: `//*[contains(@text, "bbc.com")]`  is still visible on the screen after 10 seconds after wait_for_invisibility_of_element
    



    Device sessions

    Passed tests (86)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevices:

    1. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310
    Device sessions

    3. test_1_1_chat_audio_message_with_push, id: 6316
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373
    Device sessions

    5. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315
    Device sessions

    6. test_1_1_chat_push_emoji, id: 6283
    Device sessions

    7. test_1_1_chat_message_reaction, id: 6315
    Device sessions

    8. test_1_1_chat_image_send_save_reply, id: 6305
    Device sessions

    9. test_1_1_chat_delete_via_delete_button_relogin, id: 5387
    Device sessions

    Class TestGroupChatMultipleDeviceMerged:

    1. test_group_chat_highligted, id: 5756
    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 700731
    Device sessions

    3. test_group_chat_push_system_messages_when_invited, id: 3994
    Device sessions

    4. test_group_chat_add_new_member_activity_centre, id: 700732
    Device sessions

    5. test_group_chat_offline_pn, id: 3998
    Device sessions

    6. test_group_chat_leave_relogin, id: 3997
    Device sessions

    Class TestPairingSyncMultipleDevicesMerged:

    1. test_pairing_sync_initial_profile_picture, id: 702392
    Device sessions

    2. test_pairing_sync_initial_bookmarks, id: 702393
    Device sessions

    3. test_pairing_sync_initial_contacts_blocked_users, id: 702194
    Device sessions

    4. test_pairing_sync_public_chat_add_remove, id: 702199
    Device sessions

    5. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197
    Device sessions

    6. test_pairing_sync_initial_public_chats, id: 702195
    Device sessions

    7. test_pairing_sync_contacts_block_unblock, id: 702196
    Device sessions

    8. test_pairing_sync_1_1_chat_message, id: 702198
    Device sessions

    9. test_pairing_sync_clear_history, id: 702394
    Device sessions

    Class TestCommandsMultipleDevicesMerged:

    1. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253
    Device sessions

    2. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263
    Device sessions

    3. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265
    Device sessions

    Class TestRestoreOneDeviceMerged:

    1. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748
    Device sessions

    2. test_restore_seed_phrase_field_validation, id: 700750
    Device sessions

    3. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189
    Device sessions

    4. test_restore_set_up_wallet_sign_phrase, id: 700749
    Device sessions

    Class TestPublicChatBrowserOneDeviceMerged:

    1. test_public_chat_open_using_deep_link, id: 700739
    Device sessions

    2. test_public_chat_fetch_more_history, id: 5675
    Device sessions

    3. test_browser_offline, id: 702075
    Device sessions

    4. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317
    Device sessions

    5. test_browser_connection_is_secure_not_secure_warning, id: 702073
    Device sessions

    6. test_browser_invalid_url, id: 702074
    Device sessions

    7. test_browser_web3_permissions_testdapp, id: 702078
    Device sessions

    8. test_public_chat_navigate_to_chat_when_relaunch, id: 5396
    Device sessions

    9. test_browser_bookmarks_create_edit_remove, id: 702077
    Device sessions

    10. test_browser_blocked_url, id: 702072
    Device sessions

    11. test_public_chat_tag_message, id: 700738
    Device sessions

    Class TestPublicChatMultipleDeviceMerged:

    1. test_public_chat_unread_messages_counter, id: 5360
    Device sessions

    2. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737
    Device sessions

    3. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718
    Device sessions

    4. test_public_chat_message_edit, id: 700734
    Device sessions

    5. test_public_chat_link_send_open, id: 700736
    Device sessions

    6. test_public_chat_emoji_send_copy_paste_reply, id: 700719
    Device sessions

    7. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313
    Device sessions

    8. test_public_chat_delete_chat_long_press, id: 5319
    Device sessions

    9. test_public_chat_message_delete, id: 700735
    Device sessions

    10. test_public_chat_mark_all_messages_as_read, id: 6270
    Device sessions

    Class TestEnsStickersMultipleDevicesMerged:

    1. test_sticker_1_1_public_chat_mainnet, id: 702157
    Device sessions

    2. test_ens_command_send_tx_eth_1_1_chat, id: 702153
    Device sessions

    3. test_ens_mention_nickname_1_1_chat, id: 702155
    Device sessions

    4. test_ens_mention_push_highlighted_public_chat, id: 702156
    Device sessions

    5. test_ens_purchased_in_profile, id: 702152
    Device sessions

    6. test_start_new_chat_public_key_validation, id: 702158
    Device sessions

    Class TestSendTxDeviceMerged:

    1. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342
    Device sessions

    2. test_send_tx_token_8_decimals, id: 700764
    Device sessions

    3. test_send_tx_eth_check_logcat, id: 700763
    Device sessions

    4. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765
    Device sessions

    5. test_send_tx_set_recipient_options, id: 700757
    Device sessions

    Class TestWalletManagementDeviceMerged:

    1. test_wallet_manage_assets, id: 700758
    Device sessions

    2. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766
    Device sessions

    3. test_wallet_add_account_seed_phrase_validation, id: 700762
    Device sessions

    4. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756
    Device sessions

    5. test_wallet_add_hide_unhide_account_private_key, id: 700761
    Device sessions

    6. test_wallet_add_delete_watch_only_account, id: 700760
    Device sessions

    7. test_wallet_add_account_generate_new, id: 700759
    Device sessions

    Class TestOnboardingOneDeviceMerged:

    1. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746
    Device sessions

    2. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745
    Device sessions

    3. test_onboarding_share_contact_address, id: 700743
    Device sessions

    4. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747
    Device sessions

    5. test_onboarding_home_initial_popup, id: 700742
    Device sessions

    6. test_onboarding_share_wallet_address, id: 700744
    Device sessions

    Class TestContactBlockMigrateKeycardMultipleSharedDevices:

    1. test_keycard_command_send_tx_eth_1_1_chat, id: 702186
    Device sessions

    2. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188
    Device sessions

    3. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177
    Device sessions

    4. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175
    Device sessions

    5. test_contact_block_unblock_public_chat_offline, id: 702176
    Device sessions

    Class TestKeycardTxOneDeviceMerged:

    1. test_keycard_send_tx_eth, id: 700767
    Device sessions

    2. test_keycard_relogin_after_restore, id: 700768
    Device sessions

    3. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769
    Device sessions

    4. test_keycard_create_account_unlock_same_seed, id: 5689
    Device sessions

    5. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770
    Device sessions

    status-im-auto avatar Sep 08 '22 08:09 status-im-auto

    Hello @felicio ! To clarify: do you just need the new fleet in the list or expect us to check history node functionality on this fleet? Please, ping me when it is ready to be tested and rebase your repo according to the current develop branch. Thank you!

    churik avatar Sep 12 '22 08:09 churik

    Hey,

    @churik,

    Please, ping me when it is ready to be tested and rebase your repo according to the current develop branch.

    Will do.

    To clarify: do you just need the new fleet in the list or expect us to check history node functionality on this fleet?

    Both, and relaying (real-time delivery) too.

    When ready, I would like to ask you to help me check that:

    1. The status.prod and status.test fleets are under Settings > Advanced > Fleet
    2. When both Mobile and Desktop have status.test set, then messages between them should be delivered in real time.
    3. When both Mobile and Desktop have status.prod set, then messages between them should be delivered in real time.
    4. When Mobile has status.test set and Desktop has eth.test set, then messages from Desktop should be delivered in real time to Mobile.
    5. When Mobile has status.test set and Desktop has wakuv2.prod set, and when messages are sent from Mobile and Desktop is later set to status.test, then messages should be retrieved on Desktop from history.

    On web, I could check that afterwards since it hasn't been deployed yet. Or I could do that in paralel to your testing.

    @flexsurfer,

    By moving this to "E2E tests" you meant to let me know that the changes are legit, as far as you could tell, and that you don't think any other adjustements should be made? Not even the following?

    • And update any other files relevant to loading the configuration
      • Maybe those referencing wakuv2-config like src/status_im/node/core.cljs, src/status_im/multiaccounts/login/core.cljs and src/status_im/waku/core.cljs

    – https://github.com/status-im/status-mobile/issues/13952#issue-1365689517

    I haven't found time to build this and run it locally yet and wanted to avoid requesting QA prematurely.

    Guys,

    Finally, in the mean time I'll move this to "To rebase" if it's alright with you.

    felicio avatar Sep 12 '22 10:09 felicio

    sorry moved by mistake

    flexsurfer avatar Sep 12 '22 10:09 flexsurfer

    https://github.com/status-im/status-mobile/pull/14283

    flexsurfer avatar Nov 07 '22 13:11 flexsurfer