Fix: unread messages counter when messages are deleted

[jo-mut]

fixes #13228

Summary

This PR solves updating unread messages counter when messages are deleted while the recipient device is offline. It also updates the last preview message when the messages are deleted.

[status-im-auto]

Jenkins Builds

Click to see older builds (42)

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:heavy_multiplication_x:	f5c7cb55	#1	2022-07-04 09:15:59	~12 min	android	:package:apk :calling:
:heavy_multiplication_x:	f5c7cb55	#1	2022-07-04 09:16:00	~12 min	android-e2e	:package:apk :calling:
:heavy_multiplication_x:	f5c7cb55	#1	2022-07-04 09:21:01	~17 min	ios	:package:ipa :calling:
:heavy_check_mark:	b0cacdfc	#2	2022-07-04 09:22:04	~9 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	b0cacdfc	#2	2022-07-04 09:24:05	~11 min	android	:package:apk :calling:
:heavy_check_mark:	b0cacdfc	#2	2022-07-04 09:24:37	~12 min	ios	:package:ipa :calling:
:heavy_check_mark:	d22ab5ad	#3	2022-07-13 17:14:03	~12 min	android	:package:apk :calling:
:heavy_check_mark:	d22ab5ad	#3	2022-07-13 17:17:24	~15 min	ios	:package:ipa :calling:
:heavy_check_mark:	3887ad83	#4	2022-07-13 20:32:02	~9 min	ios	:package:ipa :calling:
:heavy_check_mark:	3887ad83	#4	2022-07-13 20:33:34	~11 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	fc8c3fdf	#5	2022-07-13 22:19:17	~9 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	fc8c3fdf	#5	2022-07-13 22:20:23	~10 min	android	:package:apk :calling:
:heavy_check_mark:	fc8c3fdf	#5	2022-07-13 22:26:11	~16 min	ios	:package:ipa :calling:
:heavy_check_mark:	4971a1c0	#6	2022-07-14 14:29:49	~9 min	android	:package:apk :calling:
:heavy_check_mark:	4971a1c0	#6	2022-07-14 14:29:56	~9 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	4971a1c0	#6	2022-07-14 14:30:47	~10 min	ios	:package:ipa :calling:
:heavy_check_mark:	d62dffaa	#7	2022-07-18 09:55:05	~12 min	android	:package:apk :calling:
:heavy_check_mark:	d62dffaa	#7	2022-07-18 10:00:24	~17 min	ios	:package:ipa :calling:
:heavy_check_mark:	47be6e47	#8	2022-07-18 21:19:05	~11 min	android	:package:apk :calling:
:heavy_check_mark:	47be6e47	#8	2022-07-18 21:20:44	~13 min	ios	:package:ipa :calling:
:heavy_check_mark:	6c3b84d9	#9	2022-07-19 08:39:37	~10 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	6c3b84d9	#9	2022-07-19 08:42:51	~13 min	android	:package:apk :calling:
:heavy_check_mark:	6c3b84d9	#9	2022-07-19 08:48:59	~19 min	ios	:package:ipa :calling:
:heavy_check_mark:	766ae984	#10	2022-07-19 12:59:22	~10 min	ios	:package:ipa :calling:
:heavy_check_mark:	766ae984	#10	2022-07-19 13:00:07	~11 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	766ae984	#10	2022-07-19 13:00:29	~12 min	android	:package:apk :calling:
:heavy_check_mark:	8675888a	#1	2022-09-09 16:28:58	~3 min	tests	:package:log
:heavy_check_mark:	8675888a	#2	2022-09-09 16:35:10	~9 min	android	:package:apk :calling:
:heavy_check_mark:	8675888a	#2	2022-09-09 16:35:13	~9 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	8675888a	#2	2022-09-09 16:51:48	~26 min	ios	:package:ipa :calling:
:heavy_check_mark:	7c8c9b80	#3	2022-09-12 11:25:10	~3 min	tests	:package:log
:heavy_check_mark:	7c8c9b80	#4	2022-09-12 11:32:53	~10 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	7c8c9b80	#4	2022-09-12 11:32:55	~10 min	android	:package:apk :calling:
:heavy_check_mark:	7c8c9b80	#4	2022-09-12 11:37:33	~15 min	ios	:package:ipa :calling:
:heavy_check_mark:	9855c4dd	#4	2022-09-12 12:58:00	~2 min	tests	:package:log
:heavy_check_mark:	9855c4dd	#5	2022-09-12 13:03:12	~8 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	9855c4dd	#5	2022-09-12 13:04:30	~9 min	android	:package:apk :calling:
:heavy_check_mark:	9855c4dd	#5	2022-09-12 13:16:17	~21 min	ios	:package:ipa :calling:
:heavy_check_mark:	acf8cedd	#5	2022-09-12 13:42:46	~4 min	tests	:package:log
:heavy_check_mark:	acf8cedd	#6	2022-09-12 13:46:12	~8 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	acf8cedd	#6	2022-09-12 13:49:12	~11 min	android	:package:apk :calling:
:heavy_check_mark:	acf8cedd	#6	2022-09-12 13:56:06	~18 min	ios	:package:ipa :calling:

:grey_question:	Commit	:hash:	Finished (UTC)	Duration	Platform	Result
:x:	8c68f32f	#7	2022-09-12 15:20:05	~10 sec	ios	:page_facing_up:log
:heavy_check_mark:	8c68f32f	#6	2022-09-12 15:22:29	~2 min	tests	:package:log
:heavy_check_mark:	8c68f32f	#7	2022-09-12 15:28:07	~8 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	8c68f32f	#7	2022-09-12 15:28:19	~8 min	android	:package:apk :calling:
:heavy_check_mark:	8c68f32f	#8	2022-09-12 15:55:13	~10 min	ios	:package:ipa :calling:
:heavy_check_mark:	244c48bc	#7	2022-09-13 08:04:00	~3 min	tests	:package:log
:heavy_check_mark:	244c48bc	#8	2022-09-13 08:08:45	~7 min	android	:package:apk :calling:
:heavy_check_mark:	244c48bc	#8	2022-09-13 08:10:37	~9 min	android-e2e	:package:apk :calling:
:heavy_check_mark:	244c48bc	#9	2022-09-13 08:13:34	~12 min	ios	:package:ipa :calling:

[status-im-auto]

100% of end-end tests have passed

Total executed tests: 84
Failed tests: 0
Passed tests: 84

Passed tests (84)

Click to expand

1. test_wallet_manage_assets, id: 700758

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_public_chat_message_edit, id: 700734

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_contact_block_unblock_public_chat_offline, id: 702176

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_keycard_relogin_after_restore, id: 700768

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

6. test_group_chat_push_system_messages_when_invited, id: 3994

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_send_tx_token_7_decimals, id: 700764

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_public_chat_open_using_deep_link, id: 700739

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

11. test_public_chat_unread_messages_counter, id: 5360

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

12. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

13. test_pairing_sync_contacts_block_unblock, id: 702196

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

14. test_public_chat_emoji_send_copy_paste_reply, id: 700719

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

15. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

16. test_browser_bookmarks_create_edit_remove, id: 702077

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

17. test_send_tx_eth_check_logcat, id: 700763

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

18. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

19. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

20. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

21. test_wallet_add_account_seed_phrase_validation, id: 700762

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

22. test_public_chat_delete_chat_long_press, id: 5319

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

23. test_onboarding_home_initial_popup, id: 700742

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

24. test_browser_blocked_url, id: 702072

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

25. test_wallet_add_hide_unhide_account_private_key, id: 700761

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

26. test_1_1_chat_message_reaction, id: 6315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

27. test_ens_mention_push_highlighted_public_chat, id: 702156

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

28. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

29. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

30. test_1_1_chat_image_send_save_reply, id: 6305

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

31. test_group_chat_highligted, id: 5756

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

32. test_public_chat_link_send_open, id: 700736

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

33. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

34. test_onboarding_share_contact_address, id: 700743

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

35. test_sticker_1_1_public_chat, id: 702157

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

36. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

37. test_restore_set_up_wallet_sign_phrase, id: 700749

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

38. test_ens_mention_nickname_1_1_chat, id: 702155

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

39. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

40. test_browser_delete_close_tabs, id: 702076

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

41. test_public_chat_mark_all_messages_as_read, id: 6270

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

42. test_browser_connection_is_secure_not_secure_warning, id: 702073

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

43. test_send_tx_set_recipient_options, id: 700757

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

44. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

45. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

46. test_group_chat_join_send_text_messages_push, id: 700731

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

47. test_browser_web3_permissions_testdapp, id: 702078

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

48. test_1_1_chat_text_message_with_push, id: 6316

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

49. test_wallet_add_delete_watch_only_account, id: 700760

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

50. test_public_chat_tag_message, id: 700738

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

51. test_onboarding_share_wallet_address, id: 700744

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

52. test_keycard_create_account_unlock_same_seed, id: 5689

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

53. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

54. test_pairing_sync_initial_contacts_blocked_users, id: 702194

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

55. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

56. test_pairing_sync_1_1_chat_message, id: 702198

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

57. test_pairing_sync_public_chat_add_remove, id: 702199

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

58. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

59. test_public_chat_fetch_more_history, id: 5675

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

60. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

61. test_group_chat_offline_pn, id: 3998

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

62. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

63. test_group_chat_add_new_member_activity_centre, id: 700732

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

64. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

65. test_ens_purchased_in_profile, id: 702152

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

66. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

67. test_keycard_send_tx_eth, id: 700767

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

68. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

69. test_browser_offline, id: 702075

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

70. test_browser_invalid_url, id: 702074

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

71. test_restore_seed_phrase_field_validation, id: 700750

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

72. test_wallet_add_account_generate_new, id: 700759

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

73. test_start_new_chat_public_key_validation, id: 702158

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

74. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

75. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

76. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

77. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

78. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

79. test_group_chat_leave_relogin, id: 3997

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

80. test_public_chat_message_delete, id: 700735

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

81. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

82. test_1_1_chat_push_emoji, id: 6283

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

83. test_pairing_sync_initial_public_chats, id: 702195

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

84. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[qoqobolo]

@jo-mut

ISSUE 1: Error appears when trying to re-login after sending a message in a public chat with history

UPD: The issue seems to only reproduce in a public chat that has today's messages in its history (which load immediately when opened). You can try the chat from the video: #bzzz

Steps:

1. Create an account
2. Join a public chat with message history
3. Send a message
4. Re-login

OS: iOS, Android

https://user-images.githubusercontent.com/67952253/177166941-38fd6371-f34b-43ac-8eb1-d7467061f868.mp4

[jo-mut]

Let me have a look at this

[jo-mut]

@qoqobolo this is now fixed. works well

[qoqobolo]

@jo-mut unfortunately, the original issue is still reproducible with the same steps.

1. Device1 and Device2 create new accounts and start a 1-1 chat (relevant for group chats as well)
2. Device2 closes the app
3. Device1 sends a message and deletes it
4. Device2 logs in

Logs

Sender (Device1) geth.log Receiver (Device2) geth.log

https://user-images.githubusercontent.com/67952253/179191532-3fbc689b-9976-4cec-af61-2ae00440f969.mp4

[status-im-auto]

98% of end-end tests have passed

Total executed tests: 84
Failed tests: 2
Passed tests: 82

IDs of failed tests: 702196,702194 

Failed tests (2)

Click to expand

Rerun failed tests

1. test_pairing_sync_contacts_block_unblock, id: 702196

Test is not run, e2e blocker [[reason: [NOTRUN] failing due to issue #13635. Skipping until fix]] Class: TestPairingSyncMultipleDevicesMerged

2. test_pairing_sync_initial_contacts_blocked_users, id: 702194

Test is not run, e2e blocker [[reason: [NOTRUN] failing due to issue #13635. Skipping until fix]] Class: TestPairingSyncMultipleDevicesMerged

Passed tests (82)

Click to expand

1. test_wallet_manage_assets, id: 700758

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

2. test_public_chat_message_edit, id: 700734

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

3. test_contact_block_unblock_public_chat_offline, id: 702176

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

4. test_1_1_chat_text_message_edit_delete_push_disappear, id: 695843

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

5. test_keycard_relogin_after_restore, id: 700768

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

6. test_group_chat_push_system_messages_when_invited, id: 3994

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

7. test_ens_command_send_tx_eth_1_1_chat, id: 702153

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

8. test_send_tx_token_7_decimals, id: 700764

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

9. test_contact_add_remove_mention_default_username_nickname_public_chat, id: 702175

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

10. test_public_chat_open_using_deep_link, id: 700739

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

11. test_public_chat_unread_messages_counter, id: 5360

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

12. test_1_1_chat_command_decline_eth_push_changing_state, id: 6265

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

13. test_public_chat_emoji_send_copy_paste_reply, id: 700719

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

14. test_1_1_chat_command_request_and_send_tx_stt_in_1_1_chat_offline, id: 6263

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

15. test_browser_bookmarks_create_edit_remove, id: 702077

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

16. test_send_tx_eth_check_logcat, id: 700763

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

17. test_public_chat_unread_messages_counter_for_mention_relogin, id: 700718

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

18. test_send_tx_custom_token_18_decimals_invalid_password, id: 700765

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

19. test_onboarding_add_new_multiaccount_username_by_position_pass_validation, id: 700747

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

20. test_wallet_add_account_seed_phrase_validation, id: 700762

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

21. test_public_chat_delete_chat_long_press, id: 5319

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

22. test_onboarding_home_initial_popup, id: 700742

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

23. test_browser_blocked_url, id: 702072

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

24. test_wallet_add_hide_unhide_account_private_key, id: 700761

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

25. test_1_1_chat_message_reaction, id: 6315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

26. test_ens_mention_push_highlighted_public_chat, id: 702156

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

27. test_1_1_chat_emoji_send_reply_and_open_link, id: 5373

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

28. test_keycard_send_tx_sign_message_request_stt_testdapp, id: 700769

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

29. test_1_1_chat_image_send_save_reply, id: 6305

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

30. test_group_chat_highligted, id: 5756

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

31. test_public_chat_link_send_open, id: 700736

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

32. test_keycard_command_send_tx_eth_1_1_chat, id: 702186

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

33. test_onboarding_share_contact_address, id: 700743

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

34. test_sticker_1_1_public_chat, id: 702157

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

35. test_onboarding_backup_seed_phrase_restore_same_login_logcat, id: 700745

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

36. test_restore_set_up_wallet_sign_phrase, id: 700749

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

37. test_ens_mention_nickname_1_1_chat, id: 702155

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

38. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 5310

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

39. test_browser_delete_close_tabs, id: 702076

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

40. test_public_chat_mark_all_messages_as_read, id: 6270

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

41. test_browser_connection_is_secure_not_secure_warning, id: 702073

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

42. test_send_tx_set_recipient_options, id: 700757

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

43. test_onboarding_cant_sign_in_with_invalid_password_logcat, id: 700746

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

44. test_send_tx_sign_message_2tx_in_batch_tx_filters_request_stt_testdapp, id: 5342

Class: TestSendTxDeviceMerged Device sessions Device 1: Steps, video, logs

45. test_group_chat_join_send_text_messages_push, id: 700731

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

46. test_browser_web3_permissions_testdapp, id: 702078

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

47. test_1_1_chat_text_message_with_push, id: 6316

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

48. test_wallet_add_delete_watch_only_account, id: 700760

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

49. test_public_chat_tag_message, id: 700738

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

50. test_onboarding_share_wallet_address, id: 700744

Class: TestOnboardingOneDeviceMerged Device sessions Device 1: Steps, video, logs

51. test_keycard_create_account_unlock_same_seed, id: 5689

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

52. test_1_1_chat_command_send_tx_eth_outgoing_tx_push, id: 6253

Class: TestCommandsMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

53. test_public_chat_navigate_to_chat_when_relaunch, id: 5396

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

54. test_pairing_sync_1_1_chat_message, id: 702198

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

55. test_pairing_sync_public_chat_add_remove, id: 702199

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

56. test_public_chat_copy_and_paste_message_in_chat_input, id: 5317

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

57. test_public_chat_fetch_more_history, id: 5675

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

58. test_wallet_fetching_balance_after_offline_insufficient_funds_errors, id: 700766

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

59. test_group_chat_offline_pn, id: 3998

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

60. test_restore_account_migrate_multiaccount_to_keycard_db_saved, id: 702177

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

61. test_group_chat_add_new_member_activity_centre, id: 700732

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

62. test_public_chat_links_with_previews_github_youtube_twitter_gif_send_enable, id: 700737

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

63. test_ens_purchased_in_profile, id: 702152

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

64. test_1_1_chat_non_latin_message_to_newly_added_contact_with_profile_picture_on_different_networks, id: 5315

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

65. test_keycard_send_tx_eth, id: 700767

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

66. test_restore_account_migrate_multiaccount_to_keycard_no_db_saved_add_wallet_send_tx, id: 702189

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

67. test_browser_offline, id: 702075

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

68. test_browser_invalid_url, id: 702074

Class: TestPublicChatBrowserOneDeviceMerged Device sessions Device 1: Steps, video, logs

69. test_restore_seed_phrase_field_validation, id: 700750

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

70. test_wallet_add_account_generate_new, id: 700759

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

71. test_start_new_chat_public_key_validation, id: 702158

Class: TestEnsStickersMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

72. test_restore_uppercase_whitespaces_seed_phrase_special_char_passw_logcat, id: 700748

Class: TestRestoreOneDeviceMerged Device sessions Device 1: Steps, video, logs

73. test_public_chat_message_send_check_timestamps_while_on_different_tab, id: 5313

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

74. test_wallet_tx_history_copy_tx_hash_on_cellular, id: 700756

Class: TestWalletManagementDeviceMerged Device sessions Device 1: Steps, video, logs

75. test_cellular_settings_on_off_public_chat_fetching_history, id: 702188

Class: TestContactBlockMigrateKeycardMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

76. test_1_1_chat_delete_via_delete_button_relogin, id: 5387

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

77. test_group_chat_leave_relogin, id: 3997

Class: TestGroupChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

78. test_public_chat_message_delete, id: 700735

Class: TestPublicChatMultipleDeviceMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

79. test_keycard_wallet_recover_pairing_check_balance_after_offline_tx_history, id: 700770

Class: TestKeycardTxOneDeviceMerged Device sessions Device 1: Steps, video, logs

80. test_1_1_chat_push_emoji, id: 6283

Class: TestOneToOneChatMultipleSharedDevices Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

81. test_pairing_sync_initial_public_chats, id: 702195

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

82. test_pairing_sync_contacts_add_remove_set_nickname_ens, id: 702197

Class: TestPairingSyncMultipleDevicesMerged Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

[jo-mut]

What I have figured out is the message preview is not being consistently updated when the last message is deleted. At times it works and other times it fails and I think I know why.

[qoqobolo]

@jo-mut ping me here please once it's ready to be retested Thanks

[flexsurfer]

@jo-mut is this still relevant ?

[jo-mut]

@flexsurfer this is actually what I will be focusing on the next today and maybe tomorrow. It is

[flexsurfer]

@jo-mut any updates ?

[jo-mut]

i will update this shortly as it what am working on today

[jo-mut]

@qoqobolo check this out. The issue is solved

[qoqobolo]

@jo-mut thank you for the fix, the original issue has gone, but two more arose :( The first one looks like an edge case, but it's a regression, so could you please check this?

ISSUE 2: No preview and unread indicator for messages in 1-1 chat in case if open the app on the last opened chat and quickly go back to the home screen

Steps to reproduce:

1. UserA and UserB start 1-1 chat
2. UserA kills the app on the 1-1 chat screen
3. UserB sends some messages to the 1-1 chat
4. UserA opens the app and quickly taps the Back button to go to the home screen before new messages are loaded

Expected result (as it works on develop): the new messages are loaded; preview and unviewed counter are shown on the chat Actual result (PR builds): no preview and unviewed indicator on the chat; preview doesn't appear even after relogin

https://user-images.githubusercontent.com/67952253/189885974-e9b366f8-89e6-4deb-a3fc-758592b19ded.mp4

Logs: sender geth.log receiver geth.log

Also, I was able to reproduce a case when there was an unread indicator but was not the preview. But I don't have the exact steps for it :(

https://user-images.githubusercontent.com/67952253/189886787-bab52fcd-8c61-4fd7-9128-66079095e702.mp4

ISSUE 3: No preview in public chats for messages that were there before joining

Steps:

1. Create new user
2. Join public chat with history
3. Go back to the home screen

Logs: geth.log

https://user-images.githubusercontent.com/67952253/189888512-b6c9be31-a569-493e-83f8-fafffeb26eea.mp4

[jo-mut]

Thank you @qoqobolo. I will take a look and resolve these ones

[jo-mut]

@qoqobolo since in the new ui we will not be having unread-messages-count and the last-chat-message preview I am thinking to close this issue for now or atleast adapt it to address the functionality as is in the redesign

[qoqobolo]

@jo-mut okay, let's close this. We'll check the case in the new UI and re-open the issue if reproducible. Thank you