status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Extend clojure integration test to cover starting a one-to-one chat

Open cammellos opened this issue 2 years ago • 2 comments

We should increase the coverage of the newly created clojure integration tests.

One of the most common use cases is to create/start a one to one chat.

The test steps that should be covered in the tests should be:

  1. Create a new account (already covered by steps) & login (we can start from these steps https://github.com/status-im/status-react/blob/9f9b896eb7fcfac60d55b33a3744480b13d2ba8d/src/status_im/integration_test.cljs#L46 )
  2. Simulate inputting a public key
  3. Create a chat

We want to achieve the closest coverage to what the UI is actually doing.

To simulate in the UI:

  1. Create a new account
  2. Click on the + button on the home screen
  3. Click on Start new chat
  4. Input a public key
  5. Click on the username

If you have any question feel free to ask me on discord.

cammellos avatar Jun 24 '22 15:06 cammellos

Thoughts while working on this one.

The first thing I tried is to get a working REPL to do code on integration tests.

Currently, the test runner is injected by shadow-cljs and doesn't have an option for not quitting the node process.

I suggest we fix it with a custom test runner, or, even better, implement it in shadow-cljs.

yqrashawn avatar Jul 27 '22 09:07 yqrashawn

@Samyoul can you assign me this one?

spac3c4det avatar Aug 04 '22 12:08 spac3c4det

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 200.0 DAI attached to it.

gitcoinbot avatar Aug 23 '22 14:08 gitcoinbot

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

These users each claimed they can complete the work by 3 weeks, 3 days from now. Please review their action plans below:

1) littlezigy has applied to start work (Funders only: approve worker | reject worker).

Hello. I have taken the steps in "To simulate in the UI" on the mobile app and I understand the task.

I will update the integration tests (integration_test.cljs) and add steps to cover

Hello, I would like to write the integration tests. I fully understand the task and look forward to contribute. 3) spac3c4det has been approved to start work.

Was assigned the issue in Github and finished a PR: https://github.com/status-im/status-mobile/pull/13797

Learn more on the Gitcoin Issue Details page.

gitcoinbot avatar Aug 25 '22 06:08 gitcoinbot

Could someone please go and merge: https://github.com/status-im/status-mobile/issues/13579

spac3c4det avatar Aug 29 '22 11:08 spac3c4det

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 200.0 DAI (200.00 USD @ $1.0/DAI) has been submitted by:

  1. @spac3c4det

@statussceptre please take a look at the submitted work:

  • PR by @spac3c4det

gitcoinbot avatar Aug 29 '22 12:08 gitcoinbot