status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

Published 20 hours ago • verified publisher icon status-im

Migrate Wallet Connect to beta.100

Open briansztamfater opened this issue 2 years ago • 1 comments

New packages have been published under @walletconnect/sign-client at version 2.0.0-beta.100

Here are the migration docs for you to migrate beta.26 to beta.100: https://gist.github.com/pedrouid/1a36c6a8776e49453838578ec84715e6

briansztamfater avatar May 30 '22 15:05 briansztamfater

i'll look into this :) @flexsurfer

qfrank avatar Aug 09 '22 02:08 qfrank

Hi @flexsurfer , when i update "@walletconnect/client": "^2.0.0-beta.23" to "@walletconnect/sign-client": "^2.0.0-beta.100" , i couldn't make status startup normally, error log:

[Fri Aug 12 2022 18:27:54.915]  ERROR    ReferenceError: Property 'TextEncoder' doesn't exist, js engine: hermes
[Fri Aug 12 2022 18:27:54.915]  ERROR    Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication), js engine: hermes

i'm not good at this, so i think i should leave this opportunity to other talents :)

qfrank avatar Aug 12 '22 11:08 qfrank

@briansztamfater any thoughts?

flexsurfer avatar Aug 12 '22 11:08 flexsurfer

I'll try this out @flexsurfer

siddarthkay avatar Aug 18 '22 11:08 siddarthkay

[Fri Aug 12 2022 18:27:54.915] ERROR ReferenceError: Property 'TextEncoder' doesn't exist, js engine: hermes [Fri Aug 12 2022 18:27:54.915] ERROR Invariant Violation: Module AppRegistry is not a registered callable module (calling runApplication), js engine: hermes

I was able to recreate this error.

The migration docs here : https://gist.github.com/pedrouid/1a36c6a8776e49453838578ec84715e6 mention that we have to explicitly also install the following dependency : @react-native-async-storage/async-storage we however have a different version of Async Storage in our package.json : @react-native-community/async-storage

It is clear that these 2 dependencies can not co-exist in our codebase, I'll do more research on this to find the best way forward.

siddarthkay avatar Aug 19 '22 06:08 siddarthkay

it seems like @react-native-community/async-storage is deprecated and we should get rid of its usage/bindings in our code and replace with @react-native-async-storage/async-storage instead.

Screenshot 2022-08-19 at 2 34 30 PM

siddarthkay avatar Aug 19 '22 09:08 siddarthkay

it seems like @react-native-community/async-storage is deprecated and we should get rid of its usage/bindings in our code and replace with @react-native-async-storage/async-storage instead.

Addressing that here https://github.com/status-im/status-mobile/pull/13846

siddarthkay avatar Aug 24 '22 02:08 siddarthkay

Closing for now, we will re-open as we'll be ready to work on it

cammellos avatar Jul 14 '23 10:07 cammellos