status-mobile icon indicating copy to clipboard operation
status-mobile copied to clipboard

"Status would like to find and connect devices on your local network" popup is shown on IOS after creating/restoring multiaccount

Open churik opened this issue 3 years ago • 8 comments

Bug Report

Problem

Not sure what is bout this security popup, seems to be "new privacy feature of iOS 14 as described in the WWDC 2020 "Support local network privacy in your app" source Not sure it is required for our app, as even you tap "Don't allow", app works as expected.

Expected behavior

no pop-up, as it doesn't affect app

Actual behavior

unknown

Reproduction

  • Open Status
  • Create multiaccount
  • After creating multiaccount tap on popup "Status" would like to find and connect devices on your local network Don't allow
  • check messaging

Additional Information

  • Status version: release 1.13
  • Operating System: iOS

churik avatar May 06 '21 14:05 churik

сс @guylouis

churik avatar May 06 '21 14:05 churik

relevant on 1.15

churik avatar Jul 27 '21 14:07 churik

apparently this prompt is triggered on iOS14 and newer by any network access on local network: https://developer.apple.com/forums/thread/663874. Denying it probably doesn't break the app completely but might limit some functionality (sync comes to mind). This can probably be closed?

bitgamma avatar Dec 14 '21 06:12 bitgamma

In 1.23 this issue is still relevant and according to the design review, this should be an additional step for the user to trigger this pop-up. Currently, it appears on its own after "Generating keys" screen:

https://github.com/status-im/status-mobile/assets/4557972/9f2dd6cd-b01d-4f79-9f45-efe0345cc222

churik avatar Jun 20 '23 08:06 churik

we need to figure out why this permission is needed on generating account and if it is required add designer task on it

churik avatar Jul 04 '23 10:07 churik

This is most likely due to waku2/libp2p, we just need one final confirmation.

cammellos avatar Jul 14 '23 10:07 cammellos

we have a way to trigger these permissions when we want. I'll add support for this in our react-native-status module and discuss with Design on UI for this.

siddarthkay avatar Feb 17 '24 18:02 siddarthkay

I recently faced this popup and it was annoying and hence I am determined to fix this.

siddarthkay avatar Feb 17 '24 18:02 siddarthkay

My current theory is that whenever status-go is initialised this network popup is shown since we do a lot of network stuff there. If we would have an option to trigger a preflight request before we initialise status-go then that would force this popup to appear at a deterministic point rather than appear randomly. We would also have to do some research on triggering status-go initialisation rather than it being present at the very beginning of native modules.

siddarthkay avatar Apr 29 '24 09:04 siddarthkay

Descoping for now

churik avatar May 03 '24 11:05 churik

Freeing this one up so that others can pick this up

siddarthkay avatar May 30 '24 07:05 siddarthkay