status-go icon indicating copy to clipboard operation
status-go copied to clipboard

chore: update all tests that use default pubsubTopic to use shard based pubsubTopic

Open chaitanyaprem opened this issue 1 year ago • 1 comments

Problem

Named sharding is being deprecated in nwaku and also the fleets that support named shards are being shut-down. Any tests that depend on the default pubsubTopic i.e /waku/2/default-waku/proto should be migrated to use sharding based pubsubTopic.

Especially if the tests are dependent on fleets, then they would start failing.

Implementation

Need to analyze which tests use this and modify them accordingly. Note that wakunode would have to be started with clusterID 16 in the tests when this change is being made. https://github.com/status-im/status-go/pull/4665/ can be referred as i had modified some of waku tests to switch to shard based pubsubTopics.

Acceptance Criteria

All tests should pass successfully.

cc @richard-ramos

chaitanyaprem avatar Jun 03 '24 06:06 chaitanyaprem

Have noticed that many tests still use clusterID as 0 and useShardAsDefaultTopic set to false. This needs to be fixed to use defaultClusterID 16 and shard as 32.

eg : https://github.com/status-im/status-go/blob/d8a49c538b744fbde10acff5b395cef91e24cd78/protocol/waku_builder_test.go#L73

chaitanyaprem avatar Jun 27 '24 07:06 chaitanyaprem