status-go icon indicating copy to clipboard operation
status-go copied to clipboard

chore: add name length error

Open vpavlin opened this issue 1 year ago • 3 comments

add an error and a check to handle the invalid name length explicitly

While trying out status-cli I got the ErrInvalidDisplayNameRegExp error, but it was not immediately clear what is the issue. I thought about adding more into that error, but it felt like it would get a bit overwhelming, so I added a separate one.

Definitely low priority, just something I hit while looking at status-go

Closes #

vpavlin avatar May 21 '24 15:05 vpavlin

Hey @vpavlin, and thank you so much for making your first pull request in status-go! :heart: Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2

ghost avatar May 21 '24 15:05 ghost

Jenkins Builds

Click to see older builds (7)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: fbf42eed #1 2024-05-21 15:52:15 ~2 min tests :page_facing_up:log
:heavy_check_mark: fbf42eedb92e50dd3edd3da75dff652a4ee52fcb #1 2024-05-21 15:55:00 ~5 min linux :package:zip
:heavy_check_mark: fbf42eedb92e50dd3edd3da75dff652a4ee52fcb #1 2024-05-21 15:55:06 ~5 min ios :package:zip
:heavy_check_mark: fbf42eedb92e50dd3edd3da75dff652a4ee52fcb #1 2024-05-21 15:55:46 ~6 min android :package:aar
:heavy_check_mark: 3e78b11ca0856015618e4a829db932e4a1399621 #2 2024-05-21 16:00:44 ~3 min ios :package:zip
:heavy_check_mark: 3e78b11ca0856015618e4a829db932e4a1399621 #2 2024-05-21 16:01:14 ~4 min linux :package:zip
:heavy_check_mark: 3e78b11ca0856015618e4a829db932e4a1399621 #2 2024-05-21 16:03:19 ~6 min android :package:aar
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_multiplication_x: 3e78b11c #2 2024-05-21 16:35:00 ~37 min tests :page_facing_up:log
:heavy_check_mark: 4d4d0fff #3 2025-07-02 17:03:17 ~2 min android :package:aar
:heavy_check_mark: 4d4d0fff #3 2025-07-02 17:03:47 ~3 min linux :package:zip
:heavy_check_mark: 4d4d0fff #1 2025-07-02 17:03:52 ~3 min macos :package:zip
:heavy_check_mark: 4d4d0fff #1 2025-07-02 17:04:32 ~3 min macos :package:zip
:heavy_check_mark: 4d4d0fff #3 2025-07-02 17:04:43 ~4 min ios :package:zip
:heavy_check_mark: 4d4d0fff #1 2025-07-02 17:07:01 ~6 min tests-rpc :page_facing_up:log
:heavy_check_mark: 4d4d0fff #1 2025-07-02 17:07:01 ~6 min windows :package:zip
:heavy_check_mark: 4d4d0fff #1 2025-07-02 17:11:00 ~10 min linux :package:zip
:heavy_check_mark: 4d4d0fff #3 2025-07-02 17:26:48 ~26 min tests :page_facing_up:log

status-im-auto avatar May 21 '24 15:05 status-im-auto

@vpavlin, looks like TestDisplayNameRestrictions has to be updated

igor-sirotin avatar May 30 '24 09:05 igor-sirotin

Rebased and imroved. Ready for review

igor-sirotin avatar Jul 02 '25 17:07 igor-sirotin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 60.03%. Comparing base (6187fcd) to head (4d4d0ff). Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5200      +/-   ##
===========================================
- Coverage    60.08%   60.03%   -0.06%     
===========================================
  Files          833      833              
  Lines       103601   103603       +2     
===========================================
- Hits         62249    62197      -52     
- Misses       33784    33812      +28     
- Partials      7568     7594      +26     
Flag Coverage Δ
functional 28.62% <0.00%> (+0.22%) :arrow_up:
unit 57.30% <100.00%> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
common/utils.go 76.66% <100.00%> (+0.80%) :arrow_up:

... and 28 files with indirect coverage changes

codecov[bot] avatar Jul 02 '25 17:07 codecov[bot]