status-go
status-go copied to clipboard
status-im
Simplify FilterManager
Fixes https://github.com/status-im/status-go/issues/4659
After some looking on FilterManager, it appears that it's too complicated. Since the logic for setting specific peers has been removed in favour of automatic selection, i don't actually see any need to maintain any knowledge about particular peers on FilterManager level. Also, maintaining MinPeersForFilter connections for each filter is also out of status-go's purview, i think. Let go-waku handle that.
There are some changes to be made in go-waku as well (will push separately):
IsSubscriptionAlivechecks have to be smart enough in order to not to issue too many requests to same peers (multiple subs can share identical peers)- probably subscription channels returned to status-go have to be multiplexed in case of multiple peers. There should be a 1-to-1 mapping between filters and subscriptions in status-go.
List of other changes to FilterManager:
- dropped lots of code there
- async is there only for multiple filters
- all operations for a single filter occur in a synchronous fashion, in order to guarantee proper ordering.
Jenkins Builds
Click to see older builds (191)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_multiplication_x: | 701456b6 | #1 | 2024-02-01 14:49:47 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 701456b6 | #1 | 2024-02-01 14:50:10 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | 701456b6 | #1 | 2024-02-01 14:52:16 | ~5 min | ios |
:package:zip |
| :heavy_check_mark: | 701456b6 | #1 | 2024-02-01 14:52:43 | ~5 min | android |
:package:aar |
| :heavy_multiplication_x: | ff2f27a4 | #2 | 2024-02-01 16:04:36 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | ff2f27a4 | #2 | 2024-02-01 16:06:41 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | ff2f27a4 | #2 | 2024-02-01 16:06:54 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | ff2f27a4 | #2 | 2024-02-01 16:08:38 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | 8aed250e | #3 | 2024-02-01 16:10:08 | ~1 min | linux |
:package:zip |
| :heavy_multiplication_x: | 8aed250e | #3 | 2024-02-01 16:10:54 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 8aed250e | #3 | 2024-02-01 16:11:07 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 8aed250e | #3 | 2024-02-01 16:11:37 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 16c3d47f | #4 | 2024-02-01 16:16:03 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | 16c3d47f | #4 | 2024-02-01 16:16:51 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 16c3d47f | #4 | 2024-02-01 16:17:27 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 16c3d47f | #4 | 2024-02-01 16:50:47 | ~36 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | c7a6631a | #5 | 2024-02-12 12:35:00 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | c7a6631a | #5 | 2024-02-12 12:37:00 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | c7a6631a | #5 | 2024-02-12 12:37:41 | ~6 min | ios |
:package:zip |
| :heavy_multiplication_x: | c7a6631a | #5 | 2024-02-12 12:59:14 | ~27 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | 6992df89 | #6 | 2024-02-13 03:06:59 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 6992df89 | #6 | 2024-02-13 03:07:11 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | 6992df89 | #6 | 2024-02-13 03:07:43 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 6992df89 | #6 | 2024-02-13 03:10:08 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | 9c66b21a | #7 | 2024-02-13 05:36:21 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | 9c66b21a | #7 | 2024-02-13 05:38:02 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | 9c66b21a | #7 | 2024-02-13 05:38:50 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | 9c66b21a | #7 | 2024-02-13 06:11:27 | ~36 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | dcb26ffb | #8 | 2024-02-13 09:27:57 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | dcb26ffb | #8 | 2024-02-13 09:28:35 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | dcb26ffb | #8 | 2024-02-13 09:30:30 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | dcb26ffb | #8 | 2024-02-13 10:01:06 | ~36 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | affe1bb8 | #9 | 2024-02-14 08:00:29 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | affe1bb8 | #9 | 2024-02-14 08:00:58 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | affe1bb8 | #9 | 2024-02-14 08:03:08 | ~4 min | ios |
:package:zip |
| :heavy_multiplication_x: | affe1bb8 | #9 | 2024-02-14 08:29:49 | ~30 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | b4694a22 | #10 | 2024-02-15 09:15:20 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | b4694a22 | #10 | 2024-02-15 09:15:31 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | b4694a22 | #10 | 2024-02-15 09:16:17 | ~2 min | ios |
:package:zip |
| :heavy_multiplication_x: | b4694a22 | #10 | 2024-02-15 09:37:41 | ~24 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 1842d88b | #11 | 2024-02-16 16:54:40 | ~1 min | linux |
:package:zip |
| :heavy_check_mark: | 1842d88b | #11 | 2024-02-16 16:56:07 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 1842d88b | #11 | 2024-02-16 16:58:24 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | 1842d88b | #11 | 2024-02-16 17:33:08 | ~39 min | tests |
:page_facing_up:log |
| :x: | da31d826ea5f790ae146c1386d436a38cebc5a80 | #12 | 2024-05-06 11:51:27 | ~1 min | ios |
:page_facing_up:log |
| :x: | da31d826ea5f790ae146c1386d436a38cebc5a80 | #12 | 2024-05-06 11:51:34 | ~1 min | android |
:page_facing_up:log |
| :heavy_multiplication_x: | da31d826ea5f790ae146c1386d436a38cebc5a80 | #12 | 2024-05-06 11:51:35 | ~1 min | tests |
:page_facing_up:log |
| :x: | da31d826ea5f790ae146c1386d436a38cebc5a80 | #12 | 2024-05-06 11:51:44 | ~1 min | linux |
:page_facing_up:log |
| :heavy_multiplication_x: | d690595b | #13 | 2024-05-19 23:29:48 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | d690595b39fb21f6837a36704d1e01433cef4072 | #13 | 2024-05-19 23:32:33 | ~4 min | linux |
:package:zip |
| :heavy_check_mark: | d690595b39fb21f6837a36704d1e01433cef4072 | #13 | 2024-05-19 23:33:19 | ~4 min | android |
:package:aar |
| :heavy_check_mark: | d690595b39fb21f6837a36704d1e01433cef4072 | #13 | 2024-05-19 23:33:20 | ~4 min | ios |
:package:zip |
| :heavy_multiplication_x: | eaf8c7fd | #14 | 2024-05-19 23:37:38 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | eaf8c7fd188fe14fef27d2a02c7c9a3eca8429e2 | #14 | 2024-05-19 23:39:39 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | eaf8c7fd188fe14fef27d2a02c7c9a3eca8429e2 | #14 | 2024-05-19 23:40:27 | ~4 min | linux |
:package:zip |
| :heavy_check_mark: | eaf8c7fd188fe14fef27d2a02c7c9a3eca8429e2 | #14 | 2024-05-19 23:42:28 | ~6 min | android |
:package:aar |
| :heavy_multiplication_x: | bb2b37ea | #15 | 2024-05-19 23:44:07 | ~56 sec | tests |
:page_facing_up:log |
| :heavy_check_mark: | bb2b37ea1342995577852cc5901a6799ff63f772 | #15 | 2024-05-19 23:44:50 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | bb2b37ea1342995577852cc5901a6799ff63f772 | #15 | 2024-05-19 23:45:20 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | bb2b37ea1342995577852cc5901a6799ff63f772 | #15 | 2024-05-19 23:46:22 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | bbbd9c01376e1ad415b15aaa8458dc86615c0e70 | #16 | 2024-05-19 23:51:16 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | bbbd9c01376e1ad415b15aaa8458dc86615c0e70 | #16 | 2024-05-19 23:51:26 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | bbbd9c01376e1ad415b15aaa8458dc86615c0e70 | #16 | 2024-05-19 23:52:22 | ~3 min | ios |
:package:zip |
| :heavy_multiplication_x: | bbbd9c01 | #16 | 2024-05-19 23:51:43 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 18114c9c98eaeb260a04487ab55de1b070d70ad9 | #17 | 2024-05-20 00:09:18 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 18114c9c98eaeb260a04487ab55de1b070d70ad9 | #17 | 2024-05-20 00:09:22 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 18114c9c98eaeb260a04487ab55de1b070d70ad9 | #17 | 2024-05-20 00:10:17 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 18114c9c | #17 | 2024-05-20 00:50:49 | ~44 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 1c60cbe07f2625cd0701d93fd42e6fa8d4319cdd | #18 | 2024-05-20 00:51:23 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | 1c60cbe07f2625cd0701d93fd42e6fa8d4319cdd | #18 | 2024-05-20 00:52:02 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 1c60cbe07f2625cd0701d93fd42e6fa8d4319cdd | #18 | 2024-05-20 00:52:37 | ~3 min | ios |
:package:zip |
| :heavy_multiplication_x: | 1c60cbe0 | #18 | 2024-05-20 00:52:01 | ~59 sec | tests |
:page_facing_up:log |
| :heavy_check_mark: | a0644074d7feda42f922e548e0a8d9921ac33775 | #19 | 2024-05-20 01:11:59 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | a0644074d7feda42f922e548e0a8d9921ac33775 | #19 | 2024-05-20 01:12:22 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | a0644074d7feda42f922e548e0a8d9921ac33775 | #19 | 2024-05-20 01:13:26 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | a0644074 | #19 | 2024-05-20 01:52:36 | ~42 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | 15cd5065 | #20 | 2024-05-23 06:10:22 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 15cd50659af1be024e31ed0283360bb3464e714b | #20 | 2024-05-23 06:11:58 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 15cd50659af1be024e31ed0283360bb3464e714b | #20 | 2024-05-23 06:12:06 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 15cd50659af1be024e31ed0283360bb3464e714b | #20 | 2024-05-23 06:12:46 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 4e824b4110f9de5e001b5cbe6d05700f7244b723 | #21 | 2024-05-23 07:21:17 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 4e824b4110f9de5e001b5cbe6d05700f7244b723 | #21 | 2024-05-23 07:21:24 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 4e824b4110f9de5e001b5cbe6d05700f7244b723 | #21 | 2024-05-23 07:21:28 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 4e824b41 | #21 | 2024-05-23 08:02:12 | ~43 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | e535eab6 | #22 | 2024-05-27 07:07:11 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | e535eab6c699b9d1604c0fa780dd12d41330e306 | #22 | 2024-05-27 07:07:33 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | e535eab6c699b9d1604c0fa780dd12d41330e306 | #22 | 2024-05-27 07:07:58 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | e535eab6c699b9d1604c0fa780dd12d41330e306 | #22 | 2024-05-27 07:09:02 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | e93961b4e5d015de65143dcbbc06513a1e09dc0d | #23 | 2024-05-27 07:37:21 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | e93961b4e5d015de65143dcbbc06513a1e09dc0d | #23 | 2024-05-27 07:37:35 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | e93961b4e5d015de65143dcbbc06513a1e09dc0d | #23 | 2024-05-27 07:38:29 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | e93961b4 | #23 | 2024-05-27 08:19:21 | ~44 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | db7f70e8 | #24 | 2024-05-28 07:05:23 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | db7f70e873a5c3009fea143d56bd7a91977cc84e | #24 | 2024-05-28 07:07:01 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | db7f70e873a5c3009fea143d56bd7a91977cc84e | #24 | 2024-05-28 07:07:06 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | db7f70e873a5c3009fea143d56bd7a91977cc84e | #24 | 2024-05-28 07:07:55 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | cc22d7dc321ceaa3599a76698923c38bd12a083a | #25 | 2024-05-28 12:22:03 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | cc22d7dc321ceaa3599a76698923c38bd12a083a | #25 | 2024-05-28 12:22:45 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | cc22d7dc321ceaa3599a76698923c38bd12a083a | #25 | 2024-05-28 12:25:05 | ~6 min | android |
:package:aar |
| :heavy_check_mark: | cc22d7dc | #25 | 2024-05-28 13:03:05 | ~44 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | 78be2fd8 | #26 | 2024-05-29 01:43:40 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 78be2fd87a2273a10d1a114129cf99afbfe3b4a2 | #26 | 2024-05-29 01:45:07 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 78be2fd87a2273a10d1a114129cf99afbfe3b4a2 | #26 | 2024-05-29 01:45:16 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 78be2fd87a2273a10d1a114129cf99afbfe3b4a2 | #26 | 2024-05-29 01:45:36 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 18a7bf31ed6d3f0911eb62c5ddc04698c263e0e9 | #27 | 2024-05-29 06:37:30 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | 18a7bf31ed6d3f0911eb62c5ddc04698c263e0e9 | #27 | 2024-05-29 06:37:55 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 18a7bf31ed6d3f0911eb62c5ddc04698c263e0e9 | #27 | 2024-05-29 06:38:38 | ~3 min | ios |
:package:zip |
| :heavy_multiplication_x: | 18a7bf31 | #27 | 2024-05-29 07:12:17 | ~36 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | f9fa880d564601a1dc1878af298e8d8c36ba4f82 | #28 | 2024-05-29 09:25:23 | ~3 min | android |
:package:aar |
| :heavy_check_mark: | f9fa880d564601a1dc1878af298e8d8c36ba4f82 | #28 | 2024-05-29 09:25:31 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | f9fa880d564601a1dc1878af298e8d8c36ba4f82 | #28 | 2024-05-29 09:26:42 | ~4 min | linux |
:package:zip |
| :heavy_check_mark: | 521f5bb4f00f61766bceb0de8234de348fc040a6 | #29 | 2024-05-29 09:30:28 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 521f5bb4f00f61766bceb0de8234de348fc040a6 | #29 | 2024-05-29 09:30:36 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 521f5bb4f00f61766bceb0de8234de348fc040a6 | #29 | 2024-05-29 09:31:08 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | f9fa880d | #28 | 2024-05-29 10:09:27 | ~47 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 521f5bb4 | #29 | 2024-05-29 10:53:20 | ~43 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 634fb98327c06e01962f46b4317ff292403adc03 | #30 | 2024-05-29 10:57:28 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 634fb98327c06e01962f46b4317ff292403adc03 | #30 | 2024-05-29 10:57:29 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | 634fb98327c06e01962f46b4317ff292403adc03 | #30 | 2024-05-29 10:58:58 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | 634fb983 | #30 | 2024-05-29 11:38:55 | ~44 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | 630f3e5f | #31 | 2024-05-30 09:17:31 | ~1 min | tests |
:page_facing_up:log |
| :x: | 630f3e5f2765f974974c9dc73bfb5fdebadae9b2 | #31 | 2024-05-30 09:17:40 | ~1 min | android |
:page_facing_up:log |
| :x: | 630f3e5f2765f974974c9dc73bfb5fdebadae9b2 | #31 | 2024-05-30 09:17:42 | ~1 min | linux |
:page_facing_up:log |
| :x: | 630f3e5f2765f974974c9dc73bfb5fdebadae9b2 | #31 | 2024-05-30 09:17:55 | ~1 min | ios |
:page_facing_up:log |
| :x: | dc665a7b1bcb0cfbf7b1104ed3bb76aebb49ee8c | #32 | 2024-05-30 09:18:28 | ~28 sec | android |
:page_facing_up:log |
| :x: | dc665a7b1bcb0cfbf7b1104ed3bb76aebb49ee8c | #32 | 2024-05-30 09:18:57 | ~45 sec | ios |
:page_facing_up:log |
| :x: | dc665a7b1bcb0cfbf7b1104ed3bb76aebb49ee8c | #32 | 2024-05-30 09:19:19 | ~1 min | linux |
:page_facing_up:log |
| :heavy_multiplication_x: | dc665a7b | #32 | 2024-05-30 09:20:12 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 31590b5e0f62a09f0a6a7df8f38a062dadbc35e6 | #33 | 2024-05-30 09:30:36 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | 31590b5e0f62a09f0a6a7df8f38a062dadbc35e6 | #33 | 2024-05-30 09:31:53 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | 31590b5e0f62a09f0a6a7df8f38a062dadbc35e6 | #33 | 2024-05-30 09:32:18 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | 31590b5e | #33 | 2024-05-30 10:10:09 | ~42 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | 59e196dc | #34 | 2024-06-03 10:04:59 | ~59 sec | tests |
:page_facing_up:log |
| :heavy_check_mark: | 59e196dcf73215e16ebd8f768b98a11a2d11c992 | #34 | 2024-06-03 10:07:17 | ~3 min | android |
:package:aar |
| :heavy_check_mark: | 59e196dcf73215e16ebd8f768b98a11a2d11c992 | #34 | 2024-06-03 10:07:30 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | 59e196dcf73215e16ebd8f768b98a11a2d11c992 | #34 | 2024-06-03 10:07:35 | ~3 min | ios |
:package:zip |
| :heavy_multiplication_x: | 817e959e | #35 | 2024-06-05 11:08:45 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 817e959ee9b7514bbc01f205addceabc07569cff | #35 | 2024-06-05 11:09:58 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 817e959ee9b7514bbc01f205addceabc07569cff | #35 | 2024-06-05 11:10:50 | ~4 min | linux |
:package:zip |
| :heavy_check_mark: | 817e959ee9b7514bbc01f205addceabc07569cff | #35 | 2024-06-05 11:14:38 | ~8 min | android |
:package:aar |
| :heavy_check_mark: | ca9b04bf5e81df739e322f901d564fb2a16885dd | #36 | 2024-06-05 11:26:42 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | ca9b04bf5e81df739e322f901d564fb2a16885dd | #36 | 2024-06-05 11:26:45 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | ca9b04bf5e81df739e322f901d564fb2a16885dd | #36 | 2024-06-05 11:28:13 | ~4 min | ios |
:package:zip |
| :heavy_multiplication_x: | ca9b04bf | #36 | 2024-06-05 11:29:49 | ~5 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | ca9b04bf | #37 | 2024-06-05 11:49:04 | ~4 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 818c39de58ab3c3513ef3a94d8e4dad5c12212a0 | #37 | 2024-06-05 14:11:10 | ~3 min | android |
:package:aar |
| :heavy_check_mark: | 818c39de58ab3c3513ef3a94d8e4dad5c12212a0 | #37 | 2024-06-05 14:11:35 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 818c39de58ab3c3513ef3a94d8e4dad5c12212a0 | #37 | 2024-06-05 14:11:50 | ~3 min | linux |
:package:zip |
| :heavy_multiplication_x: | 818c39de | #38 | 2024-06-05 14:13:43 | ~5 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 1ffd20a4a2ef909ef367a96403344fc5bdc096c4 | #38 | 2024-06-05 15:08:08 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 1ffd20a4a2ef909ef367a96403344fc5bdc096c4 | #38 | 2024-06-05 15:08:32 | ~3 min | android |
:package:aar |
| :heavy_check_mark: | 1ffd20a4a2ef909ef367a96403344fc5bdc096c4 | #38 | 2024-06-05 15:08:56 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 1ffd20a4 | #39 | 2024-06-05 15:46:44 | ~41 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | fde4e11a | #40 | 2024-06-07 10:44:22 | ~50 sec | tests |
:page_facing_up:log |
| :heavy_check_mark: | fde4e11a7b817a2b2dd306562623e41add3acba9 | #39 | 2024-06-07 10:46:05 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | fde4e11a7b817a2b2dd306562623e41add3acba9 | #39 | 2024-06-07 10:46:18 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | fde4e11a7b817a2b2dd306562623e41add3acba9 | #39 | 2024-06-07 10:47:13 | ~3 min | ios |
:package:zip |
| :heavy_multiplication_x: | c95256b0 | #41 | 2024-06-07 10:48:12 | ~1 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | c95256b0b0f248e3032430c39a26889bd8134513 | #40 | 2024-06-07 10:48:55 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | c95256b0b0f248e3032430c39a26889bd8134513 | #40 | 2024-06-07 10:50:19 | ~3 min | linux |
:package:zip |
| :heavy_check_mark: | c95256b0b0f248e3032430c39a26889bd8134513 | #40 | 2024-06-07 10:50:20 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | ea0ed084422b87cbf1254945365ac9041fd49c27 | #41 | 2024-06-07 10:51:34 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | ea0ed084422b87cbf1254945365ac9041fd49c27 | #41 | 2024-06-07 10:52:43 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | ea0ed084422b87cbf1254945365ac9041fd49c27 | #41 | 2024-06-07 10:53:34 | ~2 min | ios |
:package:zip |
| :heavy_multiplication_x: | ea0ed084 | #42 | 2024-06-07 10:52:30 | ~2 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 3f16ca72b9c8a54be4b1cc9b92e69a66c9b0daab | #42 | 2024-06-07 10:59:38 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 3f16ca72b9c8a54be4b1cc9b92e69a66c9b0daab | #42 | 2024-06-07 10:59:48 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | 3f16ca72b9c8a54be4b1cc9b92e69a66c9b0daab | #42 | 2024-06-07 11:02:36 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | 3f16ca72 | #43 | 2024-06-07 11:40:40 | ~43 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | d7f767d217f02e7f67b04131845129f7dc188c50 | #43 | 2024-06-11 10:02:53 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | d7f767d217f02e7f67b04131845129f7dc188c50 | #43 | 2024-06-11 10:04:06 | ~4 min | ios |
:package:zip |
| :heavy_check_mark: | d7f767d217f02e7f67b04131845129f7dc188c50 | #43 | 2024-06-11 10:05:29 | ~5 min | android |
:package:aar |
| :heavy_check_mark: | 03b8e4aad104f548181a0b796d5901f75fe722ab | #44 | 2024-06-11 10:05:50 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | 03b8e4aad104f548181a0b796d5901f75fe722ab | #44 | 2024-06-11 10:07:26 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | 03b8e4aad104f548181a0b796d5901f75fe722ab | #44 | 2024-06-11 10:08:15 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | d7f767d2 | #44 | 2024-06-11 10:42:41 | ~42 min | tests |
:page_facing_up:log |
| :heavy_multiplication_x: | 03b8e4aa | #45 | 2024-06-11 10:46:11 | ~3 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | e21dc8b77a4a631913e1afd2fde3244cc629f56e | #45 | 2024-06-11 11:02:47 | ~1 min | android |
:package:aar |
| :heavy_check_mark: | e21dc8b77a4a631913e1afd2fde3244cc629f56e | #45 | 2024-06-11 11:03:51 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | e21dc8b77a4a631913e1afd2fde3244cc629f56e | #45 | 2024-06-11 11:05:35 | ~4 min | linux |
:package:zip |
| :heavy_check_mark: | e21dc8b7 | #46 | 2024-06-11 11:41:48 | ~40 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | d08687cd9d483b0392597adfe8b28a6b93923fb4 | #46 | 2024-06-12 11:57:52 | ~2 min | android |
:package:aar |
| :heavy_check_mark: | d08687cd9d483b0392597adfe8b28a6b93923fb4 | #46 | 2024-06-12 11:57:59 | ~2 min | linux |
:package:zip |
| :heavy_check_mark: | d08687cd9d483b0392597adfe8b28a6b93923fb4 | #46 | 2024-06-12 11:58:39 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | d08687cd | #47 | 2024-06-12 12:36:41 | ~41 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | fe728113b4cbd74282293b290f1ce55e0422e376 | #47 | 2024-06-13 13:09:40 | ~2 min | ios |
:package:zip |
| :heavy_check_mark: | fe728113b4cbd74282293b290f1ce55e0422e376 | #47 | 2024-06-13 13:14:34 | ~7 min | android |
:package:aar |
| :heavy_check_mark: | fe728113b4cbd74282293b290f1ce55e0422e376 | #47 | 2024-06-13 13:14:44 | ~7 min | linux |
:package:zip |
| :heavy_check_mark: | fd41493d1ef23dfed73c6ae4fcfb1b0ebd403b62 | #48 | 2024-06-13 13:13:13 | ~3 min | ios |
:package:zip |
| :heavy_multiplication_x: | fe728113 | #48 | 2024-06-13 13:16:32 | ~9 min | tests |
:page_facing_up:log |
| :heavy_check_mark: | 3ff4be0a128e0d865c89981eb98f524af83a0678 | #49 | 2024-06-13 13:16:41 | ~3 min | ios |
:package:zip |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | e7f63f317d6f7ba131e49536058e78b606561d1f | #48 | 2024-06-13 13:19:06 | ~4 min | android |
:package:aar |
| :heavy_check_mark: | e7f63f317d6f7ba131e49536058e78b606561d1f | #50 | 2024-06-13 13:20:07 | ~3 min | ios |
:package:zip |
| :heavy_check_mark: | e7f63f317d6f7ba131e49536058e78b606561d1f | #48 | 2024-06-13 13:22:02 | ~7 min | linux |
:package:zip |
| :heavy_check_mark: | e7f63f31 | #49 | 2024-06-13 14:02:10 | ~45 min | tests |
:page_facing_up:log |
After some looking on FilterManager, it appears that it's too complicated. Since the logic for setting specific peers has been removed in favour of automatic selection, i don't actually see any need to maintain any knowledge about particular peers on FilterManager level. Also, maintaining
MinPeersForFilterconnections for each filter is also out of status-go's purview, i think. Let go-waku handle that.
Ideally such functionality should be part of the SDK layer, it could be a thin layer above the actual Filter implementation in go-waku. Would not recommend adding it to the Filter code in go-waku as it has become too complicated.
Wrt MinPeersForFilter, status-go should specify the count for it as the idea is for users for Filter to be able to specify and choose based on the use-case. Alternatively, we could always set the default to 2(which is what was being used by status-go).
@chaitanyaprem regarding MinPeersForFilter - i think @kaichaosun raised a similar point. Just to reiterate - if i understand correctly, using WithMaxPeersPerContentFilter will return a slice of subscriptions, and i'd rather have a single sub in status-go. In the issue description above item #2 plans to address that, i think. Please correct me if my understanding is wrong.
This, i think, implies, that the notion of Subscription for status-go should only encompass its channel C. Current SubscriptionDetails has extra exported fields that status-go shouldn't know about.
@chaitanyaprem regarding
MinPeersForFilter- i think @kaichaosun raised a similar point. Just to reiterate - if i understand correctly, usingWithMaxPeersPerContentFilterwill return a slice of subscriptions, and i'd rather have a single sub in status-go. In the issue description above item #2 plans to address that, i think. Please correct me if my understanding is wrong.
Hmm, interesting point. Haven't thought about it this way, but kind of makes sense to have SDK abstract this from status-go. Have to think a little more if this brings any unnecessary complexities. cc @richard-ramos WDYT?
Indeed, having a single subscription would make sense for status-go, since it makes dealing with multiple peers something simpler. Like @chaitanyaprem , i think this should go a layer above the actual filter protocol implementation, since that's 'raw' protocol usage, and it's code in this moment is somewhat complex, while a separate abstraction could help make its usage to be more palatable, while offering an API that would make sense for status-go.
When testing this PR in status-mobile a PeerExchange problem was uncovered: https://github.com/status-im/status-mobile/pull/18769#issuecomment-1936038794. Debugging/troubleshooting notes here: https://github.com/status-im/status-mobile/pull/18769#issuecomment-1936053739.
LGTM
Can be merged once waku-org/go-waku#1048 is ready and CI errors are addressed.
@vitvly the relevant go-waku PR has been merged. This also can be merged once CI errors are addressed. We can test Filter in CI for any issues.
@vitvly Since i started working on optimizing Filter pings, i had noticed few more issues/enhancements that are required for Filter Management to effectively function. I am making those changes as part of https://github.com/waku-org/go-waku/pull/1102
I would suggest to wait for this PR to be completed and then we can use that version to run tests.
Waiting for https://github.com/status-im/status-go/pull/5213 to get merged as the Filter Test seems to be failing which can be fixed by this PR. Once the above PR is merged, then will retest Filter test to confirm there are no issues and then initiate dogfooding for this PR.
@richard-ramos I had noticed you haven't taken a look at the updated PR. Please review and add any comments.
Disabled pxClient for now as that is causing issues. This is being tracked as part of https://github.com/status-im/status-go/issues/5344 so that we can enable it again in lightClients.
Merging this PR as it has passed mobile e2e tests and also manual test with some observations which should not be related to filter.
Ref status-mobile PR : https://github.com/status-im/status-mobile/pull/20369