status-go icon indicating copy to clipboard operation
status-go copied to clipboard

bug: Filter subscribe and unsubscribe seem to happen out of order

Open chaitanyaprem opened this issue 1 year ago • 3 comments

Problem

Filter unsubscribe and subscribe happened out of order causing status-mobile to think it is subscribed to filter where as Fleet node thinks subscription is unsubscribed. Reference discussion here

Acceptance Criteria

Where-ever there is Filter unsubscribe and subscribe, these should happen in sequence.

chaitanyaprem avatar Feb 01 '24 05:02 chaitanyaprem

Coding a PR for this - this will ensure that filter requests for each particular filter are not out-of-order.

vitvly avatar Feb 01 '24 08:02 vitvly

Coding a PR for this - this will ensure that filter requests for each particular filter are not out-of-order.

Thanks! Just wanted to track this separately as the original issue was becoming hard to track conversations.

chaitanyaprem avatar Feb 01 '24 09:02 chaitanyaprem

One possible case for the scenario described here is that when a peer ping failed, unsubscribes and subscribes were scheduled, but for some reason subscribe succeeded to the same peer that previously failed (e.g. intermittent network failure).

vitvly avatar Feb 01 '24 10:02 vitvly