status-go icon indicating copy to clipboard operation
status-go copied to clipboard

Remove vendored Whisper and any remain usages

Open Samyoul opened this issue 4 years ago • 2 comments

Problem

vendor/github.com/status-im/status-go/whisper/ exists and so does whisper .

If we have a dedicated package in the repo we don't need whisper to also be vendored.

Implementation

Remove the vendor code for Whisper. Remove any remaining usages or references to the vendored package in favour of the repo package.

Acceptance Criteria

Implement the above implementation without introducing any breaking changes.

Future Steps

We probably will want to review all of the vendored packages at some point, but there is a mega load, so may not rank highly in terms of priorities.

Samyoul avatar May 13 '20 15:05 Samyoul

whisper is not in vendor anymore. close?

There is one remaining self referencing vendor module for extkeys.

felixboehm avatar Jul 12 '21 12:07 felixboehm

Hi @Samyoul can I take up this issue? I'm interested in the status.im project

jonathanalvares9009 avatar Aug 16 '21 08:08 jonathanalvares9009

It looks like it has already been resolved

Azanul avatar Oct 03 '23 04:10 Azanul