status-desktop
status-desktop copied to clipboard
status-im
chore(@desktop/general): min height increased to 800px
Mainly because of the height of some keycard flows we have to increase the min app height so those flows do not look cut.
Example for the factory reset flow before, min app height 680:
Now, min app height 800px:
Jenkins Builds
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | a484d9de | #1 | 2022-10-13 07:38:56 | ~4 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | a484d9de | #1 | 2022-10-13 07:46:20 | ~12 min | linux |
:package:tgz |
| :interrobang: | a484d9de | #1 | 2022-10-13 07:46:37 | ~12 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | a484d9de | #1 | 2022-10-13 07:49:07 | ~15 min | macos |
:package:dmg |
| :heavy_check_mark: | a484d9de | #1 | 2022-10-13 07:56:11 | ~22 min | windows |
:package:exe |
spacings in this modal could be reduced by at least half
That affects all keycard flows, all popups.
This is something as you say we definitely need to check with the design team.
For the reference, here you can see all flows which are displayed in a popup and size of each popup for each state: https://www.figma.com/file/idUoxN7OIW2Jpp3PMJ1Rl8/%E2%9A%99%EF%B8%8F-Settings-%7C-Desktop?node-id=199%3A2653
If the spacing is non-negotiable, the modal by default, becomes scrollable. StatusModal has been designed for this.
