status-desktop
status-desktop copied to clipboard
status-im
fix(AppMain): only show banner when disconnected
Closes #7416
What does the PR do
Banners: only show banner when disconnected
Affected areas
Banners
Jenkins Builds
Click to see older builds (26)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | d924ba11 | #1 | 2022-10-04 16:44:49 | ~4 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | d924ba11 | #1 | 2022-10-04 16:51:12 | ~10 min | linux |
:package:tgz |
| :interrobang: | d924ba11 | #1 | 2022-10-04 16:53:58 | ~13 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | d924ba11 | #1 | 2022-10-04 16:54:22 | ~13 min | macos |
:package:dmg |
| :heavy_check_mark: | d924ba11 | #1 | 2022-10-04 17:01:33 | ~21 min | windows |
:package:exe |
| :heavy_check_mark: | ec375b5a | #2 | 2022-10-05 13:35:03 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | ec375b5a | #2 | 2022-10-05 13:41:41 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | ec375b5a | #2 | 2022-10-05 13:42:03 | ~12 min | macos |
:package:dmg |
| :interrobang: | ec375b5a | #2 | 2022-10-05 13:44:20 | ~14 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | ec375b5a | #2 | 2022-10-05 13:50:57 | ~21 min | windows |
:package:exe |
| :heavy_check_mark: | 9f5e440a | #3 | 2022-10-07 17:16:14 | ~4 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 9f5e440a | #3 | 2022-10-07 17:23:05 | ~11 min | macos |
:package:dmg |
| :heavy_check_mark: | 9f5e440a | #3 | 2022-10-07 17:23:27 | ~11 min | linux |
:package:tgz |
| :interrobang: | 9f5e440a | #3 | 2022-10-07 17:25:31 | ~13 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 9f5e440a | #3 | 2022-10-07 17:32:05 | ~20 min | windows |
:package:exe |
| :heavy_check_mark: | dacecae6 | #4 | 2022-10-18 15:39:53 | ~6 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | dacecae6 | #4 | 2022-10-18 15:47:28 | ~13 min | linux |
:package:tgz |
| :x: | dacecae6 | #4 | 2022-10-18 15:50:25 | ~16 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | dacecae6 | #4 | 2022-10-18 15:50:56 | ~17 min | macos |
:package:dmg |
| :heavy_check_mark: | dacecae6 | #4 | 2022-10-18 15:55:56 | ~22 min | windows |
:package:exe |
| :x: | dacecae6 | #5 | 2022-10-19 12:14:08 | ~15 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 8711964e | #5 | 2022-10-20 14:46:15 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 8711964e | #5 | 2022-10-20 14:52:54 | ~12 min | linux |
:package:tgz |
| :heavy_check_mark: | 8711964e | #5 | 2022-10-20 14:55:03 | ~14 min | macos |
:package:dmg |
| :heavy_check_mark: | 8711964e | #5 | 2022-10-20 15:01:29 | ~20 min | windows |
:package:exe |
| :interrobang: | 8711964e | #6 | 2022-10-20 15:19:11 | ~20 min | e2e |
:page_facing_up:log |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 527ba5d6 | #6 | 2022-10-24 11:50:35 | ~4 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 527ba5d6 | #6 | 2022-10-24 11:57:40 | ~12 min | linux |
:package:tgz |
| :heavy_check_mark: | 527ba5d6 | #6 | 2022-10-24 12:03:46 | ~18 min | macos |
:package:dmg |
| :heavy_check_mark: | 527ba5d6 | #6 | 2022-10-24 12:08:42 | ~23 min | windows |
:package:exe |
| :x: | 527ba5d6 | #7 | 2022-10-24 12:22:59 | ~18 min | e2e |
:page_facing_up:log |
| :x: | 527ba5d6 | #8 | 2022-10-24 15:18:51 | ~19 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 47c1aac7 | #7 | 2022-10-25 08:17:01 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 47c1aac7 | #7 | 2022-10-25 08:23:51 | ~12 min | linux |
:package:tgz |
| :heavy_check_mark: | 47c1aac7 | #7 | 2022-10-25 08:25:54 | ~14 min | macos |
:package:dmg |
| :interrobang: | 47c1aac7 | #9 | 2022-10-25 08:27:42 | ~16 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 47c1aac7 | #7 | 2022-10-25 08:32:48 | ~21 min | windows |
:package:exe |
I think this will break:
* the autohiding when the user comes back online * it will still say "Disconnected" even when online
you're right! added back the check, if it's connected to hide.
I might be wrong, but I thought we agreed that: the banner shouldn't show "Connected" at startup, BUT it should change to green "connected" when the connection is restored.
@igor-sirotin not sure what you mean, the banner will be shown when readonly property bool isConnected: mainModule.isOnline is changed to true, not on startup
We agreed with @alexandraB99 that there should still be "Connected" banner, we just don't want to see it at application startup 🙂
@igor-sirotin changed it as agreed, however I am not sure this is the correct variable to set to true as I can still see it on startup but I will check this further. Marking as do not merge for now
@alexandraB99 I still can see the banner 'Connected' on the startup. After disconnecting and connecting again, the banner doesn't appear. Could you kindly check?
@elina2015, @micieslak "After disconnecting and connecting again, the banner doesn't appear." -> this is not a result of this PR, it also happens in master. @igor-sirotin setting isConnected to true in nim didn't have any affect as it seems that local isConnected property was false until Component initialization. this solution seems working fine.