status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

Published 20 hours ago • verified publisher icon status-im

fix(CreateChatView): fixed tagselector various issues

Open alexandraB99 opened this issue 2 years ago • 5 comments

Closes #7340

What does the PR do

CreateChatView fixed tagselector various issues

Affected areas

CreateChatView

StatusQ checklist

  • [ ] add documentation if necessary (new component, new feature)
  • [ ] update sandbox app
    • in case of new component, add new component page
    • in case of new features, add variation to existing component page
    • nice to have: add it to the demo application as well
  • [ ] test changes in both light and dark theme?

Screenshot of functionality (including design for comparison)

https://user-images.githubusercontent.com/31625338/194599748-cec9ffff-87c2-4b94-a046-5876fe839883.mov

https://user-images.githubusercontent.com/31625338/194599756-1729e3eb-b4e9-4adf-8863-4d8783cf070c.mov

https://user-images.githubusercontent.com/31625338/194599782-61b00742-9b8f-4d8b-82f3-335f1d8c03b3.mov

https://user-images.githubusercontent.com/31625338/194599793-c58aeae5-8607-4e98-b8b4-58a359b1b6bb.mov

alexandraB99 avatar Sep 29 '22 15:09 alexandraB99

Jenkins Builds

Click to see older builds (57)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: a3426974 #1 2022-09-29 15:48:26 ~5 min linux-cpp :package:pkg
:heavy_check_mark: a3426974 #1 2022-09-29 15:52:30 ~9 min macos :package:dmg
:heavy_check_mark: a3426974 #1 2022-09-29 15:54:28 ~11 min linux :package:tgz
:heavy_check_mark: a3426974 #1 2022-09-29 16:07:13 ~23 min windows :package:exe
:interrobang: a3426974 #1 2022-09-29 16:23:38 ~40 min e2e :page_facing_up:log
:heavy_check_mark: 83f74732 #2 2022-10-07 15:50:20 ~5 min linux-cpp :package:pkg
:heavy_check_mark: 83f74732 #2 2022-10-07 15:54:10 ~9 min macos :package:dmg
:heavy_check_mark: 83f74732 #2 2022-10-07 15:56:07 ~11 min linux :package:tgz
:heavy_check_mark: 83f74732 #2 2022-10-07 16:05:19 ~20 min windows :package:exe
:heavy_check_mark: 3e9a28ff #3 2022-10-07 16:17:39 ~5 min linux-cpp :package:pkg
:heavy_check_mark: 3e9a28ff #3 2022-10-07 16:21:03 ~8 min macos :package:dmg
:heavy_check_mark: 3e9a28ff #3 2022-10-07 16:23:20 ~11 min linux :package:tgz
:x: 3e9a28ff #2 2022-10-07 16:34:35 ~13 min e2e :page_facing_up:log
:heavy_check_mark: 3e9a28ff #3 2022-10-07 16:35:27 ~23 min windows :package:exe
:x: 3e9a28ff #3 2022-10-12 15:38:20 ~15 min e2e :page_facing_up:log
:heavy_check_mark: d215e1cc #4 2022-10-18 15:46:14 ~6 min linux-cpp :package:pkg
:heavy_check_mark: d215e1cc #4 2022-10-18 15:54:27 ~15 min macos :package:dmg
:heavy_check_mark: d215e1cc #4 2022-10-18 15:54:43 ~15 min linux :package:tgz
:heavy_check_mark: d215e1cc #4 2022-10-18 16:02:36 ~23 min windows :package:exe
:x: d215e1cc #4 2022-10-18 16:04:48 ~14 min e2e :page_facing_up:log
:interrobang: d215e1cc #5 2022-10-19 12:28:23 ~14 min e2e :page_facing_up:log
:heavy_check_mark: 91287fd5 #5 2022-10-24 14:16:23 ~6 min linux-cpp :package:pkg
:heavy_check_mark: 91287fd5 #5 2022-10-24 14:19:22 ~9 min macos :package:dmg
:heavy_check_mark: 91287fd5 #5 2022-10-24 14:23:53 ~13 min linux :package:tgz
:heavy_check_mark: 91287fd5 #5 2022-10-24 14:34:33 ~24 min windows :package:exe
:x: 91287fd5 #6 2022-10-24 14:36:31 ~26 min e2e :page_facing_up:log
:heavy_check_mark: f8afe93b #6 2022-10-25 11:30:10 ~6 min linux-cpp :package:pkg
:heavy_check_mark: f8afe93b #6 2022-10-25 11:34:20 ~10 min macos :package:dmg
:heavy_check_mark: f8afe93b #6 2022-10-25 11:36:12 ~12 min linux :package:tgz
:x: f8afe93b #7 2022-10-25 11:41:13 ~17 min e2e :page_facing_up:log
:heavy_check_mark: f8afe93b #6 2022-10-25 11:47:58 ~24 min windows :package:exe
:heavy_check_mark: 09d496f5 #7 2022-10-25 15:04:15 ~5 min linux-cpp :package:pkg
:heavy_check_mark: 09d496f5 #7 2022-10-25 15:12:25 ~13 min linux :package:tgz
:heavy_check_mark: 09d496f5 #7 2022-10-25 15:12:43 ~13 min macos :package:dmg
:heavy_check_mark: 09d496f5 #7 2022-10-25 15:24:10 ~24 min windows :package:exe
:interrobang: 09d496f5 #8 2022-10-25 16:30:24 ~20 min e2e :page_facing_up:log
:heavy_check_mark: 93a47238 #8 2022-10-27 14:36:41 ~12 min linux-cpp :package:pkg
:heavy_check_mark: 93a47238 #8 2022-10-27 14:40:38 ~16 min macos :package:dmg
:heavy_check_mark: 93a47238 #8 2022-10-27 14:45:50 ~22 min windows :package:exe
:heavy_check_mark: 93a47238 #8 2022-10-27 14:48:13 ~24 min linux :package:tgz
:heavy_check_mark: 2f28c3be #9 2022-11-07 15:12:34 ~6 min linux-cpp :package:pkg
:interrobang: 2f28c3be #1 2022-11-07 15:15:46 ~9 min imports :page_facing_up:log
:heavy_check_mark: 2f28c3be #9 2022-11-07 15:16:38 ~10 min macos :package:dmg
:heavy_check_mark: 2f28c3be #9 2022-11-07 15:20:05 ~14 min linux :package:tgz
:heavy_check_mark: 2f28c3be #9 2022-11-07 15:29:11 ~23 min windows :package:exe
:x: 2f28c3be #10 2022-11-07 15:53:36 ~28 min e2e :page_facing_up:log
:heavy_check_mark: 0f7867d4 #10 2022-11-11 11:35:24 ~51 sec linux-cpp :package:pkg
:interrobang: 0f7867d4 #2 2022-11-11 11:39:46 ~5 min imports :page_facing_up:log
:heavy_check_mark: 0f7867d4 #10 2022-11-11 11:47:10 ~12 min macos :package:dmg
:heavy_check_mark: 0f7867d4 #10 2022-11-11 11:52:07 ~17 min linux :package:tgz
:x: 0f7867d4 #11 2022-11-11 11:56:08 ~21 min e2e :page_facing_up:log
:interrobang: c99cdddd #3 2022-11-11 13:15:43 ~4 min imports :page_facing_up:log
:heavy_check_mark: c99cdddd #11 2022-11-11 13:15:54 ~4 min linux-cpp :package:pkg
:heavy_check_mark: c99cdddd #11 2022-11-11 13:21:42 ~10 min linux :package:tgz
:heavy_check_mark: c99cdddd #11 2022-11-11 13:29:42 ~18 min windows :package:exe
:heavy_check_mark: c99cdddd #11 2022-11-11 13:31:04 ~19 min macos :package:dmg
:interrobang: c99cdddd #12 2022-11-11 13:42:11 ~16 min e2e :page_facing_up:log
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:x: cb90d117 #12 2022-11-11 16:00:59 ~2 min macos :page_facing_up:log
:heavy_check_mark: cb90d117 #12 2022-11-11 16:03:18 ~4 min linux-cpp :package:pkg
:interrobang: cb90d117 #4 2022-11-11 16:03:43 ~5 min imports :page_facing_up:log
:heavy_check_mark: cb90d117 #12 2022-11-11 16:10:23 ~11 min linux :package:tgz
:heavy_check_mark: cb90d117 #12 2022-11-11 16:16:21 ~17 min windows :package:exe
:interrobang: cb90d117 #13 2022-11-11 16:16:53 ~18 min e2e :page_facing_up:log
:heavy_check_mark: cb90d117 #13 2022-11-11 19:14:26 ~6 min macos :package:dmg
:heavy_check_mark: 75f85a92 #13 2022-11-14 10:48:51 ~2 min linux-cpp :package:pkg
:interrobang: 75f85a92 #5 2022-11-14 10:50:34 ~4 min imports :page_facing_up:log
:heavy_check_mark: 75f85a92 #14 2022-11-14 11:05:59 ~19 min macos :package:dmg
:interrobang: 75f85a92 #14 2022-11-14 11:34:56 ~15 min e2e :page_facing_up:log
:x: 75f85a92 #14 2022-11-14 13:12:35 ~13 min linux :page_facing_up:log
:heavy_check_mark: 75f85a92 #15 2022-11-14 14:44:38 ~13 min linux :package:tgz

status-im-auto avatar Sep 29 '22 15:09 status-im-auto

Issues found

1. OPEN Only 19 users (including admin) can be added to group

Expected: 20 users can be added

2. OPEN (OBSERVATION) Can only scroll with trackpad when hovering over scrollbar

When the pointer is over a pill it is not possible to scroll

3. OPEN (OBSERVATION) Scrollbar has been moved within the input field instead of on the edge

This means it now overlaps with the user pills Before 2022-09-08_20-02-39 (1)

After image

4. OPEN When 4 users pills are added the left margin increases

image

5. OPEN Admin pill can be removed with backspace

image

6. OPEN Clicking on confirm adds a contact instead of creating group chat

https://user-images.githubusercontent.com/50769329/193350291-fa62e113-79e7-4593-83fc-f4cd626367ce.mp4

7. OPEN (OBSERVATION) On resize, scrollbar does not adjust until in focus

https://user-images.githubusercontent.com/50769329/193351065-5c28f7cc-92d2-4d6a-9cd3-dfb37c60e096.mp4

glitchminer avatar Sep 30 '22 20:09 glitchminer

Apart from all issues @glitchminer listed, another issue still remaining: it is not possible to use arrow keys to navigate between members.

@noeliaSD I've replied this in the issue, this is not a regression, it was never supported. I would see it more like a feature, nevertheless we need to think if we really want to add it because the tags currently are not part of the input thus the cursor cannot just go inside those. It would need bigger effort to be fixed.

alexandraB99 avatar Oct 03 '22 14:10 alexandraB99

@glitchminer updated, please have a look :) @osmaczko same

alexandraB99 avatar Oct 07 '22 16:10 alexandraB99

@osmaczko wanna have a second look?

alexandraB99 avatar Oct 19 '22 11:10 alexandraB99

@osmaczko wanna have a second look?

Done a quick run, there is an issue of disappearing first member (ourselves) when rejected, see:

https://user-images.githubusercontent.com/33099791/196952055-0fb1fbd9-c3cf-4a4a-887c-8195168dcfc1.mp4

@glitchminer could you please have a second look as well?

osmaczko avatar Oct 20 '22 12:10 osmaczko

Sorry for firing one issue at a time. Right now I can't create a group chat (on master it works). Could you please check? create-group-chat-2022-10-24_16.53.33.mp4

@osmaczko fixed!

alexandraB99 avatar Oct 25 '22 11:10 alexandraB99

There is the squish test suite_messaging/tst_groupChat which validates the creation of a group chat and suite_messaging/tst_adminGroupChat which edits a created group chat. They are disabled in the CI because they rely on the mailserver and are weak so we still need to work in the test environment to enable them there, but I encourage you to try them locally to check if everything is correct. If you need help checking it out, I can help!

noeliaSD avatar Oct 26 '22 08:10 noeliaSD

There is the squish test suite_messaging/tst_groupChat which validates the creation of a group chat and suite_messaging/tst_adminGroupChat which edits a created group chat. They are disabled in the CI because they rely on the mailserver and are weak so we still need to work in the test environment to enable them there, but I encourage you to try them locally to check if everything is correct. If you need help checking it out, I can help!

Tested locally and all good!!

noeliaSD avatar Oct 26 '22 14:10 noeliaSD

https://user-images.githubusercontent.com/33099791/198271083-a975c01b-7798-4402-968b-619b8dfdcced.mp4

https://user-images.githubusercontent.com/33099791/198271438-21674432-52ff-4901-a46a-7fb5eb84aeac.mp4

osmaczko avatar Oct 27 '22 11:10 osmaczko

@osmaczko what do you mean with 2? what should be confirmed exactly in this case? a chat to ourselves?

alexandraB99 avatar Oct 27 '22 11:10 alexandraB99

@osmaczko what do you mean with 2? what should be confirmed exactly in this case? a chat to ourselves?

Admin should be able to remove everyone from the group

osmaczko avatar Oct 27 '22 11:10 osmaczko

@osmaczko all fixed! :)

alexandraB99 avatar Oct 27 '22 14:10 alexandraB99

:heavy_check_mark: status-desktop/branches/uitests/PR-7668#9 :small_blue_diamond: ~21 min :small_blue_diamond: 93a47238 :small_blue_diamond: :package: e2e package

status-im-auto avatar Oct 27 '22 15:10 status-im-auto

Hey @alexandraB99, the "king pill" for the current user appears to be missing altogether still.

image

Build: StatusIm-Desktop-221107-150606-2f28c3-pr7668.dmg

glitchminer avatar Nov 08 '22 22:11 glitchminer

Issues

1. Backspace key cannot be used to remove first pill image

2. Formatting when typing after typing when max reached image

3. Max number of members is now 21 (contacts + self)

image

4. Not possible to scroll after adding max contacts then resizing 2022-11-10_11-53-47.mp4

5. Formatting when pasting key/url to add new contact image

6. "King pill" still shown when editing group image

  1. fixed
  2. fixed
  3. fixed
  4. can't reproduce
  5. fixed
  6. this is ok, we still show the king pill when editing the group

alexandraB99 avatar Nov 11 '22 11:11 alexandraB99

  1. CLOSED/FIXED.
  2. CLOSED/FIXED
  3. CLOSED 22 members added instead of 20 image
  4. OPEN/CANT REPRODUCE
  5. CLOSED/FIXED
  6. CLOSED/NA
  7. TO BE MOVED On edit members - resize width smaller when max contacts reached image
  8. CLOSED Flicker when scrolling

https://user-images.githubusercontent.com/50769329/201339460-5d5369e1-652f-4a42-8fcb-86609ecff929.mp4

  1. CLOSED Cannot confirm members when only 1 contact added image
  2. CLOSED/FIXED Message limit on edit members is not 20 image

glitchminer avatar Nov 11 '22 12:11 glitchminer

  1. CLOSED/FIXED.

    1. CLOSED/FIXED

    2. OPEN 22 members added instead of 20 image

    3. OPEN/CANT REPRODUCE

    4. CLOSED/FIXED

    5. CLOSED/NA

    6. OPEN On edit members - resize width smaller when max contacts reached image

    7. OPEN Flicker when scrolling

2022-11-11_12-06-24.mp4

9. OPEN Cannot confirm members when only 1 contact added
   ![image](https://user-images.githubusercontent.com/50769329/201339559-2b28c88c-b51e-494c-8c2e-22f6827bcbe3.png)

3 fixed 7 this needs design input as when the members list is opened and we open to edit the members the available space for group chat edit is reduced. can we take this to a dedicated issue? 8 fixed 9 fixed

alexandraB99 avatar Nov 11 '22 13:11 alexandraB99

Hi @alexandraB99 , previous issues resolved. Thanks! 1 new issue added (number 10 here: https://github.com/status-im/status-desktop/pull/7668#issuecomment-1311634224). In edit members the behaviour of the message limit has changed and is not capping at 20 members.

glitchminer avatar Nov 11 '22 15:11 glitchminer

Hi @alexandraB99 , previous issues resolved. Thanks! 1 new issue added (number 10 here: #7668 (comment)). In edit members the behaviour of the message limit has changed and is not capping at 20 members.

fixed! :D

alexandraB99 avatar Nov 11 '22 16:11 alexandraB99