status-desktop
status-desktop copied to clipboard
status-im
fix(SendRequestModal): spacing issues
Closes #6941
What does the PR do
SendRequestModal fixes various spacing issues
Affected areas
SendRequestModal
StatusQ checklist
- [ ] add documentation if necessary (new component, new feature)
- [ ] update sandbox app
- in case of new component, add new component page
- in case of new features, add variation to existing component page
- nice to have: add it to the demo application as well
- [ ] test changes in both light and dark theme?
Screenshot of functionality (including design for comparison)
TBD
Jenkins Builds
Click to see older builds (10)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | a2090c64 | #1 | 2022-09-28 14:31:34 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | a2090c64 | #1 | 2022-09-28 14:36:32 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | a2090c64 | #1 | 2022-09-28 14:37:28 | ~10 min | linux |
:package:tgz |
| :interrobang: | a2090c64 | #1 | 2022-09-28 14:37:31 | ~10 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | a2090c64 | #1 | 2022-09-28 14:51:37 | ~25 min | windows |
:package:exe |
| :heavy_check_mark: | 3980fa1d | #2 | 2022-10-06 14:57:16 | ~4 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 3980fa1d | #2 | 2022-10-06 15:01:31 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | 3980fa1d | #2 | 2022-10-06 15:04:41 | ~12 min | linux |
:package:tgz |
| :interrobang: | 3980fa1d | #2 | 2022-10-06 15:06:06 | ~13 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 3980fa1d | #2 | 2022-10-06 15:15:54 | ~23 min | windows |
:package:exe |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 831b052d | #3 | 2022-10-19 10:51:01 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 831b052d | #3 | 2022-10-19 10:55:22 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | 831b052d | #3 | 2022-10-19 10:59:06 | ~13 min | linux |
:package:tgz |
| :heavy_check_mark: | 831b052d | #3 | 2022-10-19 11:08:15 | ~22 min | windows |
:package:exe |
| :interrobang: | 831b052d | #3 | 2022-10-19 11:10:24 | ~14 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 2443f795 | #4 | 2022-10-24 11:52:17 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | 2443f795 | #4 | 2022-10-24 11:58:10 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 2443f795 | #4 | 2022-10-24 12:03:43 | ~16 min | macos |
:package:dmg |
| :heavy_check_mark: | 2443f795 | #4 | 2022-10-24 12:12:40 | ~25 min | windows |
:package:exe |
| :interrobang: | 2443f795 | #4 | 2022-10-24 12:43:36 | ~20 min | e2e |
:page_facing_up:log |
@alexandraB99 does it really depend on my PR? I think it's worth it standalone as it is, just fix the conflicts and make a screenshot :)
@alexandraB99 hey, thank you for the fixes! There are only small things:
- The name is smaller than it's shown on Design
- The Chat key is smaller than in Design
- The grey line is placed incorrectly
Could you kindly check?
Need small fixes
@elina2015 mentioned issues are fixed. regarding point 5 (Another modal is shown behind the active modal) this will be solved here https://github.com/status-im/status-desktop/pull/7621
@alexandraB99 Thank you, for the fixes. There are only small things:
- Profile picture is bigger than on the Design
- The Message field is bigger
- The space between the message field and the grey line differs from the Design
Could you kindly check? Or we can move it to another ticket.
@elina2015 this was waiting for the profile popup to be merged, please check again, should be good now!
