status-desktop
status-desktop copied to clipboard
status-im
fix(@desktop/wallet): Added squish test for change password and relogin
fixes #6900
What does the PR do
Squish test for user being able to change his password and logging in
Affected areas
Settings
Screenshot of functionality (including design for comparison)
- [x] I've checked the design and this PR matches it
Jenkins Builds
Click to see older builds (14)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :interrobang: | 33957179 | #1 | 2022-08-24 09:58:09 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 33957179 | #1 | 2022-08-24 10:03:29 | ~10 min | macos |
:package:dmg |
| :heavy_check_mark: | 33957179 | #1 | 2022-08-24 10:05:12 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 33957179 | #1 | 2022-08-24 10:17:54 | ~24 min | windows |
:package:exe |
| :x: | 33957179 | #1 | 2022-08-24 10:39:13 | ~45 min | e2e |
:page_facing_up:log |
| :interrobang: | 75f172a2 | #2 | 2022-08-25 10:34:30 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 75f172a2 | #2 | 2022-08-25 10:40:03 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | 75f172a2 | #2 | 2022-08-25 10:41:35 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 75f172a2 | #2 | 2022-08-25 10:56:33 | ~26 min | windows |
:package:exe |
| :x: | 75f172a2 | #2 | 2022-08-25 15:04:18 | ~24 min | e2e |
:page_facing_up:log |
| :interrobang: | 2151677c | #3 | 2022-09-05 10:59:44 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 2151677c | #3 | 2022-09-05 11:04:35 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | 2151677c | #3 | 2022-09-05 11:06:07 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 2151677c | #3 | 2022-09-05 11:20:52 | ~25 min | windows |
:package:exe |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :interrobang: | 28e32e5f | #4 | 2022-09-05 11:54:12 | ~5 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 28e32e5f | #4 | 2022-09-05 11:56:42 | ~7 min | macos |
:package:dmg |
| :heavy_check_mark: | 28e32e5f | #4 | 2022-09-05 12:00:53 | ~12 min | linux |
:package:tgz |
| :heavy_check_mark: | 28e32e5f | #4 | 2022-09-05 12:13:08 | ~24 min | windows |
:package:exe |
| :heavy_check_mark: | ace089c9 | #5 | 2022-09-28 13:25:07 | ~5 min | linux-cpp |
:package:pkg |
| :heavy_check_mark: | ace089c9 | #5 | 2022-09-28 13:33:54 | ~14 min | linux |
:package:tgz |
| :interrobang: | ace089c9 | #4 | 2022-09-28 13:39:49 | ~15 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | ace089c9 | #5 | 2022-09-28 13:43:50 | ~24 min | windows |
:package:exe |
| :heavy_check_mark: | ace089c9 | #5 | 2022-09-28 13:44:21 | ~24 min | macos |
:package:dmg |
Great job! Minor comments added.
I'm trying to run the test on my machine but having an issue bc the OS prompts me with a warning dialog saying that the desktop app is trying to authenticate me.. So then, the squish loses the focus and then it fails. Which permission desktop app is needing to do this action??
Screen.Recording.2022-08-25.at.09.52.55.mov
Hey just to note, this will only occur in case you have saved your password on macOs's keychain? so it shouldnt be something that should affect the normal tests on CI? or do we want to support this use case too? @noeliaSD let me know what you think.
Great job! Minor comments added. I'm trying to run the test on my machine but having an issue bc the OS prompts me with a warning dialog saying that the desktop app is trying to authenticate me.. So then, the squish loses the focus and then it fails. Which permission desktop app is needing to do this action?? Screen.Recording.2022-08-25.at.09.52.55.mov
Hey just to note, this will only occur in case you have saved your password on macOs's keychain? so it shouldnt be something that should affect the normal tests on CI? or do we want to support this use case too? @noeliaSD let me know what you think.
I didn't save the password on macOs's keychain, just only ran the test and it was what happen, that's why I'm surprised with the result :thinking:
Great job! Minor comments added.
I'm trying to run the test on my machine but having an issue bc the OS prompts me with a warning dialog saying that the desktop app is trying to authenticate me.. So then, the squish loses the focus and then it fails. Which permission desktop app is needing to do this action??
Screen.Recording.2022-08-25.at.09.52.55.mov
Iv removed this code in case the user has chosen to not save his password on keychain can someone please test it on macOS? @alaibe do you have mac os
@noeliaSD once you are back can you please test this :) I had the chance to test it and it fails for me
At first glance the real name lookup is too simple and might find a wrong listview https://github.com/stefandunca/status-desktop/blob/38667e06a74691257516630da28370d5c544f0ad/test/ui-test/testSuites/global_shared/scripts/login_names.py#L9
@noeliaSD once you are back can you please test this :)
Tested!!! LGTM! :)