status-desktop
status-desktop copied to clipboard
status-im
test(community): add a test that pins and unpins messages
Fixes #6894
The StatusQ change is just to update to latest StatusQ master
@noeliaSD you're the tester on this PR in case the CI doesn't want to behave
Jenkins Builds
Click to see older builds (14)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | 8ae77624 | #1 | 2022-08-22 21:19:32 | ~6 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 8ae77624 | #1 | 2022-08-22 21:23:57 | ~10 min | linux |
:package:tgz |
| :heavy_check_mark: | 8ae77624 | #1 | 2022-08-22 21:31:13 | ~17 min | macos |
:package:dmg |
| :heavy_check_mark: | 8ae77624 | #1 | 2022-08-22 21:37:19 | ~24 min | windows |
:package:exe |
| :interrobang: | 07536864 | #1 | 2022-08-23 19:32:40 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 07536864 | #2 | 2022-08-23 19:37:28 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | 07536864 | #2 | 2022-08-23 19:39:21 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 07536864 | #2 | 2022-08-23 19:52:07 | ~24 min | windows |
:package:exe |
| :x: | 07536864 | #2 | 2022-08-24 00:29:44 | ~43 min | e2e |
:page_facing_up:log |
| :interrobang: | 142aa751 | #2 | 2022-08-24 20:07:41 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 142aa751 | #3 | 2022-08-24 20:14:32 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 142aa751 | #3 | 2022-08-24 20:16:48 | ~13 min | macos |
:package:dmg |
| :heavy_check_mark: | 142aa751 | #3 | 2022-08-24 20:24:47 | ~21 min | windows |
:package:exe |
| :x: | 142aa751 | #3 | 2022-08-24 20:52:10 | ~49 min | e2e |
:page_facing_up:log |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :interrobang: | 45cbb33e | #3 | 2022-08-25 14:47:15 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 45cbb33e | #4 | 2022-08-25 14:54:28 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 45cbb33e | #4 | 2022-08-25 14:55:13 | ~12 min | macos |
:package:dmg |
| :heavy_check_mark: | 45cbb33e | #4 | 2022-08-25 15:07:14 | ~24 min | windows |
:package:exe |
| :x: | 45cbb33e | #4 | 2022-08-25 17:56:25 | ~48 min | e2e |
:page_facing_up:log |
| :interrobang: | 293cd96c | #4 | 2022-08-26 14:20:07 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 293cd96c | #5 | 2022-08-26 14:25:18 | ~10 min | macos |
:package:dmg |
| :heavy_check_mark: | 293cd96c | #5 | 2022-08-26 14:25:56 | ~10 min | linux |
:package:tgz |
| :heavy_check_mark: | 293cd96c | #5 | 2022-08-26 14:38:20 | ~23 min | windows |
:package:exe |
| :x: | 293cd96c | #5 | 2022-08-26 15:15:28 | ~54 min | e2e |
:page_facing_up:log |
New StatusQ PR: https://github.com/status-im/StatusQ/pull/867
That was my bad, I discarded the StatusQ changes I had, that's why it didn't work for you @noeliaSD
Here the video.. It is curious bc the first run worked but the second one failed, the first time it found the pin button, the second one, no.
@noeliaSD as I see in the video in the second try you didn't get a "on message hover menu" and that's why squish couldn't find it. Do we have handling for such cases like this:
found = search_for_object_name(obj_name)
while not found:
simulate_mouse_move()
wait(100ms)
found = search_for_object_name(obj_name)
if found:
click_the_option_we_want()
Do we have handling for such cases like this:
I have something similar, but I guess it's not resilient enough. I'll improve it to have some retries
@noeliaSD I fixed a bug that was in my mouse move function. I also added 3 retries in case it doesn't find the pin button. Let me know if it works for you now.
Passes on CI :tada: https://ci.status.im/job/status-desktop/job/branches/job/uitests/view/change-requests/job/PR-7119/3/squishResults_220824_200901.631/webreport_220824_200901.631_linux-04/index.html
@noeliaSD as I see in the video in the second try you didn't get a "on message hover menu" and that's why squish couldn't find it. Do we have handling for such cases like this:
We can add something like this in the driver, yes. However, in this case, as @jrainville said, he implemented something similar here!
@noeliaSD I fixed a bug that was in my mouse move function. I also added 3 retries in case it doesn't find the pin button. Let me know if it works for you now.
Still fails. I increased to 10 the retries and same, but now I can see the pin dialog is present and displayed so.. it seems something different (could it be the usage of waitfor instead of find?? not sure, just thinking out loud):
https://user-images.githubusercontent.com/97019400/186593160-a036990d-9198-4d2b-9fb2-b9300e726551.mov
I'm not sure why it does that for you @noeliaSD . I rebased and tried again and it finds the button correctly. Stupid question, but are you sure you ran make run? :grimacing: