status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

setup new keycard

Open saledjenic opened this issue 2 years ago • 1 comments

Corresponding status-go PR:

  • https://github.com/status-im/status-go/pull/2809

Corresponding nim-status-go PR:

  • https://github.com/status-im/nim-status-go/pull/16

saledjenic avatar Aug 16 '22 09:08 saledjenic

Jenkins Builds

Click to see older builds (111)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 5c6ddaf8 #1 2022-08-16 09:41:43 ~8 min macos :package:dmg
:heavy_check_mark: 5c6ddaf8 #1 2022-08-16 09:44:02 ~10 min linux :package:tgz
:heavy_check_mark: 5c6ddaf8 #1 2022-08-16 09:59:15 ~26 min windows :package:exe
:x: 5c6ddaf8 #1 2022-08-16 10:00:52 ~27 min e2e :page_facing_up:log
:heavy_check_mark: dabb65b3 #2 2022-08-16 15:37:04 ~11 min linux :package:tgz
:heavy_check_mark: dabb65b3 #2 2022-08-16 15:41:52 ~15 min macos :package:dmg
:x: dabb65b3 #2 2022-08-16 15:58:11 ~32 min e2e :page_facing_up:log
:heavy_check_mark: dabb65b3 #2 2022-08-16 16:00:49 ~34 min windows :package:exe
:heavy_check_mark: 61a2f483 #3 2022-08-17 06:01:57 ~8 min macos :package:dmg
:heavy_check_mark: 61a2f483 #3 2022-08-17 06:04:36 ~11 min linux :package:tgz
:x: 61a2f483 #3 2022-08-17 06:09:21 ~16 min e2e :page_facing_up:log
:heavy_check_mark: 61a2f483 #3 2022-08-17 06:17:43 ~24 min windows :package:exe
:heavy_check_mark: f218ecac #4 2022-08-18 14:46:57 ~8 min macos :package:dmg
:heavy_check_mark: f218ecac #4 2022-08-18 14:53:42 ~15 min linux :package:tgz
:heavy_check_mark: f218ecac #4 2022-08-18 15:17:16 ~38 min windows :package:exe
:x: f218ecac #4 2022-08-18 15:36:11 ~57 min e2e :page_facing_up:log
:x: 5724142e #5 2022-08-19 06:55:28 ~6 min e2e :page_facing_up:log
:heavy_check_mark: 5724142e #5 2022-08-19 06:57:50 ~8 min macos :package:dmg
:heavy_check_mark: 5724142e #5 2022-08-19 06:59:45 ~10 min linux :package:tgz
:heavy_check_mark: 5724142e #5 2022-08-19 07:13:11 ~24 min windows :package:exe
:x: 0aaf3cad #6 2022-08-19 16:24:42 ~4 min macos :page_facing_up:log
:x: 0aaf3cad #6 2022-08-19 16:24:55 ~5 min e2e :page_facing_up:log
:x: 0aaf3cad #6 2022-08-19 16:25:12 ~5 min linux :page_facing_up:log
:x: 0aaf3cad #6 2022-08-19 16:32:32 ~12 min windows :page_facing_up:log
:x: ac422385 #7 2022-08-23 15:24:00 ~5 min macos :page_facing_up:log
:x: ac422385 #7 2022-08-23 15:24:15 ~5 min linux :page_facing_up:log
:x: ac422385 #7 2022-08-23 15:31:15 ~12 min windows :page_facing_up:log
:x: f71a5132 #8 2022-08-23 15:32:36 ~6 min linux :page_facing_up:log
:x: f71a5132 #8 2022-08-23 15:36:44 ~10 min macos :page_facing_up:log
:x: f71a5132 #8 2022-08-23 15:39:35 ~12 min windows :page_facing_up:log
:x: f71a5132 #7 2022-08-23 16:43:37 ~5 min e2e :page_facing_up:log
:interrobang: 6f2a3f0d #1 2022-08-23 18:55:13 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: 6f2a3f0d #9 2022-08-23 19:00:00 ~9 min macos :package:dmg
:heavy_check_mark: 6f2a3f0d #9 2022-08-23 19:01:10 ~10 min linux :package:tgz
:heavy_check_mark: 6f2a3f0d #9 2022-08-23 19:16:37 ~25 min windows :package:exe
:x: 6f2a3f0d #8 2022-08-23 22:14:26 ~46 min e2e :page_facing_up:log
:interrobang: 6f2a3f0d #2 2022-08-24 12:23:27 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 6f2a3f0d #10 2022-08-24 12:28:05 ~9 min macos :package:dmg
:heavy_check_mark: 6f2a3f0d #10 2022-08-24 12:30:01 ~11 min linux :package:tgz
:heavy_check_mark: 6f2a3f0d #10 2022-08-24 12:44:07 ~25 min windows :package:exe
:x: 6f2a3f0d #9 2022-08-24 13:29:51 ~48 min e2e :page_facing_up:log
:interrobang: 73e81c91 #3 2022-08-25 08:10:12 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 73e81c91 #11 2022-08-25 08:15:48 ~10 min macos :package:dmg
:heavy_check_mark: 73e81c91 #11 2022-08-25 08:16:20 ~11 min linux :package:tgz
:heavy_check_mark: 73e81c91 #11 2022-08-25 08:29:07 ~23 min windows :package:exe
:x: 73e81c91 #10 2022-08-25 08:52:39 ~47 min e2e :page_facing_up:log
:interrobang: a3cc5ccb #4 2022-08-25 10:23:57 ~6 min linux-cpp :page_facing_up:log
:heavy_check_mark: a3cc5ccb #12 2022-08-25 10:28:11 ~10 min macos :package:dmg
:heavy_check_mark: a3cc5ccb #12 2022-08-25 10:30:33 ~12 min linux :package:tgz
:heavy_check_mark: a3cc5ccb #12 2022-08-25 10:44:33 ~26 min windows :package:exe
:x: a3cc5ccb #11 2022-08-25 13:32:11 ~49 min e2e :page_facing_up:log
:interrobang: a552ef54 #5 2022-08-26 08:27:09 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: a552ef54 #13 2022-08-26 08:34:34 ~12 min linux :package:tgz
:heavy_check_mark: a552ef54 #13 2022-08-26 08:38:10 ~15 min macos :package:dmg
:interrobang: d3d1a3f7 #6 2022-08-26 08:31:33 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: d3d1a3f7 #14 2022-08-26 08:38:39 ~11 min macos :package:dmg
:heavy_check_mark: d3d1a3f7 #14 2022-08-26 08:38:55 ~11 min linux :package:tgz
:heavy_check_mark: d3d1a3f7 #14 2022-08-26 08:54:57 ~27 min windows :package:exe
:x: d3d1a3f7 #12 2022-08-26 10:29:40 ~54 min e2e :page_facing_up:log
:interrobang: 56bbf8eb #7 2022-08-26 16:15:29 ~6 min linux-cpp :page_facing_up:log
:heavy_check_mark: 56bbf8eb #15 2022-08-26 16:21:22 ~12 min linux :package:tgz
:heavy_check_mark: 56bbf8eb #15 2022-08-26 16:23:41 ~14 min macos :package:dmg
:heavy_check_mark: 56bbf8eb #15 2022-08-26 16:35:23 ~26 min windows :package:exe
:x: 56bbf8eb #13 2022-08-26 18:02:10 ~49 min e2e :page_facing_up:log
:interrobang: 41dc68d1 #8 2022-08-29 15:39:48 ~4 min linux-cpp :page_facing_up:log
:x: 41dc68d1 #14 2022-08-29 15:42:52 ~7 min e2e :page_facing_up:log
:heavy_check_mark: 41dc68d1 #16 2022-08-29 15:47:45 ~12 min linux :package:tgz
:x: 41dc68d1 #16 2022-08-29 15:51:13 ~15 min windows :page_facing_up:log
:heavy_check_mark: 41dc68d1 #16 2022-08-29 15:52:13 ~16 min macos :package:dmg
:interrobang: 68b651b2 #9 2022-08-29 15:47:17 ~4 min linux-cpp :page_facing_up:log
:x: 68b651b2 #15 2022-08-29 15:49:12 ~6 min e2e :page_facing_up:log
:heavy_check_mark: 68b651b2 #17 2022-08-29 15:51:47 ~9 min macos :package:dmg
:heavy_check_mark: 68b651b2 #17 2022-08-29 15:54:50 ~12 min linux :package:tgz
:x: 68b651b2 #17 2022-08-29 15:58:58 ~16 min windows :page_facing_up:log
:x: f8952b37 #18 2022-08-30 11:36:33 ~14 min windows :page_facing_up:log
:heavy_check_mark: f8952b37 #18 2022-08-30 11:36:41 ~14 min macos :package:dmg
:x: f8952b37 #16 2022-08-30 13:32:10 ~14 min e2e :page_facing_up:log
:heavy_check_mark: b96b70e6 #19 2022-08-31 09:14:27 ~15 min macos :package:dmg
:heavy_check_mark: b96b70e6 #19 2022-08-31 09:28:08 ~29 min windows :package:exe
:heavy_check_mark: 94938211 #20 2022-08-31 13:27:29 ~8 min macos :package:dmg
:heavy_check_mark: 94938211 #20 2022-08-31 13:45:25 ~26 min windows :package:exe
:x: 94938211 #18 2022-08-31 14:04:58 ~45 min e2e :page_facing_up:log
:heavy_check_mark: d653dc77 #21 2022-08-31 13:40:44 ~15 min macos :package:dmg
:heavy_check_mark: d653dc77 #21 2022-08-31 13:52:34 ~26 min windows :package:exe
:x: d653dc77 #19 2022-08-31 16:31:22 ~1 hr 26 min e2e :page_facing_up:log
:heavy_check_mark: 71006c1c #22 2022-08-31 16:37:25 ~15 min macos :package:dmg
:heavy_check_mark: 71006c1c #22 2022-08-31 16:47:52 ~26 min windows :package:exe
:x: 3b505f2f #25 2022-08-31 17:28:50 ~8 min windows :page_facing_up:log
:heavy_check_mark: 3b505f2f #25 2022-08-31 17:45:37 ~24 min macos :package:dmg
:x: 3b505f2f #20 2022-08-31 20:07:14 ~54 min e2e :page_facing_up:log
:heavy_check_mark: cc5d22cf #23 2022-08-31 17:31:59 ~15 min macos :package:dmg
:heavy_check_mark: cc5d22cf #23 2022-08-31 17:41:30 ~24 min windows :package:exe
:heavy_check_mark: aec552e7 #24 2022-08-31 17:45:52 ~25 min windows :package:exe
:interrobang: cf0e92af #18 2022-09-02 11:02:25 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: cf0e92af #26 2022-09-02 11:08:26 ~11 min linux :package:tgz
:heavy_check_mark: cf0e92af #26 2022-09-02 11:11:17 ~13 min macos :package:dmg
:heavy_check_mark: cf0e92af #26 2022-09-02 11:24:04 ~26 min windows :package:exe
:interrobang: 76eb68ad #19 2022-09-02 11:10:19 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: 76eb68ad #27 2022-09-02 11:17:07 ~11 min linux :package:tgz
:heavy_check_mark: 7dfcd8e5 #28 2022-09-02 12:03:17 ~10 min macos :package:dmg
:heavy_check_mark: 7dfcd8e5 #28 2022-09-02 12:19:26 ~26 min windows :package:exe
:interrobang: 466fdc44 #21 2022-09-02 14:09:46 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 466fdc44 #29 2022-09-02 14:16:32 ~11 min linux :package:tgz
:heavy_check_mark: 466fdc44 #29 2022-09-02 14:18:56 ~14 min macos :package:dmg
:heavy_check_mark: 466fdc44 #29 2022-09-02 14:31:05 ~26 min windows :package:exe
:x: 466fdc44 #22 2022-09-02 15:52:43 ~1 hr 1 min e2e :page_facing_up:log
:interrobang: 4a63b21e #22 2022-09-05 07:35:39 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 4a63b21e #30 2022-09-05 07:39:42 ~9 min macos :package:dmg
:heavy_check_mark: 4a63b21e #30 2022-09-05 07:42:19 ~11 min linux :package:tgz
:heavy_check_mark: 4a63b21e #30 2022-09-05 07:57:12 ~26 min windows :package:exe
:x: 4a63b21e #23 2022-09-05 08:08:16 ~37 min e2e :page_facing_up:log
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:interrobang: 1293434b #23 2022-09-05 19:26:47 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: 1293434b #31 2022-09-05 19:33:56 ~11 min linux :package:tgz
:heavy_check_mark: 1293434b #31 2022-09-05 19:37:37 ~15 min macos :package:dmg
:heavy_check_mark: 1293434b #31 2022-09-05 19:49:40 ~27 min windows :package:exe
:interrobang: 6c33b2ce #24 2022-09-05 19:35:52 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 6c33b2ce #32 2022-09-05 19:41:14 ~10 min macos :package:dmg
:heavy_check_mark: 6c33b2ce #32 2022-09-05 19:42:55 ~12 min linux :package:tgz
:heavy_check_mark: 6c33b2ce #32 2022-09-05 19:58:05 ~27 min windows :package:exe
:x: 6c33b2ce #25 2022-09-05 21:26:32 ~1 hr 1 min e2e :page_facing_up:log

status-im-auto avatar Aug 16 '22 09:08 status-im-auto

@all even there are lot of changed files, don't be afraid since more than a half are new images. :) Also changes are splitted in several logical commits which will make a review easier.

Flows which belongs to the shared keycard module means they are meant to be used from more than a single place in the app.

What is done:

  • Setup a new Keycard with an existing account flow (part of keycard settings flows) is added to shared keycard module
  • Factory reset flow updated since within this PR we added new view for displaying metadata from a keycard (if they are set), this flow is also part of shared keycard module
  • Keycard library since this PR brings new changes in terms of signals being sent by the lib in case of reader is not plugged in, card is not inserted, card is inserted, that means the following signals are sent only when it's really needed: "{\"type\":\"keycard.flow-result\",\"event\":{\"error\":\"connection-error\"}}" "{\"type\":\"keycard.action.insert-card\",\"event\":{\"error\":\"connection-error\"}}" "{\"type\":\"keycard.action.card-inserted\",\"event\":{}}"
  • Because of changes done in the keycard library we had to update onboarding and login flow accordingly

saledjenic avatar Aug 31 '22 17:08 saledjenic

@all at the end keep in mind that entire keycard thing is work in progress and it is a very big part of the app, which is being developing yet, so even some parts are not aligned with the figma design, that's cause we don't have all flows developed.

But considering the size and scope of this thing we should merge this into the master branch instead of keeping it in this branch till everything keycard related is completely done.

saledjenic avatar Aug 31 '22 17:08 saledjenic

@caybro thanks for the comments, I addressed all your concerns.

saledjenic avatar Sep 02 '22 11:09 saledjenic

:heavy_check_mark: status-desktop/branches/windows/PR-7042#26 :small_blue_diamond: ~46 min :small_blue_diamond: cf0e92af :small_blue_diamond: :package: windows package

status-im-auto avatar Sep 02 '22 11:09 status-im-auto

@caybro would you have another look here? Merge it blocked for me since you requested changes.

saledjenic avatar Sep 06 '22 09:09 saledjenic

@caybro would you have another look here? Merge it blocked for me since you requested changes.

Sure but there are still some outstanding issues that I'd pointed out

caybro avatar Sep 06 '22 11:09 caybro