status-desktop
status-desktop copied to clipboard
status-im
feat(Desktop)!: Updating desktop app due to IconSettings refactor
As part of https://github.com/status-im/StatusQ/issues/781 Depends on: https://github.com/status-im/StatusQ/pull/788
What does the PR do
Updating desktop app due to IconSettings refactor
Affected areas
Desktop app
Screenshot of functionality (including design for comparison)
https://user-images.githubusercontent.com/31625338/184139460-7a7c9f45-d7f0-4e11-98c6-a167d5a4de83.mov
Jenkins Builds
Click to see older builds (21)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :x: | 04ba8386 | #1 | 2022-08-11 13:01:23 | ~6 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 04ba8386 | #1 | 2022-08-11 13:03:55 | ~8 min | macos |
:package:dmg |
| :heavy_check_mark: | 04ba8386 | #1 | 2022-08-11 13:06:54 | ~11 min | linux |
:package:tgz |
| :heavy_check_mark: | 04ba8386 | #1 | 2022-08-11 13:19:53 | ~24 min | windows |
:package:exe |
| :heavy_check_mark: | f1d64112 | #2 | 2022-08-16 11:00:39 | ~10 min | macos |
:package:dmg |
| :heavy_check_mark: | f1d64112 | #2 | 2022-08-16 11:03:39 | ~13 min | linux |
:package:tgz |
| :x: | f1d64112 | #2 | 2022-08-16 11:15:11 | ~24 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | f1d64112 | #2 | 2022-08-16 11:24:11 | ~33 min | windows |
:package:exe |
| :x: | f1d64112 | #3 | 2022-08-16 12:20:55 | ~58 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 8fa69ad7 | #3 | 2022-08-18 11:50:57 | ~8 min | macos |
:package:dmg |
| :heavy_check_mark: | 8fa69ad7 | #3 | 2022-08-18 11:57:48 | ~15 min | linux |
:package:tgz |
| :x: | 8fa69ad7 | #4 | 2022-08-18 12:04:58 | ~22 min | e2e |
:page_facing_up:log |
| :heavy_check_mark: | 8fa69ad7 | #3 | 2022-08-18 12:08:18 | ~25 min | windows |
:package:exe |
| :heavy_check_mark: | 98926e9b | #4 | 2022-08-30 16:39:51 | ~8 min | macos |
:package:dmg |
| :x: | 98926e9b | #4 | 2022-08-30 16:45:51 | ~14 min | windows |
:page_facing_up:log |
| :heavy_check_mark: | af021868 | #5 | 2022-08-31 13:59:40 | ~9 min | macos |
:package:dmg |
| :heavy_check_mark: | af021868 | #5 | 2022-08-31 14:17:04 | ~26 min | windows |
:package:exe |
| :heavy_check_mark: | 11a74b76 | #6 | 2022-08-31 14:06:56 | ~14 min | macos |
:package:dmg |
| :heavy_check_mark: | 11a74b76 | #6 | 2022-08-31 14:18:35 | ~26 min | windows |
:package:exe |
| :heavy_check_mark: | 1ac2a4ff | #7 | 2022-09-01 09:22:39 | ~8 min | macos |
:package:dmg |
| :heavy_check_mark: | 1ac2a4ff | #7 | 2022-09-01 09:37:52 | ~23 min | windows |
:package:exe |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :interrobang: | 36bb5595 | #5 | 2022-09-01 15:15:22 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | 36bb5595 | #8 | 2022-09-01 15:21:32 | ~10 min | linux |
:package:tgz |
| :heavy_check_mark: | 36bb5595 | #8 | 2022-09-01 15:35:45 | ~25 min | windows |
:package:exe |
| :heavy_check_mark: | 36bb5595 | #8 | 2022-09-01 15:48:16 | ~37 min | macos |
:package:dmg |
| :x: | 36bb5595 | #8 | 2022-09-01 16:23:53 | ~19 min | e2e |
:page_facing_up:log |
| :interrobang: | a09b1fec | #6 | 2022-09-02 12:52:04 | ~4 min | linux-cpp |
:page_facing_up:log |
| :heavy_check_mark: | a09b1fec | #9 | 2022-09-02 12:55:51 | ~8 min | macos |
:package:dmg |
| :heavy_check_mark: | a09b1fec | #9 | 2022-09-02 12:57:53 | ~10 min | linux |
:package:tgz |
| :heavy_check_mark: | a09b1fec | #9 | 2022-09-02 13:12:42 | ~25 min | windows |
:package:exe |
Issues found
1. FIXED Icons missing from "More" menu
Actual
2. FIXED Icons missing from menu on clicking user
Actual - Contact list
Actual - Community and 1-1 Chat
3. CLOSED (not bug) Profile picture not shown in community participants list
Actual
4. FIXED Activity icons missing
Actual
5. FIXED Profile icons missing from Start Chat; Community invite modal; Channel participants; Group chat participants
Actual
Actual
Actual
Actual
@glitchminer thanks for testing! Issues 1&2 are now fixed. Regarding issue 3 it's about privacy settings that prevent showing the image, if I look at the code:
if ((!model.isContact &&
Global.privacyModuleInst.profilePicturesVisibility !==
Constants.profilePicturesVisibility.everyone)) {
return "";
}
if I comment out this snippet I can see the profile image:
@alexandraB99, thanks for the fixes. Closed items 1,2,3. Seems like some regression happened so had to add 4, and 5 here: https://github.com/status-im/status-desktop/pull/6979#issuecomment-1233195049
@alexandraB99, thanks for the fixes. Closed items 1,2,3. Seems like some regression happened so had to add 4, and 5 here: #6979 (comment)
@glitchminer 4&5 fixed! thanks