status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

feat(desktop): Made activity button be visible everywhere

Open alexandraB99 opened this issue 2 years ago • 5 comments

Closes #6635 Depends on: https://github.com/status-im/StatusQ/pull/836

What does the PR do

Sets Activity button to be visible from ALL screens

Affected areas

All app

Screenshot of functionality (including design for comparison)

https://user-images.githubusercontent.com/31625338/184897383-72546a10-23f1-47d4-9d0a-8546295339e7.mov

f

alexandraB99 avatar Aug 09 '22 15:08 alexandraB99

Jenkins Builds

Click to see older builds (56)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 06d3e7a4 #1 2022-08-09 15:23:37 ~12 min linux :package:tgz
:heavy_check_mark: 06d3e7a4 #1 2022-08-09 15:27:07 ~15 min macos :package:dmg
:heavy_check_mark: 06d3e7a4 #1 2022-08-09 15:33:33 ~21 min windows :package:exe
:x: 06d3e7a4 #1 2022-08-09 15:40:01 ~28 min e2e :page_facing_up:log
:heavy_check_mark: ba653031 #2 2022-08-09 15:37:31 ~8 min macos :package:dmg
:heavy_check_mark: ba653031 #2 2022-08-09 15:39:29 ~10 min linux :package:tgz
:x: ba653031 #2 2022-08-09 15:52:01 ~23 min e2e :page_facing_up:log
:heavy_check_mark: ba653031 #2 2022-08-09 15:52:32 ~23 min windows :package:exe
:heavy_check_mark: 8c67e648 #3 2022-08-10 14:48:25 ~10 min macos :package:dmg
:heavy_check_mark: 8c67e648 #3 2022-08-10 15:44:31 ~1 hr 6 min linux :package:tgz
:x: 8c67e648 #3 2022-08-10 16:02:29 ~1 hr 24 min e2e :page_facing_up:log
:heavy_check_mark: 8c67e648 #3 2022-08-10 16:04:15 ~1 hr 26 min windows :package:exe
:heavy_check_mark: 8c67e648 #1 2022-08-10 17:13:43 ~25 min linux :package:tgz
:heavy_check_mark: 8c67e648 #1 2022-08-10 17:20:55 ~31 min macos :package:dmg
:heavy_check_mark: 8c67e648 #1 2022-08-10 18:33:10 ~1 hr 42 min windows :package:exe
:heavy_check_mark: 9f538055 #2 2022-08-11 15:02:25 ~10 min macos :package:dmg
:heavy_check_mark: 9f538055 #2 2022-08-11 15:13:26 ~21 min linux :package:tgz
:x: 9f538055 #4 2022-08-11 15:44:54 ~53 min e2e :page_facing_up:log
:heavy_check_mark: 9f538055 #2 2022-08-11 15:45:05 ~53 min windows :package:exe
:x: 9f538055 #5 2022-08-11 17:27:35 ~1 hr 15 min e2e :page_facing_up:log
:heavy_check_mark: 0c6814a1 #3 2022-08-16 14:03:41 ~8 min macos :package:dmg
:heavy_check_mark: 0c6814a1 #3 2022-08-16 14:06:07 ~10 min linux :package:tgz
:x: 0c6814a1 #6 2022-08-16 14:15:59 ~20 min e2e :page_facing_up:log
:heavy_check_mark: 0c6814a1 #3 2022-08-16 14:19:57 ~24 min windows :package:exe
:heavy_check_mark: e8ab46c6 #4 2022-08-17 15:45:43 ~8 min macos :package:dmg
:heavy_check_mark: e8ab46c6 #4 2022-08-17 15:48:48 ~11 min linux :package:tgz
:x: e8ab46c6 #7 2022-08-17 15:52:12 ~15 min e2e :page_facing_up:log
:heavy_check_mark: e8ab46c6 #4 2022-08-17 16:03:01 ~25 min windows :package:exe
:heavy_check_mark: 9a15cf71 #5 2022-08-18 08:32:53 ~8 min macos :package:dmg
:heavy_check_mark: 9a15cf71 #5 2022-08-18 08:36:03 ~11 min linux :package:tgz
:x: 9a15cf71 #8 2022-08-18 08:40:42 ~16 min e2e :page_facing_up:log
:heavy_check_mark: 9a15cf71 #5 2022-08-18 08:49:25 ~24 min windows :package:exe
:heavy_check_mark: fe5e444e #6 2022-08-18 08:49:47 ~15 min linux :package:tgz
:heavy_check_mark: fe5e444e #6 2022-08-18 08:54:36 ~20 min macos :package:dmg
:heavy_check_mark: fe5e444e #6 2022-08-18 09:13:21 ~38 min windows :package:exe
:x: fe5e444e #9 2022-08-18 10:23:17 ~1 hr 1 min e2e :page_facing_up:log
:x: 07f26f75 #10 2022-08-18 15:57:39 ~7 min e2e :page_facing_up:log
:heavy_check_mark: 07f26f75 #7 2022-08-18 15:59:02 ~8 min macos :package:dmg
:heavy_check_mark: 07f26f75 #7 2022-08-18 16:02:09 ~11 min linux :package:tgz
:heavy_check_mark: 07f26f75 #7 2022-08-18 16:15:40 ~25 min windows :package:exe
:interrobang: 0d0f3093 #1 2022-08-29 13:26:08 ~10 min linux-cpp :page_facing_up:log
:x: 0d0f3093 #11 2022-08-29 13:32:07 ~16 min e2e :page_facing_up:log
:x: 0d0f3093 #8 2022-08-29 13:32:23 ~16 min windows :page_facing_up:log
:heavy_check_mark: 0d0f3093 #8 2022-08-29 13:33:15 ~17 min linux :package:tgz
:heavy_check_mark: 0d0f3093 #8 2022-08-29 14:57:21 ~1 hr 41 min macos :package:dmg
:heavy_check_mark: 11cb0f30 #9 2022-08-31 10:14:14 ~13 min macos :package:dmg
:heavy_check_mark: 11cb0f30 #9 2022-08-31 10:26:16 ~25 min windows :package:exe
:x: 11cb0f30 #12 2022-08-31 11:26:43 ~47 min e2e :page_facing_up:log
:heavy_check_mark: b127f0c7 #10 2022-08-31 14:09:41 ~10 min macos :package:dmg
:heavy_check_mark: b127f0c7 #10 2022-08-31 14:40:59 ~42 min windows :package:exe
:heavy_check_mark: 9319627a #11 2022-09-01 08:44:19 ~13 min macos :package:dmg
:heavy_check_mark: 9319627a #11 2022-09-01 08:57:02 ~26 min windows :package:exe
:interrobang: fb81104b #5 2022-09-01 14:28:29 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: fb81104b #12 2022-09-01 14:34:39 ~11 min linux :package:tgz
:heavy_check_mark: fb81104b #12 2022-09-01 14:51:10 ~27 min windows :package:exe
:heavy_check_mark: fb81104b #12 2022-09-01 15:12:47 ~49 min macos :package:dmg
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:interrobang: 23333929 #6 2022-09-02 07:30:56 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 23333929 #13 2022-09-02 07:37:36 ~11 min linux :package:tgz
:heavy_check_mark: 23333929 #13 2022-09-02 07:40:26 ~14 min macos :package:dmg
:heavy_check_mark: 23333929 #13 2022-09-02 07:50:37 ~24 min windows :package:exe
:interrobang: 678c5c20 #7 2022-09-02 07:32:08 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: 678c5c20 #14 2022-09-02 07:38:12 ~10 min linux :package:tgz
:heavy_check_mark: 678c5c20 #14 2022-09-02 07:42:28 ~15 min macos :package:dmg
:heavy_check_mark: 678c5c20 #14 2022-09-02 07:51:26 ~23 min windows :package:exe

status-im-auto avatar Aug 09 '22 15:08 status-im-auto

@alexandraB99 needs a rebase too

caybro avatar Aug 10 '22 11:08 caybro

@alexandraB99 needs a rebase too

rebased

alexandraB99 avatar Aug 10 '22 14:08 alexandraB99

Issues Found


1. FIXED Settings hidden on first run

https://user-images.githubusercontent.com/50769329/185408618-e5668da3-8b68-4084-bf15-333fba1c016a.mov


2. FIXED Communities import and create buttons are missing

image


3. FIXED Additional profile image and menu included before any chats exist

Actual image

Expected ( + Activity Center icon) image


4. FIXED Browser tabs are not available

Actual image


5. MOVED Activity Center tooltip alignment is not consistent

Group chat image

Group chat with members list; Community with members list image

Communities; Wallet; Settings; Browser; Node management image


Build: https://status-im-prs.ams3.cdn.digitaloceanspaces.com/StatusIm-Desktop-220818-083421-fe5e44-pr6928.dmg OS: Mac

glitchminer avatar Aug 18 '22 13:08 glitchminer

@glitchminer all issues except the tooltip are fixed.

alexandraB99 avatar Aug 18 '22 15:08 alexandraB99

https://user-images.githubusercontent.com/31625338/187210224-18da41f8-5b64-47a3-87be-e2e2867fc719.mov

alexandraB99 avatar Aug 29 '22 13:08 alexandraB99