status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

test(community-chat): add test to send images in chat

Open jrainville opened this issue 2 years ago • 15 comments

Fixes #6880

jrainville avatar Aug 08 '22 19:08 jrainville

@noeliaSD can you test this PR, I'd like to see if it also works on Mac.

jrainville avatar Aug 08 '22 19:08 jrainville

Jenkins Builds

Click to see older builds (78)
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 7d69796a #2 2022-08-09 21:00:18 ~8 min macos :package:dmg
:heavy_check_mark: 7d69796a #2 2022-08-09 21:03:35 ~11 min linux :package:tgz
:x: 7d69796a #2 2022-08-09 21:06:07 ~14 min e2e :page_facing_up:log
:heavy_check_mark: 7d69796a #2 2022-08-09 21:15:15 ~23 min windows :package:exe
:heavy_check_mark: 86c55c08 #3 2022-08-09 21:06:10 ~8 min macos :package:dmg
:heavy_check_mark: 86c55c08 #3 2022-08-09 21:07:22 ~9 min linux :package:tgz
:heavy_check_mark: 63c67d86 #4 2022-08-09 21:15:38 ~8 min macos :package:dmg
:heavy_check_mark: 63c67d86 #4 2022-08-09 21:17:48 ~10 min linux :package:tgz
:x: 63c67d86 #4 2022-08-09 21:30:12 ~22 min e2e :page_facing_up:log
:heavy_check_mark: 63c67d86 #4 2022-08-09 21:36:40 ~29 min windows :package:exe
:heavy_check_mark: c20ef406 #5 2022-08-10 14:42:54 ~13 min macos :package:dmg
:heavy_check_mark: c20ef406 #5 2022-08-10 15:24:19 ~55 min linux :package:tgz
:x: c20ef406 #5 2022-08-10 15:37:11 ~1 hr 8 min e2e :page_facing_up:log
:heavy_check_mark: c20ef406 #5 2022-08-10 15:44:32 ~1 hr 15 min windows :package:exe
:heavy_check_mark: 3bb8ac15 #2 2022-08-10 18:16:37 ~1 hr 16 min linux :package:tgz
:x: 3bb8ac15 #6 2022-08-10 18:24:57 ~1 hr 24 min e2e :page_facing_up:log
:heavy_check_mark: 3bb8ac15 #2 2022-08-10 18:26:40 ~1 hr 26 min macos :package:dmg
:heavy_check_mark: 3bb8ac15 #2 2022-08-10 22:12:28 ~5 hr 11 min windows :package:exe
:heavy_check_mark: a1dc0acf #3 2022-08-11 17:24:30 ~8 min macos :package:dmg
:heavy_check_mark: a1dc0acf #3 2022-08-11 17:27:42 ~11 min linux :package:tgz
:heavy_check_mark: a1dc0acf #3 2022-08-11 17:39:05 ~22 min windows :package:exe
:x: a1dc0acf #7 2022-08-11 17:41:57 ~25 min e2e :page_facing_up:log
:heavy_check_mark: b49db95c #4 2022-08-11 20:03:50 ~8 min macos :package:dmg
:heavy_check_mark: b49db95c #4 2022-08-11 20:06:36 ~10 min linux :package:tgz
:heavy_check_mark: b49db95c #4 2022-08-11 20:20:57 ~25 min windows :package:exe
:x: b49db95c #8 2022-08-11 20:33:04 ~37 min e2e :page_facing_up:log
:heavy_check_mark: 6336ac87 #5 2022-08-12 15:50:54 ~8 min macos :package:dmg
:heavy_check_mark: 6336ac87 #5 2022-08-12 15:53:24 ~10 min linux :package:tgz
:x: 6336ac87 #9 2022-08-12 16:01:20 ~18 min e2e :page_facing_up:log
:heavy_check_mark: 6336ac87 #5 2022-08-12 16:06:48 ~24 min windows :package:exe
:heavy_check_mark: 4da81e15 #6 2022-08-16 15:27:37 ~7 min macos :package:dmg
:heavy_check_mark: 4da81e15 #6 2022-08-16 15:32:07 ~12 min linux :package:tgz
:x: 4da81e15 #10 2022-08-16 15:48:22 ~28 min e2e :page_facing_up:log
:heavy_check_mark: 4da81e15 #6 2022-08-16 15:51:40 ~31 min windows :package:exe
:heavy_check_mark: 63a433c1 #7 2022-08-17 18:05:58 ~8 min macos :package:dmg
:heavy_check_mark: 63a433c1 #7 2022-08-17 18:08:45 ~11 min linux :package:tgz
:x: 63a433c1 #11 2022-08-17 18:14:10 ~16 min e2e :page_facing_up:log
:heavy_check_mark: 63a433c1 #7 2022-08-17 18:20:26 ~22 min windows :package:exe
:x: 510e2888 #12 2022-08-17 21:08:03 ~6 min e2e :page_facing_up:log
:heavy_check_mark: 510e2888 #8 2022-08-17 21:10:01 ~8 min macos :package:dmg
:heavy_check_mark: 510e2888 #8 2022-08-17 21:12:59 ~11 min linux :package:tgz
:heavy_check_mark: 510e2888 #8 2022-08-17 21:25:17 ~23 min windows :package:exe
:x: 510e2888 #13 2022-08-17 21:50:23 ~23 min e2e :page_facing_up:log
:heavy_check_mark: f7e4c026 #9 2022-08-18 13:50:28 ~8 min macos :package:dmg
:heavy_check_mark: f7e4c026 #9 2022-08-18 14:00:11 ~18 min linux :package:tgz
:heavy_check_mark: f7e4c026 #9 2022-08-18 14:07:22 ~25 min windows :package:exe
:x: f7e4c026 #14 2022-08-18 15:42:25 ~6 min e2e :page_facing_up:log
:heavy_check_mark: fef65f5b #10 2022-08-18 16:03:18 ~10 min macos :package:dmg
:x: fef65f5b #15 2022-08-18 16:03:53 ~6 min e2e :page_facing_up:log
:heavy_check_mark: fef65f5b #10 2022-08-18 16:03:55 ~10 min linux :package:tgz
:heavy_check_mark: fef65f5b #10 2022-08-18 16:14:51 ~21 min windows :package:exe
:x: d2628997 #16 2022-08-18 17:25:57 ~6 min e2e :page_facing_up:log
:heavy_check_mark: d2628997 #11 2022-08-18 17:27:46 ~8 min macos :package:dmg
:heavy_check_mark: d2628997 #11 2022-08-18 17:30:50 ~11 min linux :package:tgz
:heavy_check_mark: d2628997 #11 2022-08-18 17:43:26 ~24 min windows :package:exe
:heavy_check_mark: 86fa3d00 #12 2022-08-19 15:07:50 ~9 min macos :package:dmg
:heavy_check_mark: 86fa3d00 #12 2022-08-19 15:09:21 ~10 min linux :package:tgz
:heavy_check_mark: 86fa3d00 #12 2022-08-19 15:23:23 ~25 min windows :package:exe
:x: 562abebb #17 2022-08-19 15:12:11 ~12 min e2e :page_facing_up:log
:heavy_check_mark: 562abebb #13 2022-08-19 15:14:31 ~15 min macos :package:dmg
:heavy_check_mark: 562abebb #13 2022-08-19 15:16:24 ~17 min linux :package:tgz
:heavy_check_mark: 562abebb #13 2022-08-19 15:22:20 ~23 min windows :package:exe
:x: 6fe62e39 #18 2022-08-19 15:20:54 ~6 min e2e :page_facing_up:log
:heavy_check_mark: 6fe62e39 #14 2022-08-19 15:23:06 ~8 min macos :package:dmg
:heavy_check_mark: 6fe62e39 #14 2022-08-19 15:25:10 ~10 min linux :package:tgz
:heavy_check_mark: 6fe62e39 #14 2022-08-19 15:40:08 ~25 min windows :package:exe
:heavy_check_mark: db56ebed #15 2022-08-22 16:14:06 ~8 min macos :package:dmg
:heavy_check_mark: db56ebed #15 2022-08-22 16:16:04 ~10 min linux :package:tgz
:heavy_check_mark: db56ebed #15 2022-08-22 16:29:05 ~23 min windows :package:exe
:x: db56ebed #19 2022-08-22 16:46:51 ~41 min e2e :page_facing_up:log
:heavy_check_mark: 5529d357 #16 2022-08-22 16:57:56 ~8 min macos :package:dmg
:heavy_check_mark: 5529d357 #16 2022-08-22 17:00:17 ~10 min linux :package:tgz
:heavy_check_mark: 5529d357 #16 2022-08-22 17:14:38 ~25 min windows :package:exe
:x: 5529d357 #20 2022-08-22 17:30:36 ~41 min e2e :page_facing_up:log
:interrobang: 1f66fb36 #1 2022-08-23 18:56:29 ~4 min linux-cpp :page_facing_up:log
:heavy_check_mark: 1f66fb36 #17 2022-08-23 19:05:59 ~14 min macos :package:dmg
:heavy_check_mark: 1f66fb36 #17 2022-08-23 19:06:20 ~14 min linux :package:tgz
:heavy_check_mark: 1f66fb36 #17 2022-08-23 19:15:26 ~23 min windows :package:exe
:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:interrobang: bf316776 #2 2022-08-23 19:08:56 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: bf316776 #18 2022-08-23 19:12:38 ~9 min macos :package:dmg
:heavy_check_mark: bf316776 #18 2022-08-23 19:14:30 ~11 min linux :package:tgz
:heavy_check_mark: bf316776 #18 2022-08-23 19:34:41 ~31 min windows :package:exe
:x: bf316776 #21 2022-08-23 23:01:11 ~46 min e2e :page_facing_up:log
:interrobang: 2bc3a111 #3 2022-08-24 17:34:46 ~5 min linux-cpp :page_facing_up:log
:heavy_check_mark: 2bc3a111 #19 2022-08-24 17:39:32 ~9 min macos :package:dmg
:heavy_check_mark: 2bc3a111 #19 2022-08-24 17:40:44 ~11 min linux :package:tgz
:heavy_check_mark: 2bc3a111 #19 2022-08-24 17:54:17 ~24 min windows :package:exe
:x: 2bc3a111 #22 2022-08-24 18:33:42 ~50 min e2e :page_facing_up:log

status-im-auto avatar Aug 09 '22 21:08 status-im-auto

@noeliaSD can you test again. I marked the scenarios as mayfail because it seems like the CI doesn't have the file manager. Anyway, it's good to know that we can test it on local.

jrainville avatar Aug 16 '22 15:08 jrainville

@noeliaSD can you test again. I marked the scenarios as mayfail because it seems like the CI doesn't have the file manager. Anyway, it's good to know that we can test it on local.

I've tested again and it happens the same so I've tried to do the same steps but manually and here is the issue.. I can open file finder dialog, remove the "/", then type the root, if here I type the return, it does the return action, but if I type the complete path until the file, the return action doesn't work.

noeliaSD avatar Aug 17 '22 10:08 noeliaSD

I can open file finder dialog, remove the "/", then type the root, if here I type the return, it does the return action, but if I type the complete path until the file, the return action doesn't work.

Ah I guess Mac has a different way of handling it. I wonder how I can make it work for mac then, since we don't have access to the dialog buttons

jrainville avatar Aug 17 '22 17:08 jrainville

@noeliaSD I tried to remove the .jpg at the end. It works on my machine. Let me know if it works for you

jrainville avatar Aug 17 '22 18:08 jrainville

@noeliaSD I tried to remove the .jpg at the end. It works on my machine. Let me know if it works for you

Same happens :(

If you don't have more ideas an you need to test in mac, let me know and I can try to investigate a little bit!

noeliaSD avatar Aug 18 '22 09:08 noeliaSD

If you don't have more ideas an you need to test in mac, let me know and I can try to investigate a little bit!

@noeliaSD yeah I'm out of ideas. If you could give it a try, it would be great

jrainville avatar Aug 18 '22 13:08 jrainville

@noeliaSD I updated the PR. It should work now for Mac. I added the second Enter press as well. Let me know if it works.

jrainville avatar Aug 18 '22 15:08 jrainville

@noeliaSD I updated the PR. It should work now for Mac. I added the second Enter press as well. Let me know if it works.

Here the result of new changes:

Screenshot 2022-08-22 at 09 13 47

If you are out of ideas, we can create a new task to address it on mac. Thanks :)

noeliaSD avatar Aug 22 '22 07:08 noeliaSD

Rebased and fixed the issue where we no longer could find the last message New StatusQ PR: https://github.com/status-im/StatusQ/pull/865

jrainville avatar Aug 22 '22 16:08 jrainville

@noeliaSD can you try again. Can you do a video screen capture if it still errors. I'd like to see what is going on.

jrainville avatar Aug 23 '22 19:08 jrainville

Here te video with the failure.. Hope it helps:

https://user-images.githubusercontent.com/97019400/186357311-fe79418d-eef4-46a2-80bd-73e4ba55cb41.mov

noeliaSD avatar Aug 24 '22 07:08 noeliaSD

Thanks for the video @noeliaSD . I now see that most steps work, it just seems like the image path might be wrong on Mac. I don't have a good way to debug of fix it without bugging you all the time, so I decided to create this issue so that someone with Mac can fix it. I added all necessary information to debug. https://github.com/status-im/status-desktop/issues/7138

If you wouldn't mind, review one last time and approve if you think the code looks good.

jrainville avatar Aug 24 '22 17:08 jrainville

The test passed on Jenkins :tada: https://ci.status.im/job/status-desktop/job/branches/job/uitests/view/change-requests/job/PR-6916/22/squishResults_220824_174928.148/webreport_220824_174928.148_linux-04/index.html

(see the CommunityMessageFlows test)

Screenshot from 2022-08-24 17-00-57

jrainville avatar Aug 24 '22 20:08 jrainville