status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

Feat/enable wallet connect by default

Open alexjba opened this issue 4 months ago • 2 comments

What does the PR do

Closes #15673

This PR enables the wallet connect feature by default. The feature flag remains in place.

It brings in new user stories because the WC and BC overlaps in the UI. Therefore the qml components need to work with either of these features disabled.

Changes

  1. Enable WC by default
  2. Account for the WC and BC feature flags in the dapp list providers
  3. Account for the WC and BC feature flags in the Connect a dApp modal
  4. Add qml test

New user stories identified in the process:

Given the Wallet Connect feature is disabled
And Browser Connect feature is enabled
Then the dApps button is visible in the wallet header
Given the Wallet Connect feature is disabled
And Browser Connect feature is enabled
When `Connect a dApp` button is clicked
Then the `Connect a dApp` modal is shown
Given the Wallet Connect feature is disabled
And Browser Connect feature is enabled
When the `Connect a dApp` modal is shown
The Wallet Connect button is disabled
Given the Wallet Connect feature is enabled
And Browser Connect feature is disabled
When the `Connect a dApp` modal is shown
The Browser Connect button is disabled
Given the Wallet Connect feature is enabled
And Browser Connect feature is disabled
When the `dApps` button is clicked
Then the popup doesn't show BC connected dapps
Given the Wallet Connect feature is disabled
And Browser Connect feature is enabled
When the `dApps` button is clicked
Then the popup doesn't show WC connected dapps

Affected areas

Wallet Connect Browser Connect

Architecture compliance

Screenshot of functionality (including design for comparison)

  • [x] I've checked the design and this PR matches it

https://github.com/user-attachments/assets/712392c8-df54-4b82-bace-150000c9e7ae

alexjba avatar Oct 25 '24 19:10 alexjba