status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

fix(@desktop/chat): fix bridged messages breakspaces

Open endulab opened this issue 1 year ago • 3 comments

Fix #15291

image

endulab avatar Jul 03 '24 14:07 endulab

Jenkins Builds

:grey_question: Commit :hash: Finished (UTC) Duration Platform Result
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:11:49 ~6 min tests/nim :page_facing_up:log
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:14:22 ~9 min macos/aarch64 :apple:dmg
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:15:18 ~10 min macos/x86_64 :apple:dmg
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:18:34 ~13 min tests/ui :page_facing_up:log
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:20:24 ~15 min linux/x86_64 :package:tgz
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:20:49 ~15 min linux/x86_64 :package:tgz
:heavy_check_mark: 3c2e1ee3 #1 2024-07-03 14:29:40 ~24 min windows/x86_64 :cd:exe

status-im-auto avatar Jul 03 '24 14:07 status-im-auto

Looks good to me!

offtop general thoughts: I wish all the bridged message handling/formatting was on the service side. And ideally qml would have no idea what kind of messages it's displaying.

You are right. I think I will move the code to the bridge. One advantage of the current solution is that it will work for historic messages also.

endulab avatar Jul 05 '24 12:07 endulab

Formatting message was moved to the bridge: https://github.com/status-im/matterbridge/pull/13

endulab avatar Jul 11 '24 12:07 endulab