status-desktop
status-desktop copied to clipboard
status-im
fix(TokenUI): Hide explicitly ManageTokensCommunityTag in community settings page
What does the PR do
PR hide the ManageTokensCommunityTag item in "Community"->Tokens page. Previous changes introduced ManageTokensCommunityTag 12519 ManageTokensCommunityTag for displaying community icon and name when showing Collectibles in User's Wallet->Collectibles page. However when going to particular Community and checking its "Tokens" there is no need to display that tag, according to the MintedTokensSettingsPanel PR: 11347
Affected areas
Wallet Communities
StatusQ checklist
- [x ] test changes in both light and dark theme?
Screenshot of functionality (including design for comparison)
- [x] I've checked the design and this PR matches it
In Wallet -> Collectibles, ManageTokensCommunityTag is displayed:
Cool Spaceship Picture
Jenkins Builds
Click to see older builds (18)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 11f95ac2 | #1 | 2024-04-23 13:00:56 | ~7 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | 11f95ac2 | #1 | 2024-04-23 13:02:35 | ~9 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | 11f95ac2 | #1 | 2024-04-23 13:05:23 | ~12 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | 11f95ac2 | #1 | 2024-04-23 13:08:39 | ~15 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | 11f95ac2 | #1 | 2024-04-23 13:15:14 | ~22 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | 11f95ac2 | #1 | 2024-04-23 13:26:14 | ~33 min | windows/x86_64 |
:cd:exe |
| :heavy_check_mark: | a3b327a2 | #2 | 2024-04-24 10:00:01 | ~4 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | a3b327a2 | #2 | 2024-04-24 10:03:23 | ~7 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | a3b327a2 | #2 | 2024-04-24 10:05:31 | ~9 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | a3b327a2 | #2 | 2024-04-24 10:12:34 | ~17 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | a3b327a2 | #2 | 2024-04-24 10:15:09 | ~19 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | a3b327a2 | #2 | 2024-04-24 10:27:28 | ~31 min | windows/x86_64 |
:cd:exe |
| :heavy_check_mark: | 1570e505 | #4 | 2024-04-26 13:36:59 | ~7 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | 1570e505 | #4 | 2024-04-26 13:39:02 | ~9 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | 1570e505 | #4 | 2024-04-26 13:40:15 | ~10 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | 1570e505 | #4 | 2024-04-26 13:46:11 | ~16 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | 1570e505 | #4 | 2024-04-26 13:46:19 | ~16 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | 1570e505 | #4 | 2024-04-26 14:03:50 | ~33 min | windows/x86_64 |
:cd:exe |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | a3cb7c08 | #5 | 2024-05-08 09:15:44 | ~7 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | a3cb7c08 | #5 | 2024-05-08 09:16:40 | ~8 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | a3cb7c08 | #5 | 2024-05-08 09:17:44 | ~9 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | a3cb7c08 | #5 | 2024-05-08 09:24:43 | ~16 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | a3cb7c08 | #5 | 2024-05-08 09:27:51 | ~19 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | a3cb7c08 | #5 | 2024-05-08 09:42:15 | ~34 min | windows/x86_64 |
:cd:exe |
| :heavy_check_mark: | 6efc0438 | #6 | 2024-05-08 10:50:43 | ~4 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | 6efc0438 | #6 | 2024-05-08 10:53:22 | ~7 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | 6efc0438 | #6 | 2024-05-08 10:56:10 | ~10 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | 6efc0438 | #6 | 2024-05-08 11:03:34 | ~17 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | 6efc0438 | #6 | 2024-05-08 11:06:10 | ~20 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | 6efc0438 | #6 | 2024-05-08 11:18:32 | ~32 min | windows/x86_64 |
:cd:exe |
Checking Figma Communities P3 -> Tokens , it looks like indeed communityId should not be set on MintedTokensView component. I will do the changes according to @noeliaSD suggestion