status-desktop
status-desktop copied to clipboard
status-im
4351 community token refactoring
What does the PR do
Move community tokens logic to status-go.
Nim part is only responsible for catching the signal about handled transaction and update UI. Added CommunityTokenTransactionStatusChangedSignal.
Issue https://github.com/status-im/status-go/issues/4351 status-go pr
Jenkins Builds
Click to see older builds (12)
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 3a3a7154 | #2 | 2024-04-15 12:28:13 | ~6 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | 3a3a7154 | #2 | 2024-04-15 12:29:33 | ~7 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | 3a3a7154 | #2 | 2024-04-15 12:32:59 | ~10 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | 3a3a7154 | #2 | 2024-04-15 12:33:10 | ~10 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | 3a3a7154 | #2 | 2024-04-15 12:37:43 | ~15 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | 3a3a7154 | #2 | 2024-04-15 12:47:02 | ~24 min | windows/x86_64 |
:cd:exe |
| :heavy_check_mark: | 143fad33 | #3 | 2024-04-25 20:09:24 | ~6 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | 143fad33 | #3 | 2024-04-25 20:12:09 | ~9 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | 143fad33 | #3 | 2024-04-25 20:13:20 | ~10 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | 143fad33 | #3 | 2024-04-25 20:20:02 | ~17 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | 143fad33 | #3 | 2024-04-25 20:25:21 | ~22 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | 143fad33 | #3 | 2024-04-25 20:27:45 | ~24 min | windows/x86_64 |
:cd:exe |
| :grey_question: | Commit | :hash: | Finished (UTC) | Duration | Platform | Result |
|---|---|---|---|---|---|---|
| :heavy_check_mark: | 43131760 | #4 | 2024-05-06 13:51:40 | ~6 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | 43131760 | #4 | 2024-05-06 13:54:28 | ~9 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | 43131760 | #4 | 2024-05-06 13:54:46 | ~9 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | 43131760 | #4 | 2024-05-06 13:56:46 | ~11 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | 43131760 | #4 | 2024-05-06 14:05:06 | ~19 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | 43131760 | #4 | 2024-05-06 14:10:12 | ~24 min | windows/x86_64 |
:cd:exe |
| :heavy_check_mark: | b895efa0 | #5 | 2024-05-16 14:30:38 | ~9 min | macos/aarch64 |
:apple:dmg |
| :heavy_check_mark: | b895efa0 | #5 | 2024-05-16 14:32:11 | ~10 min | tests/nim |
:page_facing_up:log |
| :heavy_check_mark: | b895efa0 | #5 | 2024-05-16 14:34:16 | ~13 min | macos/x86_64 |
:apple:dmg |
| :heavy_check_mark: | b895efa0 | #5 | 2024-05-16 14:34:38 | ~13 min | tests/ui |
:page_facing_up:log |
| :heavy_check_mark: | b895efa0 | #5 | 2024-05-16 14:39:50 | ~18 min | linux/x86_64 |
:package:tgz |
| :heavy_check_mark: | b895efa0 | #5 | 2024-05-16 14:55:20 | ~34 min | windows/x86_64 |
:cd:exe |
@anastasiyaig can you test this ticket before we merge it? It is about refactoring, so all token operations should work exactly like before. If you have any questions let me know. FYI @jrainville
@endulab i found that after minting is started the status is always stuck at "Minting...". In one case i've waited for over an hour after the trx status changed to Success and the status in app didn't change. Same happens with airdropping a token. I never receive any confirmation the airdrop was successful, no info in wallet activity either.
Hmm, Thank you @lukaszso. Strange, maybe something is broken in the wallet. I will update pr and test on my side.
@lukaszso I upgraded branch. Minting works correctly on my side. Can you retest?
@lukaszso did you test all operations? Like: minting, airdroping, burning, remote destruction? Also would be great to test transfer ownership, because there is a set signer operation. Also, notifications should work correctly if you close the app in the middle and then run again.
@endulab sorry for not clarifying. I checked minting, airdropping, burning and remote destruction. I'll check notifications and ownership transfer later today and i'll get back to you.
@endulab took a little longer than expected but it works fine. Tried all operations again and, apart from some longer wait times in some cases (prob related to network) there were no issues.
@endulab took a little longer than expected but it works fine. Tried all operations again and, apart from some longer wait times in some cases (prob related to network) there were no issues.
@lukaszso can you elaborate on these longer operations? What happened ?
@endulab i was referring to the initial issues with minting tokens. In one case i was stuck for about an hour (haven't checked if it finally succeeded since) and in the other case it took several minutes to update the status from minting to success. This was happening only in my first attempt to test this.