status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

fix(joinCommunity): Fixing permissions checks in join community flows

Open alexjba opened this issue 10 months ago • 4 comments

What does the PR do

Closing: #14095 Closing: #14200 Closing: #12326

Moving the permissions model from communities module to chat section module (at least that's the main intention). But we'll need to also move or adapt other dependencies like check permissions on selected addresses, revealed addresses.

Motivation: The current implementation in communities module is built based on the assumption that we'll need the permissions for only one community at a time. But it's not the case. We have lots of qml bindings on the permission model, each one requesting the model for a new community because the permissionsModel access is done something like:

    readonly property var permissionsModel: {
        root.store.prepareTokenModelForCommunity(communityData.id)
        return root.store.permissionsModel
    }

O top of this, there are issues with permission update events handling and we're not always seeing the permission updates in qml.

Affected areas

alexjba avatar Mar 28 '24 13:03 alexjba