status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

[Create Channel] Review discord import flows

Open alexjba opened this issue 11 months ago • 0 comments

Description

The create/edit channel had some recent changes in permissions and close confirmation flows and the discord import flows need to be aligned.

Design

Screenshot 2024-03-06 at 11 25 39

TODO:

  • [ ] Review the close confirmation popup in the discord import flow. @benjthayer We'll need your help in this regard. The main questions are: Should we display the close confirmation popup in the discord import flows? If yes, when, under what conditions and what should we save when the save is accepted in the close confirmation popup? E.g: Closing the popup after selecting the discord import file. If we'll display the close confirmation popup and the user hits save the new channel will be saved with all the info filled by the user in the first screen.

  • [ ] The permissions are not saved when importing a channel using discord import. This flow is quite different than create/edit channel because it's done totally in the nim/status-go layer and it's currently not possible to save the permissions. There's two options to this: To update requestImportDiscordChannel to support permissions as well, or to return the newly created chat id when requestImportDiscordChannel is called so that the UI can update the channel permissions.

  • [ ] Close and delete channel doesn't delete the channel. This button is shown when the discord import started. Clicking will just close the popup and stop the import.

alexjba avatar Mar 06 '24 09:03 alexjba