status-desktop icon indicating copy to clipboard operation
status-desktop copied to clipboard

ENS keycap display issues

Open 86doteth opened this issue 1 year ago • 4 comments

Been enjoying the latest desktop updates and I love the progress you've been making! Just wanted to share some issues I encountered with my keycap/emoji ENS name to make the whole thing even more amazing for my fellow ENS peeps.

  1. My keycap ENS name doesn't render properly yet on desktop in my profile card as well is in any chats. It has always rendered properly in the old mobile app. I think the relevant feature/function in the ens library to fix this is 'beautify()', I hope it's easy to do in the desktop codebase. Otherwise raffy.eth, the main author of these libraries, has been very easy to approach and willing to help with these kinds of things.

Screenshot 2023-09-28 at 18 25 41

  1. There is no name showing in the login screen, I'd expect either at least the unbeautified version of my ens as in the picture above or preferrably the beautified version.

Screenshot 2023-09-28 at 19 11 02

Hope y'all can fix this, I know a lot of ens people with emoji names would appreciate having this kind of stuff displayed properly. Keep up the great work!

86doteth avatar Sep 28 '23 17:09 86doteth

Can you paste your ENS name here in some decoded form so that we can try to reproduce/test it locally? Thanks :)

caybro avatar Sep 29 '23 10:09 caybro

This is what I copied from desktop within a code block to display it in the same way: 8⃣6⃣.eth But to be sure use the following webapp made by raffy.eth and copy the 'Emoji' entry to get exactly what I just pasted. The app is also generally useful to know all about how non-alphanumeric ens names get handled and displayed.

https://adraffy.github.io/ens-normalize.js/test/resolver.html?1#8%EF%B8%8F%E2%83%A36%EF%B8%8F%E2%83%A3.eth

ensresolver

86doteth avatar Sep 29 '23 15:09 86doteth

@John-44 any idea how we can support this valid ENS name containing UTF-16 characters, while we restrict the display name to contain ASCII only?

caybro avatar May 02 '24 11:05 caybro

Another issue, but perhaps related, I don't get a link to my profile that works on the website if:

  1. I copy it myself from my own profile menu: https://status.app/u/G00AAMRoc51ISH8d2BZpMytFzGADDhyyQPFhGDbGzhUEmx0S0zAYka3PvE8QFlPqDHqx19ue7McGDkeFhR-6pnZWf6Q9xR-6s9fD1DZSAg==#zQ3shSmkVKR6M2Z3sfNhtXmZkdgva5SMGpiWW6bDcPAQ25LmE
  2. or I ask someone else to copy the link in my profile and send it to me: https://status.app/u#8⃣.eth

Neither work :/

86doteth avatar May 05 '24 22:05 86doteth

@jrainville @endulab need a little help/hint here: do you think we're able to fix this issue while also restricting the user/display name to contain ASCII characters only?

caybro avatar May 09 '24 12:05 caybro

I know we've had some issues with some messages that failed to be received because they had "bad" display names. For example, Patryk had a name with dashes in it, and because of it, his messages were never received. I'm pretty sure that was fixed in terms of the UI where we don't allow that name anymore. I'm not sure if the backend now accepts "weird" names.

I know @86doteth here can post to the Status community correctly and it's received, so I think that name is still accepted as "text".

jrainville avatar May 09 '24 15:05 jrainville

Another issue, but perhaps related, I don't get a link to my profile that works on the website if:

  1. I copy it myself from my own profile menu: https://status.app/u/G00AAMRoc51ISH8d2BZpMytFzGADDhyyQPFhGDbGzhUEmx0S0zAYka3PvE8QFlPqDHqx19ue7McGDkeFhR-6pnZWf6Q9xR-6s9fD1DZSAg==#zQ3shSmkVKR6M2Z3sfNhtXmZkdgva5SMGpiWW6bDcPAQ25LmE
  2. or I ask someone else to copy the link in my profile and send it to me: https://status.app/u#8⃣.eth

Neither work :/

OK, website is a separate issue, any idea @felicio ?

caybro avatar May 10 '24 11:05 caybro

@caybro

  1. It's the desktop that didn't/doesn't encode the displayName within the url, a required field, in that case

felicio avatar May 10 '24 16:05 felicio

Hmm, it works for me on the web if I copy the link from the Profile dialog (in current master):

https://status.app/u/G1UAAMTIbW0DIiH9dTSuIZ4JRcxgAw4cskkHsYNhY-xcQahphVgge13jqxiFI7L1mfcJ4sGlXIJR7PW2J_uxgUew8PDD0LXO7o90V_OH4e71MLUNYw==#zQ3shSmkVKR6M2Z3sfNhtXmZkdgva5SMGpiWW6bDcPAQ25LmE

image

caybro avatar May 10 '24 21:05 caybro

@jrainville hmm the username renders correctly when being mentioned, but nowhere else... wonder what we do differently there :thinking:

image

caybro avatar May 10 '24 21:05 caybro

Alright, I think I got it :smile:

image

caybro avatar May 10 '24 21:05 caybro

OK, this is looking better:

image

image

But we can still see there's a lot more places (in the chat itself, incl. system messages), chat header, chat list, community user list, etc :/ I feel a bit uneasy to search/parse for those emojis in every possible place, that might actually hamper the performance quite a bit, wdyt @jrainville ?

caybro avatar May 10 '24 22:05 caybro

The emoji ens community would go wild if this would work out 🥺👉👈🙈😅

86doteth avatar May 10 '24 22:05 86doteth