open-bounty icon indicating copy to clipboard operation
open-bounty copied to clipboard

Published 20 hours ago • verified publisher icon status-im

After deleting GH repo bounties are still displayed in 'Open bounties' list

Open churik opened this issue 6 years ago • 3 comments

Description

Type: Bug

Summary: bounties from deleted repo are displayed on 'Open bounties', at attempt to open it - user is redirected to 404 page

Expected behavior

no bounties from deleted repo are shown

Actual behavior

bounties from deleted repo are still in 'Open bounties' list

Reproduction

Steps: Requirements: GH account is whitelisted, signed app, test application is added to repo;

  • create issue
  • add bounty label
  • open https://testing.openbounty.status.im/app
  • wait until new bounty will be displayed in 'Open bounties' list
  • delete repo
  • go to 'Open bounties' list

Additional Information

Video: http://take.ms/Sb8jH OS: Mac OS High Sierra Browser: Chrome 64

churik avatar Mar 15 '18 15:03 churik

This seems like it could be handled via a webhook that watches for a deleted repository event and then deletes issues and pull requests associated with that repo id.

rcullito avatar Apr 12 '18 20:04 rcullito

Sounds like we need another 'state' that bounties could be in. If this happens, or the GH issue is closed/deleted, the bounty contract is still live, so these bounties should go into a "inactive" state for the bounty issuer to revoke.

arash009 avatar Apr 13 '18 03:04 arash009

That's a good point that a manual action needs to be taken as well. Seems like there are actually quite a few use cases where bounties need to be revoked. (to all of your points in the last standup)

rcullito avatar Apr 13 '18 13:04 rcullito