open-bounty
open-bounty copied to clipboard
status-im
Remove unused and old code
Description
There is some unused code in the repo: unused global vars.
And also some old code, related to an old feature I think, about management of repositories directly in the SOB webapp, instead of through Github.
User Stories
As a developer I want to not have old and unused code in the repository so that I don't have to understand it and maintain it.
Expected Behaviour
To not have old and unused code in the repo.
Actual behaviour
Unused and old code in the repo.
@arash009
- Can that old repository management system in the SOB webapp be removed?
- Is there any other old feature that can be removed?
@pablodip I think we need to confirm with @tpatja but from my point yes we definitely should do a clean up.
@arash009 Btw, what was the reason/s to change from managing the repos in the webapp to manage them in a Github App? Would love to understand the context. :)
@pablodip Less intrusive permissions. The old way (GH oauth app with webhooks managed by SOB) requires write access to the repo, which is a problem and we got a lot of complaints for it. GH apps support more fine-grained permissions and allow users to only allow actually needed permissions to SOB.
